From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Arnaud Ebalard <arno@natisbad.org>,
Tawfik Bayouk <tawfik@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Imre Kaloz <kaloz@openwrt.org>
Subject: Re: [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support
Date: Wed, 17 Jun 2015 17:58:28 +0200 [thread overview]
Message-ID: <20150617175828.2a83cda6@bbrezillon> (raw)
In-Reply-To: <20150617173402.7946bbb0@bbrezillon>
On Wed, 17 Jun 2015 17:34:02 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> On Wed, 17 Jun 2015 23:08:08 +0800
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> > On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote:
> > >
> > > Hi Herbert,
> > >
> > > I send you this patch alone so that you can verify I'm now properly
> > > manipulating the SG list. Once I have your confirmation I'll send
> > > the whole series again and annoy all the people in Cc one more time
> > > ;-).
> >
> > Thanks. The only problem that I can see is the fact you're not
> > checking for req->src == req->dst. If they're equal then you must
> > not map it twice. Instead it should be mapped as DMA_BIDIRECTIONAL.
>
> I can check for that too, but note that it doesn't prevent one from
> providing different scatterlist structures pointing to the same memory
> region.
Actually, I don't know if it's a problem or not, so if it's not, please
ignore my comment.
> This being said, checking for req->src == req->dst should fix the case
> where dst and src are pointing to the same scatterlist, which is a good
> start.
Here is an incremental patch [1], please let me know if something else
is missing.
Thanks,
Boris
[1]http://code.bulix.org/x8mz8x-88568
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Arnaud Ebalard <arno@natisbad.org>,
Tawfik Bayouk <tawfik@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Imre Kaloz <kaloz@openw
Subject: Re: [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support
Date: Wed, 17 Jun 2015 17:58:28 +0200 [thread overview]
Message-ID: <20150617175828.2a83cda6@bbrezillon> (raw)
In-Reply-To: <20150617173402.7946bbb0@bbrezillon>
On Wed, 17 Jun 2015 17:34:02 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> On Wed, 17 Jun 2015 23:08:08 +0800
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> > On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote:
> > >
> > > Hi Herbert,
> > >
> > > I send you this patch alone so that you can verify I'm now properly
> > > manipulating the SG list. Once I have your confirmation I'll send
> > > the whole series again and annoy all the people in Cc one more time
> > > ;-).
> >
> > Thanks. The only problem that I can see is the fact you're not
> > checking for req->src == req->dst. If they're equal then you must
> > not map it twice. Instead it should be mapped as DMA_BIDIRECTIONAL.
>
> I can check for that too, but note that it doesn't prevent one from
> providing different scatterlist structures pointing to the same memory
> region.
Actually, I don't know if it's a problem or not, so if it's not, please
ignore my comment.
> This being said, checking for req->src == req->dst should fix the case
> where dst and src are pointing to the same scatterlist, which is a good
> start.
Here is an incremental patch [1], please let me know if something else
is missing.
Thanks,
Boris
[1]http://code.bulix.org/x8mz8x-88568
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Arnaud Ebalard <arno@natisbad.org>,
Tawfik Bayouk <tawfik@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Imre Kaloz <kaloz@openw>
Subject: Re: [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support
Date: Wed, 17 Jun 2015 17:58:28 +0200 [thread overview]
Message-ID: <20150617175828.2a83cda6@bbrezillon> (raw)
In-Reply-To: <20150617173402.7946bbb0@bbrezillon>
On Wed, 17 Jun 2015 17:34:02 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> On Wed, 17 Jun 2015 23:08:08 +0800
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> > On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote:
> > >
> > > Hi Herbert,
> > >
> > > I send you this patch alone so that you can verify I'm now properly
> > > manipulating the SG list. Once I have your confirmation I'll send
> > > the whole series again and annoy all the people in Cc one more time
> > > ;-).
> >
> > Thanks. The only problem that I can see is the fact you're not
> > checking for req->src == req->dst. If they're equal then you must
> > not map it twice. Instead it should be mapped as DMA_BIDIRECTIONAL.
>
> I can check for that too, but note that it doesn't prevent one from
> providing different scatterlist structures pointing to the same memory
> region.
Actually, I don't know if it's a problem or not, so if it's not, please
ignore my comment.
> This being said, checking for req->src == req->dst should fix the case
> where dst and src are pointing to the same scatterlist, which is a good
> start.
Here is an incremental patch [1], please let me know if something else
is missing.
Thanks,
Boris
[1]http://code.bulix.org/x8mz8x-88568
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support
Date: Wed, 17 Jun 2015 17:58:28 +0200 [thread overview]
Message-ID: <20150617175828.2a83cda6@bbrezillon> (raw)
In-Reply-To: <20150617173402.7946bbb0@bbrezillon>
On Wed, 17 Jun 2015 17:34:02 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> On Wed, 17 Jun 2015 23:08:08 +0800
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> > On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote:
> > >
> > > Hi Herbert,
> > >
> > > I send you this patch alone so that you can verify I'm now properly
> > > manipulating the SG list. Once I have your confirmation I'll send
> > > the whole series again and annoy all the people in Cc one more time
> > > ;-).
> >
> > Thanks. The only problem that I can see is the fact you're not
> > checking for req->src == req->dst. If they're equal then you must
> > not map it twice. Instead it should be mapped as DMA_BIDIRECTIONAL.
>
> I can check for that too, but note that it doesn't prevent one from
> providing different scatterlist structures pointing to the same memory
> region.
Actually, I don't know if it's a problem or not, so if it's not, please
ignore my comment.
> This being said, checking for req->src == req->dst should fix the case
> where dst and src are pointing to the same scatterlist, which is a good
> start.
Here is an incremental patch [1], please let me know if something else
is missing.
Thanks,
Boris
[1]http://code.bulix.org/x8mz8x-88568
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-17 15:58 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 7:45 [PATCH v6 00/14] crypto: add a new driver for Marvell's CESA Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 01/14] crypto: mv_cesa: document the clocks property Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 02/14] crypto: mv_cesa: use gen_pool to reserve the SRAM memory region Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 03/14] crypto: mv_cesa: explicitly define kirkwood and dove compatible strings Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 04/14] crypto: add a new driver for Marvell's CESA Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 05/14] crypto: marvell/CESA: add TDMA support Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 9:50 ` Herbert Xu
2015-06-17 9:50 ` Herbert Xu
2015-06-17 11:33 ` Boris Brezillon
2015-06-17 11:33 ` Boris Brezillon
2015-06-17 12:25 ` Herbert Xu
2015-06-17 12:25 ` Herbert Xu
2015-06-17 13:32 ` [PATCH v7 " Boris Brezillon
2015-06-17 13:32 ` Boris Brezillon
2015-06-17 15:08 ` Herbert Xu
2015-06-17 15:08 ` Herbert Xu
2015-06-17 15:34 ` Boris Brezillon
2015-06-17 15:34 ` Boris Brezillon
2015-06-17 15:34 ` Boris Brezillon
2015-06-17 15:58 ` Boris Brezillon [this message]
2015-06-17 15:58 ` Boris Brezillon
2015-06-17 15:58 ` Boris Brezillon
2015-06-17 15:58 ` Boris Brezillon
2015-06-18 1:42 ` Herbert Xu
2015-06-18 1:42 ` Herbert Xu
2015-06-18 1:41 ` Herbert Xu
2015-06-18 1:41 ` Herbert Xu
2015-06-18 9:04 ` [PATCH v6 " Russell King - ARM Linux
2015-06-18 9:04 ` Russell King - ARM Linux
2015-06-18 9:04 ` Russell King - ARM Linux
2015-06-18 9:04 ` Russell King - ARM Linux
2015-06-18 9:33 ` Boris Brezillon
2015-06-18 9:33 ` Boris Brezillon
2015-06-18 9:33 ` Boris Brezillon
2015-06-18 9:33 ` Boris Brezillon
2015-06-18 9:48 ` Russell King - ARM Linux
2015-06-18 9:48 ` Russell King - ARM Linux
2015-06-18 9:48 ` Russell King - ARM Linux
2015-06-18 9:48 ` Russell King - ARM Linux
2015-06-18 9:52 ` Boris Brezillon
2015-06-18 9:52 ` Boris Brezillon
2015-06-18 9:52 ` Boris Brezillon
2015-06-18 9:52 ` Boris Brezillon
2015-06-18 9:37 ` Herbert Xu
2015-06-18 9:37 ` Herbert Xu
2015-06-18 9:37 ` Herbert Xu
2015-06-18 9:37 ` Herbert Xu
2015-06-17 7:45 ` [PATCH v6 06/14] crypto: marvell/CESA: add DES support Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-18 6:57 ` Boris Brezillon
2015-06-18 6:57 ` Boris Brezillon
2015-06-18 6:57 ` Boris Brezillon
2015-06-18 6:57 ` Boris Brezillon
2015-06-18 7:02 ` Herbert Xu
2015-06-18 7:02 ` Herbert Xu
2015-06-18 7:02 ` Herbert Xu
2015-06-18 7:02 ` Herbert Xu
2015-06-17 7:45 ` [PATCH v6 07/14] crypto: marvell/CESA: add Triple-DES support Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 08/14] crypto: marvell/CESA: add MD5 support Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 09/14] crypto: marvell/CESA: add SHA256 support Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 10/14] crypto: marvell/CESA: add support for all armada SoCs Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 11/14] crypto: marvell/CESA: add allhwsupport module parameter Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 12/14] crypto: marvell/CESA: add support for Orion SoCs Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 13/14] crypto: marvell/CESA: add support for Kirkwood and Dove SoCs Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` [PATCH v6 14/14] crypto: marvell/CESA: add DT bindings documentation Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
2015-06-17 7:45 ` Boris Brezillon
-- strict thread matches above, loose matches on Subject: below --
2015-06-18 13:46 [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Boris Brezillon
2015-06-18 13:46 ` [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
2015-06-18 13:46 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617175828.2a83cda6@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arno@natisbad.org \
--cc=benavi@marvell.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=herbert@gondor.apana.org.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kaloz@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.