From: Johan Hovold <johan@kernel.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: David Howells <dhowells@redhat.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-am33-list@redhat.com, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 4/7] USB: mos7720: rename DCR
Date: Tue, 23 Jun 2015 12:09:18 +0200 [thread overview]
Message-ID: <20150623100918.GG28202@localhost> (raw)
In-Reply-To: <1434629873-11668-5-git-send-email-sudipm.mukherjee@gmail.com>
On Thu, Jun 18, 2015 at 05:47:50PM +0530, Sudip Mukherjee wrote:
> While building with mn10300 it failed with:
> error: expected identifier before '(' token
> #define __SYSREG(ADDR, TYPE) (*(volatile TYPE *)(ADDR))
> note: in expansion of macro '__SYSREG'
> #define DCR __SYSREG(0xc0000030, u16) /* Debug control register */
>
> mn10300 has a register named as DCR, so when this driver used an enum
> named as DCR, build failed.
> Just rename the DCR in the driver to parport_DCR.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/usb/serial/mos7720.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
> index 4f70df3..3263125 100644
> --- a/drivers/usb/serial/mos7720.c
> +++ b/drivers/usb/serial/mos7720.c
> @@ -135,7 +135,7 @@ enum mos_regs {
> DLM,
> DPR, /* parallel port regs */
> DSR,
> - DCR,
> + parport_DCR,
> ECR,
> SP1_REG, /* device control regs */
> SP2_REG, /* serial port 2 (7720 only) */
Please use a MOS_ (or MOS7720_) prefix instead and add it to all the
registers.
Thanks,
Johan
WARNING: multiple messages have this Message-ID (diff)
From: johan@kernel.org (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/7] USB: mos7720: rename DCR
Date: Tue, 23 Jun 2015 12:09:18 +0200 [thread overview]
Message-ID: <20150623100918.GG28202@localhost> (raw)
In-Reply-To: <1434629873-11668-5-git-send-email-sudipm.mukherjee@gmail.com>
On Thu, Jun 18, 2015 at 05:47:50PM +0530, Sudip Mukherjee wrote:
> While building with mn10300 it failed with:
> error: expected identifier before '(' token
> #define __SYSREG(ADDR, TYPE) (*(volatile TYPE *)(ADDR))
> note: in expansion of macro '__SYSREG'
> #define DCR __SYSREG(0xc0000030, u16) /* Debug control register */
>
> mn10300 has a register named as DCR, so when this driver used an enum
> named as DCR, build failed.
> Just rename the DCR in the driver to parport_DCR.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/usb/serial/mos7720.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
> index 4f70df3..3263125 100644
> --- a/drivers/usb/serial/mos7720.c
> +++ b/drivers/usb/serial/mos7720.c
> @@ -135,7 +135,7 @@ enum mos_regs {
> DLM,
> DPR, /* parallel port regs */
> DSR,
> - DCR,
> + parport_DCR,
> ECR,
> SP1_REG, /* device control regs */
> SP2_REG, /* serial port 2 (7720 only) */
Please use a MOS_ (or MOS7720_) prefix instead and add it to all the
registers.
Thanks,
Johan
next prev parent reply other threads:[~2015-06-23 10:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 12:17 [PATCH v2 0/7] fix build failure of mn10300 Sudip Mukherjee
2015-06-18 12:17 ` Sudip Mukherjee
2015-06-18 12:17 ` [PATCH v2 1/7] mn10300: fix build failure Sudip Mukherjee
2015-06-18 12:17 ` Sudip Mukherjee
2015-07-16 7:17 ` Sudip Mukherjee
2015-07-16 21:54 ` Andrew Morton
2015-07-17 5:06 ` Sudip Mukherjee
2015-06-18 12:17 ` [PATCH v2 2/7] mn10300: Provide dummy dma_alloc_attrs() and dma_free_attrs() Sudip Mukherjee
2015-06-18 12:17 ` Sudip Mukherjee
2015-06-18 12:17 ` Sudip Mukherjee
2015-06-18 12:17 ` [PATCH v2 3/7] mmc: mediatek: build as module Sudip Mukherjee
2015-06-18 12:17 ` Sudip Mukherjee
2015-06-18 13:10 ` Ulf Hansson
2015-06-18 13:10 ` Ulf Hansson
2015-06-18 13:10 ` Ulf Hansson
2015-06-18 12:17 ` [PATCH v2 4/7] USB: mos7720: rename DCR Sudip Mukherjee
2015-06-18 12:17 ` Sudip Mukherjee
2015-06-23 10:09 ` Johan Hovold [this message]
2015-06-23 10:09 ` Johan Hovold
2015-06-23 13:29 ` [PATCH v3] USB: mos7720: rename registers Sudip Mukherjee
2015-06-26 7:46 ` Johan Hovold
2015-06-26 13:53 ` Sudip Mukherjee
2015-06-18 12:17 ` [PATCH v2 5/7] samples: kdbus: disable for mn10300 Sudip Mukherjee
2015-06-18 12:17 ` Sudip Mukherjee
2015-06-18 14:39 ` Greg Kroah-Hartman
2015-06-18 14:39 ` Greg Kroah-Hartman
2015-06-18 16:19 ` Sudip Mukherjee
2015-06-18 16:19 ` Sudip Mukherjee
2015-06-18 16:19 ` Sudip Mukherjee
2015-06-18 16:25 ` Greg Kroah-Hartman
2015-06-18 16:25 ` Greg Kroah-Hartman
2015-06-18 12:17 ` [PATCH v2 6/7] mn10300: kgdb_arch_set_pc Sudip Mukherjee
2015-06-18 12:17 ` Sudip Mukherjee
2015-06-18 12:17 ` [PATCH v2 7/7] mn10300: add early_init_dt_* Sudip Mukherjee
2015-06-18 12:17 ` Sudip Mukherjee
2015-06-18 12:17 ` Sudip Mukherjee
2015-06-18 14:51 ` [PATCH v2 0/7] fix build failure of mn10300 Russell King - ARM Linux
2015-06-18 14:51 ` Russell King - ARM Linux
[not found] ` <CAA0PaPGMtePS+fmpi1QBZi8uHtuU3Z7_Y+9f0+O38o+8xfo+1Q@mail.gmail.com>
2015-06-18 15:44 ` [Linux-am33-list] " Russell King - ARM Linux
2015-06-18 15:44 ` Russell King - ARM Linux
2015-06-18 15:44 ` Russell King - ARM Linux
2015-06-18 16:13 ` Sudip Mukherjee
2015-06-18 16:13 ` Sudip Mukherjee
2015-06-18 16:13 ` Sudip Mukherjee
2015-07-10 11:20 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623100918.GG28202@localhost \
--to=johan@kernel.org \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.