From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] mmc: sdhci-esdhc-imx: remove duplicated dts parsing
Date: Thu, 9 Jul 2015 15:38:35 +0800 [thread overview]
Message-ID: <20150709073835.GC23464@tiger> (raw)
In-Reply-To: <1434564337-24720-5-git-send-email-aisheng.dong@freescale.com>
On Thu, Jun 18, 2015 at 02:05:35AM +0800, Dong Aisheng wrote:
> After commit 8d86e4fcccf6 ("mmc: sdhci-esdhc-imx: Call mmc_of_parse()"),
> we do not need those duplicated parsing anymore.
>
> Note: fsl,cd-controller is also deleted due to the driver does
> not support controller card detection anymore after switch to runtime pm.
> And there's no user of it right now in device tree.
>
> wp-gpios is kept because we're still support fsl,wp-controller,
> so we need a way to check if it's gpio wp or controller wp.
I do not remember the reason why controller based CD stops working after
we switch to runtime PM. But if CD stops working for some reason,
shouldn't controller based WP stop working for the same reason?
Shawn
>
> Signed-off-by: Dong Aisheng <aisheng.dong@freescale.com>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Dong Aisheng <aisheng.dong@freescale.com>
Cc: linux-mmc@vger.kernel.org, fabio.estevam@freescale.com,
marex@denx.de, ulf.hansson@linaro.org, s.trumtrar@pengutronix.de,
smoch@web.de, linux-arm-kernel@lists.infradead.org,
robertcnelson@gmail.com, s.hauer@pengutronix.de,
chris@printf.net, rabeeh@solid-run.com,
troy.kisky@boundarydevices.com, lisovy@gmail.com, hs@denx.de,
gwenhael.goavec-merou@armadeus.com, p.zabel@pengutronix.de,
rmk+kernel@arm.linux.org.uk, shawn.guo@linaro.org,
b29396@freescale.com, tharvey@gateworks.com,
LW@KARO-electronics.de, ipaton0@gmail.com
Subject: Re: [PATCH 4/6] mmc: sdhci-esdhc-imx: remove duplicated dts parsing
Date: Thu, 9 Jul 2015 15:38:35 +0800 [thread overview]
Message-ID: <20150709073835.GC23464@tiger> (raw)
In-Reply-To: <1434564337-24720-5-git-send-email-aisheng.dong@freescale.com>
On Thu, Jun 18, 2015 at 02:05:35AM +0800, Dong Aisheng wrote:
> After commit 8d86e4fcccf6 ("mmc: sdhci-esdhc-imx: Call mmc_of_parse()"),
> we do not need those duplicated parsing anymore.
>
> Note: fsl,cd-controller is also deleted due to the driver does
> not support controller card detection anymore after switch to runtime pm.
> And there's no user of it right now in device tree.
>
> wp-gpios is kept because we're still support fsl,wp-controller,
> so we need a way to check if it's gpio wp or controller wp.
I do not remember the reason why controller based CD stops working after
we switch to runtime PM. But if CD stops working for some reason,
shouldn't controller based WP stop working for the same reason?
Shawn
>
> Signed-off-by: Dong Aisheng <aisheng.dong@freescale.com>
next prev parent reply other threads:[~2015-07-09 7:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 18:05 [PATCH 0/6] mmc: sdhci-esdhci-imx: fix cd/wp regression Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 1/6] mmc: sdhci-esdhc-imx: fix cd regression for dt platform Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 2/6] mmc: sdhci-esdhc-imx: move all non dt probe code into one function Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 3/6] mmc: sdhci: make max-frequency property in device tree work Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 4/6] mmc: sdhci-esdhc-imx: remove duplicated dts parsing Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-07-09 7:38 ` Shawn Guo [this message]
2015-07-09 7:38 ` Shawn Guo
2015-07-09 8:59 ` Dong Aisheng
2015-07-09 8:59 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 5/6] mmc: sdhci-esdhc-imx: clear f_max in boarddata Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 6/6] dts: mmc: fsl-imx-esdhc: remove fsl, cd-controller support Dong Aisheng
2015-06-17 18:05 ` [PATCH 6/6] dts: mmc: fsl-imx-esdhc: remove fsl,cd-controller support Dong Aisheng
2015-07-06 11:57 ` [PATCH 0/6] mmc: sdhci-esdhci-imx: fix cd/wp regression Johan Derycke
2015-07-09 7:50 ` Shawn Guo
2015-07-09 7:50 ` Shawn Guo
2015-07-09 9:29 ` Dong Aisheng
2015-07-09 9:29 ` Dong Aisheng
2015-07-09 13:27 ` Shawn Guo
2015-07-09 13:27 ` Shawn Guo
2015-07-09 17:02 ` Enrico Weigelt, metux IT consult
2015-07-09 17:02 ` Enrico Weigelt, metux IT consult
2015-07-13 11:43 ` Dong Aisheng
2015-07-13 11:43 ` Dong Aisheng
2015-07-14 5:25 ` Soeren Moch
2015-07-14 5:25 ` Soeren Moch
2015-07-22 13:59 ` Dong Aisheng
2015-07-22 13:59 ` Dong Aisheng
2015-07-20 12:44 ` Ulf Hansson
2015-07-20 12:44 ` Ulf Hansson
2015-07-22 14:05 ` Dong Aisheng
2015-07-22 14:05 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709073835.GC23464@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.