From: b29396@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/6] mmc: sdhci-esdhci-imx: fix cd/wp regression
Date: Wed, 22 Jul 2015 21:59:42 +0800 [thread overview]
Message-ID: <20150722135939.GA13623@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <55A49D35.7010002@web.de>
On Tue, Jul 14, 2015 at 07:25:09AM +0200, Soeren Moch wrote:
>
>
> On 13.07.2015 13:43, Dong Aisheng wrote:
> > On Thu, Jul 09, 2015 at 09:27:36PM +0800, Shawn Guo wrote:
> >> On Thu, Jul 09, 2015 at 05:29:50PM +0800, Dong Aisheng wrote:
> >>> I agree with you.
> >>> One difference is that i'd like to fix it ASAP without reverting 8d86e4f
> >>> due to more patches depends on it is already there as i mentioned above..
> >>> Revert it may need to revert a lot others.
> >>>
> >>> The pain is that v4.1 is left broken.
> >>
> >> Oh, crap! I thought it's been there with only v4.2-rc1, and did not
> >> know v4.1 is already broken. In that case, reverting 8d86e4f isn't
> >> the best option. I suggest you rebase the dts series on top of
> >> v4.2-rc1, and send it via mmc tree.
> >>
> >
> > Yes, will go that way.
> >
> > Then you may need help take care of new dts going through your tree
> > to make sure no broken code in again.
>
> Dong,
>
> I use a microSD card (mmc0) with the root filesystem on a tbs2910 board.
> I cannot see any difference between linux-4.0 and linux-4.1 (vanilla
> kernel with corresponding dtb), there is absolutely no problem with card
> detect.
>
> Can you please explain what exactly is broken in linux-4.1?
>
The CD function is broken.
If you enable CONFIG_MMC_DEBUG, you will see the MMC core keep polling the
card because MMC_CAP_NEEDS_POLL is wrongly set.
You can refer to cover-letter for more detailed explaination.
If you're using a non-removable card(having non-removable property in dts),
you may not have this issue.
Regards
Dong Aisheng
> Thanks,
> Soeren
>
> > Thanks
> >
> > Regards
> > Dong Aisheng
> >
> >> Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Dong Aisheng <b29396@freescale.com>
To: Soeren Moch <smoch@web.de>
Cc: Shawn Guo <shawnguo@kernel.org>,
Dong Aisheng <aisheng.dong@freescale.com>,
ulf.hansson@linaro.org, chris@printf.net,
s.trumtrar@pengutronix.de, LW@KARO-electronics.de, marex@denx.de,
rabeeh@solid-run.com, gwenhael.goavec-merou@armadeus.com,
rmk+kernel@arm.linux.org.uk, hs@denx.de, tharvey@gateworks.com,
s.hauer@pengutronix.de, troy.kisky@boundarydevices.com,
lisovy@gmail.com, robertcnelson@gmail.com,
linux-arm-kernel@lists.infradead.org, ipaton0@gmail.com,
fabio.estevam@freescale.com, linux-mmc@vger.kernel.org,
p.zabel@pengutronix.de, shawn.guo@linaro.org
Subject: Re: [PATCH 0/6] mmc: sdhci-esdhci-imx: fix cd/wp regression
Date: Wed, 22 Jul 2015 21:59:42 +0800 [thread overview]
Message-ID: <20150722135939.GA13623@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <55A49D35.7010002@web.de>
On Tue, Jul 14, 2015 at 07:25:09AM +0200, Soeren Moch wrote:
>
>
> On 13.07.2015 13:43, Dong Aisheng wrote:
> > On Thu, Jul 09, 2015 at 09:27:36PM +0800, Shawn Guo wrote:
> >> On Thu, Jul 09, 2015 at 05:29:50PM +0800, Dong Aisheng wrote:
> >>> I agree with you.
> >>> One difference is that i'd like to fix it ASAP without reverting 8d86e4f
> >>> due to more patches depends on it is already there as i mentioned above..
> >>> Revert it may need to revert a lot others.
> >>>
> >>> The pain is that v4.1 is left broken.
> >>
> >> Oh, crap! I thought it's been there with only v4.2-rc1, and did not
> >> know v4.1 is already broken. In that case, reverting 8d86e4f isn't
> >> the best option. I suggest you rebase the dts series on top of
> >> v4.2-rc1, and send it via mmc tree.
> >>
> >
> > Yes, will go that way.
> >
> > Then you may need help take care of new dts going through your tree
> > to make sure no broken code in again.
>
> Dong,
>
> I use a microSD card (mmc0) with the root filesystem on a tbs2910 board.
> I cannot see any difference between linux-4.0 and linux-4.1 (vanilla
> kernel with corresponding dtb), there is absolutely no problem with card
> detect.
>
> Can you please explain what exactly is broken in linux-4.1?
>
The CD function is broken.
If you enable CONFIG_MMC_DEBUG, you will see the MMC core keep polling the
card because MMC_CAP_NEEDS_POLL is wrongly set.
You can refer to cover-letter for more detailed explaination.
If you're using a non-removable card(having non-removable property in dts),
you may not have this issue.
Regards
Dong Aisheng
> Thanks,
> Soeren
>
> > Thanks
> >
> > Regards
> > Dong Aisheng
> >
> >> Shawn
next prev parent reply other threads:[~2015-07-22 13:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 18:05 [PATCH 0/6] mmc: sdhci-esdhci-imx: fix cd/wp regression Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 1/6] mmc: sdhci-esdhc-imx: fix cd regression for dt platform Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 2/6] mmc: sdhci-esdhc-imx: move all non dt probe code into one function Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 3/6] mmc: sdhci: make max-frequency property in device tree work Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 4/6] mmc: sdhci-esdhc-imx: remove duplicated dts parsing Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-07-09 7:38 ` Shawn Guo
2015-07-09 7:38 ` Shawn Guo
2015-07-09 8:59 ` Dong Aisheng
2015-07-09 8:59 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 5/6] mmc: sdhci-esdhc-imx: clear f_max in boarddata Dong Aisheng
2015-06-17 18:05 ` Dong Aisheng
2015-06-17 18:05 ` [PATCH 6/6] dts: mmc: fsl-imx-esdhc: remove fsl, cd-controller support Dong Aisheng
2015-06-17 18:05 ` [PATCH 6/6] dts: mmc: fsl-imx-esdhc: remove fsl,cd-controller support Dong Aisheng
2015-07-06 11:57 ` [PATCH 0/6] mmc: sdhci-esdhci-imx: fix cd/wp regression Johan Derycke
2015-07-09 7:50 ` Shawn Guo
2015-07-09 7:50 ` Shawn Guo
2015-07-09 9:29 ` Dong Aisheng
2015-07-09 9:29 ` Dong Aisheng
2015-07-09 13:27 ` Shawn Guo
2015-07-09 13:27 ` Shawn Guo
2015-07-09 17:02 ` Enrico Weigelt, metux IT consult
2015-07-09 17:02 ` Enrico Weigelt, metux IT consult
2015-07-13 11:43 ` Dong Aisheng
2015-07-13 11:43 ` Dong Aisheng
2015-07-14 5:25 ` Soeren Moch
2015-07-14 5:25 ` Soeren Moch
2015-07-22 13:59 ` Dong Aisheng [this message]
2015-07-22 13:59 ` Dong Aisheng
2015-07-20 12:44 ` Ulf Hansson
2015-07-20 12:44 ` Ulf Hansson
2015-07-22 14:05 ` Dong Aisheng
2015-07-22 14:05 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722135939.GA13623@shlinux1.ap.freescale.net \
--to=b29396@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.