From: Mark Brown <broonie@kernel.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org,
linux-gpio@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
linux-acpi@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Linux PWM List <linux-pwm@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes
Date: Mon, 13 Jul 2015 16:42:55 +0100 [thread overview]
Message-ID: <20150713154254.GH11162@sirena.org.uk> (raw)
In-Reply-To: <CAAObsKDsEuDS46rW9CMuviDEDV-OVXe5q-kiWmw0D_n2D3Tf5A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote:
> On 1 July 2015 at 19:38, Mark Brown <broonie@kernel.org> wrote:
> > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote:
> >> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode,
> >> + struct list_head *deps)
> >> +{
> >> + add_dependency(fwnode, "nvidia,i2s-controller", deps);
> >> + add_dependency(fwnode, "nvidia,audio-codec", deps);
> >> +}
> > Why is this all being open coded in an individual driver (we already
> > know about and manage all these dependencies in the core...)? If we're
> > going to do this I'd expect the interface for specifying DT nodes to the
> > core to be changed to support this.
> Are you thinking of changing drivers to acquire their resources
> through Arnd's devm_probe (only that the resource table would have to
> be in struct device_driver)?
> https://lkml.kernel.org/g/4742258.TBitC3hVuO@wuerfel
No, I'm looking at how we already have all the "did all my dependencies
appear" logic in the core based on data provided by the drivers.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linux PWM List
<linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes
Date: Mon, 13 Jul 2015 16:42:55 +0100 [thread overview]
Message-ID: <20150713154254.GH11162@sirena.org.uk> (raw)
In-Reply-To: <CAAObsKDsEuDS46rW9CMuviDEDV-OVXe5q-kiWmw0D_n2D3Tf5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote:
> On 1 July 2015 at 19:38, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote:
> >> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode,
> >> + struct list_head *deps)
> >> +{
> >> + add_dependency(fwnode, "nvidia,i2s-controller", deps);
> >> + add_dependency(fwnode, "nvidia,audio-codec", deps);
> >> +}
> > Why is this all being open coded in an individual driver (we already
> > know about and manage all these dependencies in the core...)? If we're
> > going to do this I'd expect the interface for specifying DT nodes to the
> > core to be changed to support this.
> Are you thinking of changing drivers to acquire their resources
> through Arnd's devm_probe (only that the resource table would have to
> be in struct device_driver)?
> https://lkml.kernel.org/g/4742258.TBitC3hVuO@wuerfel
No, I'm looking at how we already have all the "did all my dependencies
appear" logic in the core based on data provided by the drivers.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linux PWM List
<linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes
Date: Mon, 13 Jul 2015 15:42:55 +0000 [thread overview]
Message-ID: <20150713154254.GH11162@sirena.org.uk> (raw)
In-Reply-To: <CAAObsKDsEuDS46rW9CMuviDEDV-OVXe5q-kiWmw0D_n2D3Tf5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote:
> On 1 July 2015 at 19:38, Mark Brown <broonie@kernel.org> wrote:
> > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote:
> >> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode,
> >> + struct list_head *deps)
> >> +{
> >> + add_dependency(fwnode, "nvidia,i2s-controller", deps);
> >> + add_dependency(fwnode, "nvidia,audio-codec", deps);
> >> +}
> > Why is this all being open coded in an individual driver (we already
> > know about and manage all these dependencies in the core...)? If we're
> > going to do this I'd expect the interface for specifying DT nodes to the
> > core to be changed to support this.
> Are you thinking of changing drivers to acquire their resources
> through Arnd's devm_probe (only that the resource table would have to
> be in struct device_driver)?
> https://lkml.kernel.org/g/4742258.TBitC3hVuO@wuerfel
No, I'm looking at how we already have all the "did all my dependencies
appear" logic in the core based on data provided by the drivers.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-13 15:44 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 9:40 [PATCH v2 0/12] Discover and probe dependencies Tomeu Vizoso
2015-07-01 9:40 ` Tomeu Vizoso
2015-07-01 9:40 ` Tomeu Vizoso
2015-07-01 9:40 ` [PATCH v2 01/12] device: property: delay device-driver matches Tomeu Vizoso
2015-07-01 9:40 ` Tomeu Vizoso
2015-07-01 9:40 ` Tomeu Vizoso
2015-07-01 23:29 ` Rafael J. Wysocki
2015-07-01 23:29 ` Rafael J. Wysocki
2015-07-10 11:39 ` Tomeu Vizoso
2015-07-10 11:39 ` Tomeu Vizoso
2015-07-10 11:39 ` Tomeu Vizoso
2015-07-16 20:23 ` Mark Brown
2015-07-16 20:23 ` Mark Brown
2015-07-16 23:41 ` Rafael J. Wysocki
2015-07-16 23:41 ` Rafael J. Wysocki
2015-07-16 23:41 ` Rafael J. Wysocki
2015-07-17 0:06 ` Mark Brown
2015-07-17 0:06 ` Mark Brown
2015-07-01 9:40 ` [PATCH v2 02/12] device: property: find dependencies of a firmware node Tomeu Vizoso
2015-07-01 9:40 ` Tomeu Vizoso
2015-07-01 9:40 ` Tomeu Vizoso
2015-07-01 23:36 ` Rafael J. Wysocki
2015-07-02 0:02 ` Rafael J. Wysocki
2015-07-10 13:14 ` [alsa-devel] " Tomeu Vizoso
2015-07-10 13:14 ` Tomeu Vizoso
2015-07-10 13:14 ` Tomeu Vizoso
2015-07-11 2:52 ` Rafael J. Wysocki
2015-07-11 2:52 ` Rafael J. Wysocki
2015-07-11 2:52 ` Rafael J. Wysocki
2015-07-01 9:40 ` [PATCH v2 03/12] string: Introduce strends() Tomeu Vizoso
2015-07-01 9:40 ` Tomeu Vizoso
2015-07-01 9:40 ` Tomeu Vizoso
2015-07-01 9:40 ` [PATCH v2 04/12] gpio: register dependency parser for firmware nodes Tomeu Vizoso
2015-07-01 9:40 ` Tomeu Vizoso
2015-07-01 9:40 ` Tomeu Vizoso
2015-07-01 9:41 ` [PATCH v2 05/12] gpu: host1x: " Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` [PATCH v2 06/12] backlight: Document consumers of backlight nodes Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` [PATCH v2 07/12] backlight: register dependency parser for firmware nodes Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` [PATCH v2 08/12] USB: EHCI: " Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` [PATCH v2 09/12] regulator: " Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-16 21:38 ` Mark Brown
2015-07-16 21:38 ` Mark Brown
2015-07-01 9:41 ` [PATCH v2 10/12] pwm: " Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` [PATCH v2 11/12] ASoC: tegra: " Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 17:38 ` Mark Brown
2015-07-01 17:38 ` Mark Brown
2015-07-13 12:10 ` [alsa-devel] " Tomeu Vizoso
2015-07-13 12:10 ` Tomeu Vizoso
2015-07-13 12:10 ` Tomeu Vizoso
2015-07-13 15:42 ` Mark Brown [this message]
2015-07-13 15:42 ` Mark Brown
2015-07-13 15:42 ` Mark Brown
2015-07-14 7:34 ` Tomeu Vizoso
2015-07-14 7:34 ` Tomeu Vizoso
2015-07-14 7:34 ` Tomeu Vizoso
2015-07-14 11:07 ` Mark Brown
2015-07-14 11:07 ` Mark Brown
2015-07-14 11:07 ` Mark Brown
2015-07-14 12:47 ` Tomeu Vizoso
2015-07-14 12:47 ` Tomeu Vizoso
2015-07-14 12:47 ` Tomeu Vizoso
2015-07-16 23:04 ` Mark Brown
2015-07-16 23:04 ` Mark Brown
2015-07-01 9:41 ` [PATCH v2 12/12] driver-core: probe dependencies before probing Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
2015-07-01 9:41 ` Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713154254.GH11162@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.de \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.