From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao2.yu@samsung.com>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Fan Li <fanofcode.li@samsung.com>
Subject: Re: [f2fs-dev] [PATCH RESEND] f2fs: maintain extent cache in separated file
Date: Tue, 14 Jul 2015 12:19:58 -0700 [thread overview]
Message-ID: <20150714191958.GA78887@jaegeuk-mac02> (raw)
In-Reply-To: <00f201d0be1d$78aa7370$69ff5a50$@samsung.com>
On Tue, Jul 14, 2015 at 06:10:50PM +0800, Chao Yu wrote:
> Hi Jaegeuk,
>
> > -----Original Message-----
> > From: Chao Yu [mailto:yuchaochina@hotmail.com]
> > Sent: Thursday, July 09, 2015 12:16 AM
> > To: 'Jaegeuk Kim'
> > Cc: linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
> > Subject: Re: [f2fs-dev] [PATCH RESEND] f2fs: maintain extent cache in separated file
> >
> > >From 8956df8fa1a669e8e476456e4afe0eccd8174684 Mon Sep 17 00:00:00 2001
> > From: Chao Yu <chao2.yu@samsung.com>
> > Date: Wed, 8 Jul 2015 20:49:05 +0800
> > Subject: [PATCH] f2fs: maintain extent cache in separated file
> >
> > This patch moves extent cache related code from data.c into extent_cache.c
> > since extent cache is independent feature, and its codes are not relate to
> > others in data.c, it's better for us to maintain them in separated place.
> >
> > There is no functionality change, but several small coding style fixes
> > including:
> > * rename __drop_largest_extent to f2fs_drop_largest_extent for exporting;
> > * rename misspelled word 'untill' to 'until';
> > * remove unneeded 'return' in the end of f2fs_destroy_extent_tree().
> >
>
> I think commit 0b84ceec9891 ("f2fs: don't try to split extents shorter than
> F2FS_MIN_EXTENT_LEN") is conflict with commit 392a1c419916 ("f2fs: maintain
> extent cache in separated file"), and it's not well resolved in dev-test.
>
> in commit 392a1c419916 ("f2fs: maintain extent cache in separated file"):
>
> - if (dei.len > F2FS_MIN_EXTENT_LEN) {
>
> + if (dei.len > 1) {
Good catch.
Not a big deal, so I just resolved that in this patch. :)
Thanks,
>
> So how about merging this patch (f2fs: maintain extent cache in separated file)
> first, and then merge Fan's patch? because one line modification in extent_cache.c
> for fixing conflict seems much easier.
>
> BTW, I have already fixed the building error in this patch, you can directly
> use the last sent patch in this thread showed in below link. :)
>
> http://sourceforge.net/p/linux-f2fs/mailman/message/34277570/
>
> Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao2.yu@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH RESEND] f2fs: maintain extent cache in separated file
Date: Tue, 14 Jul 2015 12:19:58 -0700 [thread overview]
Message-ID: <20150714191958.GA78887@jaegeuk-mac02> (raw)
In-Reply-To: <00f201d0be1d$78aa7370$69ff5a50$@samsung.com>
On Tue, Jul 14, 2015 at 06:10:50PM +0800, Chao Yu wrote:
> Hi Jaegeuk,
>
> > -----Original Message-----
> > From: Chao Yu [mailto:yuchaochina@hotmail.com]
> > Sent: Thursday, July 09, 2015 12:16 AM
> > To: 'Jaegeuk Kim'
> > Cc: linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
> > Subject: Re: [f2fs-dev] [PATCH RESEND] f2fs: maintain extent cache in separated file
> >
> > >From 8956df8fa1a669e8e476456e4afe0eccd8174684 Mon Sep 17 00:00:00 2001
> > From: Chao Yu <chao2.yu@samsung.com>
> > Date: Wed, 8 Jul 2015 20:49:05 +0800
> > Subject: [PATCH] f2fs: maintain extent cache in separated file
> >
> > This patch moves extent cache related code from data.c into extent_cache.c
> > since extent cache is independent feature, and its codes are not relate to
> > others in data.c, it's better for us to maintain them in separated place.
> >
> > There is no functionality change, but several small coding style fixes
> > including:
> > * rename __drop_largest_extent to f2fs_drop_largest_extent for exporting;
> > * rename misspelled word 'untill' to 'until';
> > * remove unneeded 'return' in the end of f2fs_destroy_extent_tree().
> >
>
> I think commit 0b84ceec9891 ("f2fs: don't try to split extents shorter than
> F2FS_MIN_EXTENT_LEN") is conflict with commit 392a1c419916 ("f2fs: maintain
> extent cache in separated file"), and it's not well resolved in dev-test.
>
> in commit 392a1c419916 ("f2fs: maintain extent cache in separated file"):
>
> - if (dei.len > F2FS_MIN_EXTENT_LEN) {
>
> + if (dei.len > 1) {
Good catch.
Not a big deal, so I just resolved that in this patch. :)
Thanks,
>
> So how about merging this patch (f2fs: maintain extent cache in separated file)
> first, and then merge Fan's patch? because one line modification in extent_cache.c
> for fixing conflict seems much easier.
>
> BTW, I have already fixed the building error in this patch, you can directly
> use the last sent patch in this thread showed in below link. :)
>
> http://sourceforge.net/p/linux-f2fs/mailman/message/34277570/
>
> Thanks,
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
next prev parent reply other threads:[~2015-07-14 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 9:59 [PATCH RESEND] f2fs: maintain extent cache in separated file Chao Yu
2015-07-08 16:16 ` [f2fs-dev] " Chao Yu
2015-07-08 16:16 ` Chao Yu
2015-07-14 10:10 ` Chao Yu
2015-07-14 19:19 ` Jaegeuk Kim [this message]
2015-07-14 19:19 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714191958.GA78887@jaegeuk-mac02 \
--to=jaegeuk@kernel.org \
--cc=chao2.yu@samsung.com \
--cc=fanofcode.li@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.