From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
amwang@redhat.com
Subject: Re: [PATCH net] bridge: mdb: fix double add notification
Date: Wed, 15 Jul 2015 17:15:41 -0700 (PDT) [thread overview]
Message-ID: <20150715.171541.949546821782337351.davem@davemloft.net> (raw)
In-Reply-To: <1436794579-4188-1-git-send-email-nikolay@cumulusnetworks.com>
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Mon, 13 Jul 2015 06:36:19 -0700
> Since the mdb add/del code was introduced there have been 2 br_mdb_notify
> calls when doing br_mdb_add() resulting in 2 notifications on each add.
>
> Example:
> Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent
> Before patch:
> root@debian:~# bridge monitor all
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
>
> After patch:
> root@debian:~# bridge monitor all
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Fixes: cfd567543590 ("bridge: add support of adding and deleting mdb entries")
Applied and queued up for -stable, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
amwang@redhat.com
Subject: Re: [Bridge] [PATCH net] bridge: mdb: fix double add notification
Date: Wed, 15 Jul 2015 17:15:41 -0700 (PDT) [thread overview]
Message-ID: <20150715.171541.949546821782337351.davem@davemloft.net> (raw)
In-Reply-To: <1436794579-4188-1-git-send-email-nikolay@cumulusnetworks.com>
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Mon, 13 Jul 2015 06:36:19 -0700
> Since the mdb add/del code was introduced there have been 2 br_mdb_notify
> calls when doing br_mdb_add() resulting in 2 notifications on each add.
>
> Example:
> Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent
> Before patch:
> root@debian:~# bridge monitor all
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
>
> After patch:
> root@debian:~# bridge monitor all
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Fixes: cfd567543590 ("bridge: add support of adding and deleting mdb entries")
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2015-07-16 0:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 13:36 [PATCH net] bridge: mdb: fix double add notification Nikolay Aleksandrov
2015-07-13 13:36 ` [Bridge] " Nikolay Aleksandrov
2015-07-14 3:53 ` Cong Wang
2015-07-14 3:53 ` [Bridge] " Cong Wang
2015-07-16 0:15 ` David Miller [this message]
2015-07-16 0:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715.171541.949546821782337351.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.