From: Cong Wang <cwang@twopensource.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev <netdev@vger.kernel.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
Cong Wang <amwang@redhat.com>, David Miller <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net] bridge: mdb: fix double add notification
Date: Mon, 13 Jul 2015 20:53:38 -0700 [thread overview]
Message-ID: <CAHA+R7OJ0bQ_vG7Tt8jZ8gkdjevjXL-4ER7ZhTjL1CmARsFqgw@mail.gmail.com> (raw)
In-Reply-To: <1436794579-4188-1-git-send-email-nikolay@cumulusnetworks.com>
On Mon, Jul 13, 2015 at 6:36 AM, Nikolay Aleksandrov
<nikolay@cumulusnetworks.com> wrote:
> Since the mdb add/del code was introduced there have been 2 br_mdb_notify
> calls when doing br_mdb_add() resulting in 2 notifications on each add.
>
> Example:
> Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent
> Before patch:
> root@debian:~# bridge monitor all
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
>
> After patch:
> root@debian:~# bridge monitor all
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Fixes: cfd567543590 ("bridge: add support of adding and deleting mdb entries")
> ---
> net/bridge/br_mdb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
> index c11cf2611db0..1198a3dbad95 100644
> --- a/net/bridge/br_mdb.c
> +++ b/net/bridge/br_mdb.c
> @@ -351,7 +351,6 @@ static int br_mdb_add_group(struct net_bridge *br, struct net_bridge_port *port,
> if (state == MDB_TEMPORARY)
> mod_timer(&p->timer, now + br->multicast_membership_interval);
>
> - br_mdb_notify(br->dev, port, group, RTM_NEWMDB);
> return 0;
> }
Looks good to me.
And probably we can convert existing __br_mdb_notify() to using
non-atomic allocation too, but that is for net-next.
WARNING: multiple messages have this Message-ID (diff)
From: Cong Wang <cwang@twopensource.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev <netdev@vger.kernel.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
Cong Wang <amwang@redhat.com>, David Miller <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net] bridge: mdb: fix double add notification
Date: Mon, 13 Jul 2015 20:53:38 -0700 [thread overview]
Message-ID: <CAHA+R7OJ0bQ_vG7Tt8jZ8gkdjevjXL-4ER7ZhTjL1CmARsFqgw@mail.gmail.com> (raw)
In-Reply-To: <1436794579-4188-1-git-send-email-nikolay@cumulusnetworks.com>
On Mon, Jul 13, 2015 at 6:36 AM, Nikolay Aleksandrov
<nikolay@cumulusnetworks.com> wrote:
> Since the mdb add/del code was introduced there have been 2 br_mdb_notify
> calls when doing br_mdb_add() resulting in 2 notifications on each add.
>
> Example:
> Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent
> Before patch:
> root@debian:~# bridge monitor all
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
>
> After patch:
> root@debian:~# bridge monitor all
> [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Fixes: cfd567543590 ("bridge: add support of adding and deleting mdb entries")
> ---
> net/bridge/br_mdb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
> index c11cf2611db0..1198a3dbad95 100644
> --- a/net/bridge/br_mdb.c
> +++ b/net/bridge/br_mdb.c
> @@ -351,7 +351,6 @@ static int br_mdb_add_group(struct net_bridge *br, struct net_bridge_port *port,
> if (state == MDB_TEMPORARY)
> mod_timer(&p->timer, now + br->multicast_membership_interval);
>
> - br_mdb_notify(br->dev, port, group, RTM_NEWMDB);
> return 0;
> }
Looks good to me.
And probably we can convert existing __br_mdb_notify() to using
non-atomic allocation too, but that is for net-next.
next prev parent reply other threads:[~2015-07-14 3:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 13:36 [PATCH net] bridge: mdb: fix double add notification Nikolay Aleksandrov
2015-07-13 13:36 ` [Bridge] " Nikolay Aleksandrov
2015-07-14 3:53 ` Cong Wang [this message]
2015-07-14 3:53 ` Cong Wang
2015-07-16 0:15 ` David Miller
2015-07-16 0:15 ` [Bridge] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHA+R7OJ0bQ_vG7Tt8jZ8gkdjevjXL-4ER7ZhTjL1CmARsFqgw@mail.gmail.com \
--to=cwang@twopensource.com \
--cc=amwang@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.