From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>,
wg@grandegger.com, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings
Date: Mon, 14 Sep 2015 15:30:22 +0200 [thread overview]
Message-ID: <20150914133022.GB4684@lukather> (raw)
In-Reply-To: <55F6C46D.7090203@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]
Hi,
On Mon, Sep 14, 2015 at 02:58:21PM +0200, Marc Kleine-Budde wrote:
> On 09/14/2015 02:54 PM, Gerhard Bertelsmann wrote:
> > Signed-off-by: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
> > ---
> >
> > .../devicetree/bindings/net/can/sun4i_can.txt | 37 +
> > 1 files changed, 37 insertions(+)
> >
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/sun4i_can.txt b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> > new file mode 100644
> > index 0000000..b572e2b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> > @@ -0,0 +1,37 @@
> > +Allwinner A10/A20 CAN controller Device Tree Bindings
> > +-----------------------------------------------------
> > +
> > +Required properties:
> > +- compatible: "allwinner,sunxican"
> > +- reg: physical base address and size of the Allwinner A10/A20 CAN register map.
> > +- interrupts: interrupt specifier for the sole interrupt.
> > +- clock: phandle and clock specifier.
> > +
> > +Example
> > +-------
> > +
> > +SoC common .dtsi file:
> > +
> > + can0_pins_a: can0 <at> 0 {
>
> That's supposed to be a proper "@":
>
> can0@0
>
> > + allwinner,pins = "PH20","PH21";
> > + allwinner,function = "can";
> > + allwinner,drive = <0>;
> > + allwinner,pull = <0>;
> > + };
> > +
> > + can0: can <at> 01c2bc00 {
>
> can0@01c2bc00
Actually, beside '<at>' vs '@', he was right.
The name of the node in the DT should be:
<device class>@<address>
Which in our case is can@01c2bc00, like he used.
>
> > + compatible = "allwinner,sunxican";
However, the compatible is still not right.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings
Date: Mon, 14 Sep 2015 15:30:22 +0200 [thread overview]
Message-ID: <20150914133022.GB4684@lukather> (raw)
In-Reply-To: <55F6C46D.7090203@pengutronix.de>
Hi,
On Mon, Sep 14, 2015 at 02:58:21PM +0200, Marc Kleine-Budde wrote:
> On 09/14/2015 02:54 PM, Gerhard Bertelsmann wrote:
> > Signed-off-by: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
> > ---
> >
> > .../devicetree/bindings/net/can/sun4i_can.txt | 37 +
> > 1 files changed, 37 insertions(+)
> >
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/sun4i_can.txt b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> > new file mode 100644
> > index 0000000..b572e2b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> > @@ -0,0 +1,37 @@
> > +Allwinner A10/A20 CAN controller Device Tree Bindings
> > +-----------------------------------------------------
> > +
> > +Required properties:
> > +- compatible: "allwinner,sunxican"
> > +- reg: physical base address and size of the Allwinner A10/A20 CAN register map.
> > +- interrupts: interrupt specifier for the sole interrupt.
> > +- clock: phandle and clock specifier.
> > +
> > +Example
> > +-------
> > +
> > +SoC common .dtsi file:
> > +
> > + can0_pins_a: can0 <at> 0 {
>
> That's supposed to be a proper "@":
>
> can0 at 0
>
> > + allwinner,pins = "PH20","PH21";
> > + allwinner,function = "can";
> > + allwinner,drive = <0>;
> > + allwinner,pull = <0>;
> > + };
> > +
> > + can0: can <at> 01c2bc00 {
>
> can0 at 01c2bc00
Actually, beside '<at>' vs '@', he was right.
The name of the node in the DT should be:
<device class>@<address>
Which in our case is can at 01c2bc00, like he used.
>
> > + compatible = "allwinner,sunxican";
However, the compatible is still not right.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150914/2ce4e278/attachment-0001.sig>
next prev parent reply other threads:[~2015-09-14 13:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 12:54 [PATCH v6 0/3] can: Allwinner A10/A20 CAN Controller support - Summary Gerhard Bertelsmann
2015-09-14 12:54 ` Gerhard Bertelsmann
2015-09-14 12:54 ` [PATCH v6 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings Gerhard Bertelsmann
2015-09-14 12:54 ` Gerhard Bertelsmann
2015-09-14 12:58 ` Marc Kleine-Budde
2015-09-14 12:58 ` Marc Kleine-Budde
2015-09-14 13:30 ` Maxime Ripard [this message]
2015-09-14 13:30 ` Maxime Ripard
2015-09-14 12:54 ` [PATCH v6 2/3] can: Allwinner A10/A20 CAN Controller support - Defconfigs Gerhard Bertelsmann
2015-09-14 12:54 ` Gerhard Bertelsmann
2015-09-14 13:04 ` Marc Kleine-Budde
2015-09-14 13:04 ` Marc Kleine-Budde
2015-09-14 12:54 ` [PATCH v6 3/3] can: Allwinner A10/A20 CAN Controller support - Kernel module Gerhard Bertelsmann
2015-09-14 12:54 ` Gerhard Bertelsmann
2015-09-14 13:53 ` Marc Kleine-Budde
2015-09-14 13:53 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914133022.GB4684@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=info@gerhard-bertelsmann.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.