All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>,
	wg@grandegger.com, maxime.ripard@free-electrons.com,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings
Date: Mon, 14 Sep 2015 14:58:21 +0200	[thread overview]
Message-ID: <55F6C46D.7090203@pengutronix.de> (raw)
In-Reply-To: <1442235299-5885-2-git-send-email-info@gerhard-bertelsmann.de>

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

On 09/14/2015 02:54 PM, Gerhard Bertelsmann wrote:
> Signed-off-by: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
> ---
> 
>  .../devicetree/bindings/net/can/sun4i_can.txt      |  37 +
>  1 files changed, 37 insertions(+)
> 
> 
> diff --git a/Documentation/devicetree/bindings/net/can/sun4i_can.txt b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> new file mode 100644
> index 0000000..b572e2b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> @@ -0,0 +1,37 @@
> +Allwinner A10/A20 CAN controller Device Tree Bindings
> +-----------------------------------------------------
> +
> +Required properties:
> +- compatible: "allwinner,sunxican"
> +- reg: physical base address and size of the Allwinner A10/A20 CAN register map.
> +- interrupts: interrupt specifier for the sole interrupt.
> +- clock: phandle and clock specifier.
> +
> +Example
> +-------
> +
> +SoC common .dtsi file:
> +
> +	can0_pins_a: can0 <at> 0 {

That's supposed to be a proper "@":

    can0@0

> +		allwinner,pins = "PH20","PH21";
> +		allwinner,function = "can";
> +		allwinner,drive = <0>;
> +		allwinner,pull = <0>;
> +	};
> +
> +	can0: can <at> 01c2bc00 {

    can0@01c2bc00

> +		compatible = "allwinner,sunxican";
> +		reg = <0x01c2bc00 0x400>;
> +		interrupts = <0 26 4>;
> +		clocks = <&apb1_gates 4>;
> +		status = "disabled";
> +	};
> +
> +Board specific .dts file:
> +
> +	can0: can <at> 01c2bc00 {

can0@01c2bc00

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&can0_pins_a>;
> +		status = "okay";
> +	};
> +
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings
Date: Mon, 14 Sep 2015 14:58:21 +0200	[thread overview]
Message-ID: <55F6C46D.7090203@pengutronix.de> (raw)
In-Reply-To: <1442235299-5885-2-git-send-email-info@gerhard-bertelsmann.de>

On 09/14/2015 02:54 PM, Gerhard Bertelsmann wrote:
> Signed-off-by: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
> ---
> 
>  .../devicetree/bindings/net/can/sun4i_can.txt      |  37 +
>  1 files changed, 37 insertions(+)
> 
> 
> diff --git a/Documentation/devicetree/bindings/net/can/sun4i_can.txt b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> new file mode 100644
> index 0000000..b572e2b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> @@ -0,0 +1,37 @@
> +Allwinner A10/A20 CAN controller Device Tree Bindings
> +-----------------------------------------------------
> +
> +Required properties:
> +- compatible: "allwinner,sunxican"
> +- reg: physical base address and size of the Allwinner A10/A20 CAN register map.
> +- interrupts: interrupt specifier for the sole interrupt.
> +- clock: phandle and clock specifier.
> +
> +Example
> +-------
> +
> +SoC common .dtsi file:
> +
> +	can0_pins_a: can0 <at> 0 {

That's supposed to be a proper "@":

    can0 at 0

> +		allwinner,pins = "PH20","PH21";
> +		allwinner,function = "can";
> +		allwinner,drive = <0>;
> +		allwinner,pull = <0>;
> +	};
> +
> +	can0: can <at> 01c2bc00 {

    can0 at 01c2bc00

> +		compatible = "allwinner,sunxican";
> +		reg = <0x01c2bc00 0x400>;
> +		interrupts = <0 26 4>;
> +		clocks = <&apb1_gates 4>;
> +		status = "disabled";
> +	};
> +
> +Board specific .dts file:
> +
> +	can0: can <at> 01c2bc00 {

can0 at 01c2bc00

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&can0_pins_a>;
> +		status = "okay";
> +	};
> +
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150914/faf4ee40/attachment.sig>

  reply	other threads:[~2015-09-14 12:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 12:54 [PATCH v6 0/3] can: Allwinner A10/A20 CAN Controller support - Summary Gerhard Bertelsmann
2015-09-14 12:54 ` Gerhard Bertelsmann
2015-09-14 12:54 ` [PATCH v6 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings Gerhard Bertelsmann
2015-09-14 12:54   ` Gerhard Bertelsmann
2015-09-14 12:58   ` Marc Kleine-Budde [this message]
2015-09-14 12:58     ` Marc Kleine-Budde
2015-09-14 13:30     ` Maxime Ripard
2015-09-14 13:30       ` Maxime Ripard
2015-09-14 12:54 ` [PATCH v6 2/3] can: Allwinner A10/A20 CAN Controller support - Defconfigs Gerhard Bertelsmann
2015-09-14 12:54   ` Gerhard Bertelsmann
2015-09-14 13:04   ` Marc Kleine-Budde
2015-09-14 13:04     ` Marc Kleine-Budde
2015-09-14 12:54 ` [PATCH v6 3/3] can: Allwinner A10/A20 CAN Controller support - Kernel module Gerhard Bertelsmann
2015-09-14 12:54   ` Gerhard Bertelsmann
2015-09-14 13:53   ` Marc Kleine-Budde
2015-09-14 13:53     ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F6C46D.7090203@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=info@gerhard-bertelsmann.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=netdev@vger.kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.