From: Borislav Petkov <bp@suse.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, Scott Wood <scottwood@freescale.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8)
Date: Wed, 9 Dec 2015 17:03:02 +0100 [thread overview]
Message-ID: <20151209160301.GB10518@pd.tnic> (raw)
In-Reply-To: <20151209111747.GA10518@pd.tnic>
On Wed, Dec 09, 2015 at 12:17:47PM +0100, Borislav Petkov wrote:
> On Wed, Dec 09, 2015 at 09:32:47PM +1100, Michael Ellerman wrote:
> > Presumably caused by the fact that edac_init() is subsys_initcall(), whereas
> > corenet_gen_publish_devices() is arch_initcall().
>
> Thanks for the report!
>
> Hmm, interesting, can you send .config please?
>
> I need to fix this dependency properly - edac_core needs to have
> finished loaded *before* any other EDAC driver loads. Every other order
> is wrong.
Yeah, see Johannes' patch.
Btw, calling a driver's probe function from outside the driver is a new
low in driver design. Tztztz...
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2015-12-09 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 4:49 linux-next: Tree for Dec 8 Stephen Rothwell
2015-12-09 10:32 ` Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8) Michael Ellerman
2015-12-09 11:17 ` Borislav Petkov
2015-12-09 16:03 ` Borislav Petkov [this message]
2015-12-09 16:50 ` Scott Wood
2015-12-09 16:50 ` Scott Wood
2015-12-09 17:38 ` Borislav Petkov
2015-12-09 17:38 ` Borislav Petkov
2015-12-09 17:57 ` Scott Wood
2015-12-09 17:57 ` Scott Wood
2015-12-09 19:20 ` Borislav Petkov
2015-12-09 15:59 ` [PATCH] edac: Don't call mpc85xx_pci_err_probe() from fsl_pci_probe() Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209160301.GB10518@pd.tnic \
--to=bp@suse.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=scottwood@freescale.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.