From: Scott Wood <scottwood@freescale.com>
To: Borislav Petkov <bp@suse.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
<linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
<linux-next@vger.kernel.org>,
Johannes Thumshirn <jthumshirn@suse.de>,
<linux-edac@vger.kernel.org>
Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8)
Date: Wed, 9 Dec 2015 11:57:05 -0600 [thread overview]
Message-ID: <1449683825.15946.207.camel@freescale.com> (raw)
In-Reply-To: <20151209173829.GD10518@pd.tnic>
On Wed, 2015-12-09 at 18:38 +0100, Borislav Petkov wrote:
> On Wed, Dec 09, 2015 at 10:50:09AM -0600, Scott Wood wrote:
> > It's not "a driver's probe function". There is no driver whose .probe()
> > is
> > mpc85xx_pci_err_probe() -- the name is historical.
>
> From looking at it, it behaves a lot like a probe function. Irrespective
> of what it is or it isn't, calling it from outside a driver which can be
> built as a module is a no-no. So I'd appreciate it if someone could test
> Johannes' patch on the relevant hardware.
Thanks for pointing the patch out -- it wasn't posted to linuxppc-dev so I
would have missed it otherwise. I don't need to test it to see that it's
broken -- we can't have two drivers binding to the same device, which is the
reason why the current situation exists.
I recall at the time suggesting that the PCIe controller driver instantiate a
platform device for the EDAC driver to bind to -- it looks like that's what
we'll need to do.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Borislav Petkov <bp@suse.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-edac@vger.kernel.org
Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8)
Date: Wed, 9 Dec 2015 11:57:05 -0600 [thread overview]
Message-ID: <1449683825.15946.207.camel@freescale.com> (raw)
In-Reply-To: <20151209173829.GD10518@pd.tnic>
On Wed, 2015-12-09 at 18:38 +0100, Borislav Petkov wrote:
> On Wed, Dec 09, 2015 at 10:50:09AM -0600, Scott Wood wrote:
> > It's not "a driver's probe function". There is no driver whose .probe()
> > is
> > mpc85xx_pci_err_probe() -- the name is historical.
>
> From looking at it, it behaves a lot like a probe function. Irrespective
> of what it is or it isn't, calling it from outside a driver which can be
> built as a module is a no-no. So I'd appreciate it if someone could test
> Johannes' patch on the relevant hardware.
Thanks for pointing the patch out -- it wasn't posted to linuxppc-dev so I
would have missed it otherwise. I don't need to test it to see that it's
broken -- we can't have two drivers binding to the same device, which is the
reason why the current situation exists.
I recall at the time suggesting that the PCIe controller driver instantiate a
platform device for the EDAC driver to bind to -- it looks like that's what
we'll need to do.
-Scott
next prev parent reply other threads:[~2015-12-09 17:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 4:49 linux-next: Tree for Dec 8 Stephen Rothwell
2015-12-09 10:32 ` Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8) Michael Ellerman
2015-12-09 11:17 ` Borislav Petkov
2015-12-09 16:03 ` Borislav Petkov
2015-12-09 16:50 ` Scott Wood
2015-12-09 16:50 ` Scott Wood
2015-12-09 17:38 ` Borislav Petkov
2015-12-09 17:38 ` Borislav Petkov
2015-12-09 17:57 ` Scott Wood [this message]
2015-12-09 17:57 ` Scott Wood
2015-12-09 19:20 ` Borislav Petkov
2015-12-09 15:59 ` [PATCH] edac: Don't call mpc85xx_pci_err_probe() from fsl_pci_probe() Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449683825.15946.207.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=bp@suse.de \
--cc=jthumshirn@suse.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.