From: Borislav Petkov <bp@suse.de>
To: Scott Wood <scottwood@freescale.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8)
Date: Wed, 9 Dec 2015 18:38:29 +0100 [thread overview]
Message-ID: <20151209173829.GD10518@pd.tnic> (raw)
In-Reply-To: <1449679809.15946.167.camel@freescale.com>
On Wed, Dec 09, 2015 at 10:50:09AM -0600, Scott Wood wrote:
> It's not "a driver's probe function". There is no driver whose .probe() is
> mpc85xx_pci_err_probe() -- the name is historical.
>From looking at it, it behaves a lot like a probe function. Irrespective
of what it is or it isn't, calling it from outside a driver which can be
built as a module is a no-no. So I'd appreciate it if someone could test
Johannes' patch on the relevant hardware.
Thanks.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@suse.de>
To: Scott Wood <scottwood@freescale.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8)
Date: Wed, 9 Dec 2015 18:38:29 +0100 [thread overview]
Message-ID: <20151209173829.GD10518@pd.tnic> (raw)
In-Reply-To: <1449679809.15946.167.camel@freescale.com>
On Wed, Dec 09, 2015 at 10:50:09AM -0600, Scott Wood wrote:
> It's not "a driver's probe function". There is no driver whose .probe() is
> mpc85xx_pci_err_probe() -- the name is historical.
From looking at it, it behaves a lot like a probe function. Irrespective
of what it is or it isn't, calling it from outside a driver which can be
built as a module is a no-no. So I'd appreciate it if someone could test
Johannes' patch on the relevant hardware.
Thanks.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2015-12-09 17:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 4:49 linux-next: Tree for Dec 8 Stephen Rothwell
2015-12-09 10:32 ` Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8) Michael Ellerman
2015-12-09 11:17 ` Borislav Petkov
2015-12-09 16:03 ` Borislav Petkov
2015-12-09 16:50 ` Scott Wood
2015-12-09 16:50 ` Scott Wood
2015-12-09 17:38 ` Borislav Petkov [this message]
2015-12-09 17:38 ` Borislav Petkov
2015-12-09 17:57 ` Scott Wood
2015-12-09 17:57 ` Scott Wood
2015-12-09 19:20 ` Borislav Petkov
2015-12-09 15:59 ` [PATCH] edac: Don't call mpc85xx_pci_err_probe() from fsl_pci_probe() Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209173829.GD10518@pd.tnic \
--to=bp@suse.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=scottwood@freescale.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.