From: Francois Romieu <romieu@fr.zoreil.com>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: netdev@vger.kernel.org,
Realtek linux nic maintainers <nic_swsd@realtek.com>
Subject: Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set
Date: Wed, 9 Dec 2015 23:43:06 +0100 [thread overview]
Message-ID: <20151209224306.GA5082@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1449657826-4461-1-git-send-email-vinschen@redhat.com>
Corinna Vinschen <vinschen@redhat.com> :
[...]
> This patch is supposed to fix this behaviour. If LanWake is 0, the
> function now returns 0. Thus ethtool correctly reports "Wake-on: d".
Can you turn it into a DMI controlled one (something like
drivers/net/ethernet/marvell/skge.c use of dmi_check_system) in order to
avoid a global change of behavior ?
Btw it's probably time to emit some warning during driver probe if wol
bits are not consistent with LanWake.
--
Ueimor
next prev parent reply other threads:[~2015-12-09 22:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 10:08 [PATCH] r8169: Don't claim WoL works if LanWake flag is not set Corinna Vinschen
2015-12-09 10:43 ` [PATCH v2] " Corinna Vinschen
2015-12-09 22:43 ` Francois Romieu [this message]
2015-12-10 9:51 ` Corinna Vinschen
2015-12-10 20:40 ` Francois Romieu
2015-12-10 22:02 ` Corinna Vinschen
2015-12-11 0:06 ` Francois Romieu
2015-12-11 9:42 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209224306.GA5082@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.