All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: netdev@vger.kernel.org,
	Realtek linux nic maintainers <nic_swsd@realtek.com>,
	Chun-Hao Lin <hau@realtek.com>,
	Hayes Wang <hayeswang@realtek.com>
Subject: Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set
Date: Fri, 11 Dec 2015 01:06:27 +0100	[thread overview]
Message-ID: <20151211000627.GA3705@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20151210220255.GB3507@calimero.vinschen.de>

Corinna Vinschen <vinschen@redhat.com> :
[...]
> It's still a bit weird.  On the machines I tested this on, if I disable
> LanWake and shutdown the machine, I can send, e.g., MagicPackets as much
> as I like, the machined don't come up.  Isn't it a bit misleading then
> if ethtool reports that some WoL method is enabled but it doesn't work?

Of course it is. :o(

I'm fine with Config5.LanWake changes if you have empirical evidences that
it helps.

We have terse - outdated ? - documentation and some hint from
http://marc.info/?l=linux-netdev&m=137654699802446. I'm unable to figure
what an/the adequate change could be, especially a low level chance of
regression one.

-- 
Ueimor

  reply	other threads:[~2015-12-11  0:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 10:08 [PATCH] r8169: Don't claim WoL works if LanWake flag is not set Corinna Vinschen
2015-12-09 10:43 ` [PATCH v2] " Corinna Vinschen
2015-12-09 22:43   ` Francois Romieu
2015-12-10  9:51     ` Corinna Vinschen
2015-12-10 20:40       ` Francois Romieu
2015-12-10 22:02         ` Corinna Vinschen
2015-12-11  0:06           ` Francois Romieu [this message]
2015-12-11  9:42             ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151211000627.GA3705@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=hau@realtek.com \
    --cc=hayeswang@realtek.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.