From: Francois Romieu <romieu@fr.zoreil.com>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: netdev@vger.kernel.org,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
Chun-Hao Lin <hau@realtek.com>,
Hayes Wang <hayeswang@realtek.com>
Subject: Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set
Date: Thu, 10 Dec 2015 21:40:54 +0100 [thread overview]
Message-ID: <20151210204054.GA30391@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20151210095135.GA21583@calimero.vinschen.de>
Corinna Vinschen <vinschen@redhat.com> :
[...]
> I could do this (after I could lay my hands on such a board, that is),
> but I'm not convinced that this makes a lot of sense for two reasons.
Ok, let's get this change applied. Whatever happens should not be
hard to manage (I'm thinking about other boards or BIOSes relying on the
current - broken as it can be - behavior to work correctly).
[...]
> 1. There is no global change in behaviour. The usual way to handle the
> WoL flags is to set the affected method flags and additionally set
> LanWake if any of the method flags is set. The fact that the method
> flags don't enable WoL without also settting the LanWake flag is
> documented.
I see no such thing in "7.5 Power Management Function" of the 8168c
registers datasheet. While Config3 states Magic Packet and Link Up
dependencies on Config1.PMEn, it says nothing about Config5.LanWake.
On old 8169 chipsets LanWake is autoloaded from EEPROM.
Plausible for Config5.{B, M, U}WF ? Ok.
Documented ? I am genuinely curious to know where.
--
Ueimor
next prev parent reply other threads:[~2015-12-10 20:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 10:08 [PATCH] r8169: Don't claim WoL works if LanWake flag is not set Corinna Vinschen
2015-12-09 10:43 ` [PATCH v2] " Corinna Vinschen
2015-12-09 22:43 ` Francois Romieu
2015-12-10 9:51 ` Corinna Vinschen
2015-12-10 20:40 ` Francois Romieu [this message]
2015-12-10 22:02 ` Corinna Vinschen
2015-12-11 0:06 ` Francois Romieu
2015-12-11 9:42 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210204054.GA30391@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=hau@realtek.com \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.