* [PATCH] staging: rtl8192u: remove extra lines
@ 2021-03-15 7:27 ` zhaoxiao
0 siblings, 0 replies; 8+ messages in thread
From: zhaoxiao @ 2021-03-15 7:27 UTC (permalink / raw)
To: gregkh, straube.linux, lu, dan.carpenter, serrazimone
Cc: devel, zhaoxiao, linux-kernel
Remove extra lines in many functions in r8192U_wx.c.
Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
---
drivers/staging/rtl8192u/r8192U_wx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 6ead461e3279..e68d37914456 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -879,7 +879,6 @@ static iw_handler r8192_wx_handlers[] = {
static const struct iw_priv_args r8192_private_args[] = {
-
{
SIOCIWFIRSTPRIV + 0x0,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "badcrc"
@@ -890,14 +889,15 @@ static const struct iw_priv_args r8192_private_args[] = {
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "activescan"
},
+
{
SIOCIWFIRSTPRIV + 0x2,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "rawtx"
},
+
{
SIOCIWFIRSTPRIV + 0x3,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "forcereset"
-
}
};
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] staging: rtl8192u: remove extra lines
@ 2021-03-15 7:27 ` zhaoxiao
0 siblings, 0 replies; 8+ messages in thread
From: zhaoxiao @ 2021-03-15 7:27 UTC (permalink / raw)
To: gregkh, straube.linux, lu, dan.carpenter, serrazimone
Cc: devel, linux-kernel, zhaoxiao
Remove extra lines in many functions in r8192U_wx.c.
Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
---
drivers/staging/rtl8192u/r8192U_wx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 6ead461e3279..e68d37914456 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -879,7 +879,6 @@ static iw_handler r8192_wx_handlers[] = {
static const struct iw_priv_args r8192_private_args[] = {
-
{
SIOCIWFIRSTPRIV + 0x0,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "badcrc"
@@ -890,14 +889,15 @@ static const struct iw_priv_args r8192_private_args[] = {
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "activescan"
},
+
{
SIOCIWFIRSTPRIV + 0x2,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "rawtx"
},
+
{
SIOCIWFIRSTPRIV + 0x3,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "forcereset"
-
}
};
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: rtl8192u: remove extra lines
2021-03-15 7:27 ` zhaoxiao
@ 2021-03-15 7:56 ` Greg KH
-1 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-03-15 7:56 UTC (permalink / raw)
To: zhaoxiao; +Cc: devel, linux-kernel, serrazimone, lu, dan.carpenter
On Mon, Mar 15, 2021 at 03:27:59PM +0800, zhaoxiao wrote:
> Remove extra lines in many functions in r8192U_wx.c.
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
You did mor than just remove extra lines :(
Also we need an extra line right before your signed-off-by line, as
checkpatch should have warned you about.
Please fix up and resend.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: rtl8192u: remove extra lines
@ 2021-03-15 7:56 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-03-15 7:56 UTC (permalink / raw)
To: zhaoxiao; +Cc: straube.linux, lu, dan.carpenter, serrazimone, devel,
linux-kernel
On Mon, Mar 15, 2021 at 03:27:59PM +0800, zhaoxiao wrote:
> Remove extra lines in many functions in r8192U_wx.c.
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
You did mor than just remove extra lines :(
Also we need an extra line right before your signed-off-by line, as
checkpatch should have warned you about.
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] staging: rtl8192u: remove extra lines
@ 2021-03-16 9:59 ` zhaoxiao
0 siblings, 0 replies; 8+ messages in thread
From: zhaoxiao @ 2021-03-16 9:59 UTC (permalink / raw)
To: gregkh
Cc: straube.linux, lu, dan.carpenter, serrazimone, devel,
linux-kernel, zhaoxiao
Remove extra lines in the struct r8192_private_args.
Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 6ead461e3279..e9de7dc8f049 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -879,12 +879,10 @@ static iw_handler r8192_wx_handlers[] = {
static const struct iw_priv_args r8192_private_args[] = {
-
{
SIOCIWFIRSTPRIV + 0x0,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "badcrc"
},
-
{
SIOCIWFIRSTPRIV + 0x1,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "activescan"
@@ -897,7 +895,6 @@ static const struct iw_priv_args r8192_private_args[] = {
{
SIOCIWFIRSTPRIV + 0x3,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "forcereset"
-
}
};
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] staging: rtl8192u: remove extra lines
@ 2021-03-16 9:59 ` zhaoxiao
0 siblings, 0 replies; 8+ messages in thread
From: zhaoxiao @ 2021-03-16 9:59 UTC (permalink / raw)
To: gregkh; +Cc: devel, zhaoxiao, linux-kernel, serrazimone, lu, dan.carpenter
Remove extra lines in the struct r8192_private_args.
Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 6ead461e3279..e9de7dc8f049 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -879,12 +879,10 @@ static iw_handler r8192_wx_handlers[] = {
static const struct iw_priv_args r8192_private_args[] = {
-
{
SIOCIWFIRSTPRIV + 0x0,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "badcrc"
},
-
{
SIOCIWFIRSTPRIV + 0x1,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "activescan"
@@ -897,7 +895,6 @@ static const struct iw_priv_args r8192_private_args[] = {
{
SIOCIWFIRSTPRIV + 0x3,
IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "forcereset"
-
}
};
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: rtl8192u: remove extra lines
2021-03-16 9:59 ` zhaoxiao
@ 2021-03-16 11:20 ` Greg KH
-1 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-03-16 11:20 UTC (permalink / raw)
To: zhaoxiao; +Cc: devel, linux-kernel, serrazimone, lu, dan.carpenter
On Tue, Mar 16, 2021 at 05:59:22PM +0800, zhaoxiao wrote:
> Remove extra lines in the struct r8192_private_args.
>
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index 6ead461e3279..e9de7dc8f049 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -879,12 +879,10 @@ static iw_handler r8192_wx_handlers[] = {
>
>
> static const struct iw_priv_args r8192_private_args[] = {
> -
> {
> SIOCIWFIRSTPRIV + 0x0,
> IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "badcrc"
> },
> -
> {
> SIOCIWFIRSTPRIV + 0x1,
> IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "activescan"
> @@ -897,7 +895,6 @@ static const struct iw_priv_args r8192_private_args[] = {
> {
> SIOCIWFIRSTPRIV + 0x3,
> IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "forcereset"
> -
> }
>
> };
> --
> 2.20.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: rtl8192u: remove extra lines
@ 2021-03-16 11:20 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-03-16 11:20 UTC (permalink / raw)
To: zhaoxiao; +Cc: devel, lu, linux-kernel, dan.carpenter, serrazimone
On Tue, Mar 16, 2021 at 05:59:22PM +0800, zhaoxiao wrote:
> Remove extra lines in the struct r8192_private_args.
>
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index 6ead461e3279..e9de7dc8f049 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -879,12 +879,10 @@ static iw_handler r8192_wx_handlers[] = {
>
>
> static const struct iw_priv_args r8192_private_args[] = {
> -
> {
> SIOCIWFIRSTPRIV + 0x0,
> IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "badcrc"
> },
> -
> {
> SIOCIWFIRSTPRIV + 0x1,
> IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "activescan"
> @@ -897,7 +895,6 @@ static const struct iw_priv_args r8192_private_args[] = {
> {
> SIOCIWFIRSTPRIV + 0x3,
> IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "forcereset"
> -
> }
>
> };
> --
> 2.20.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-03-16 11:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 9:59 [PATCH] staging: rtl8192u: remove extra lines zhaoxiao
2021-03-16 9:59 ` zhaoxiao
2021-03-16 11:20 ` Greg KH
2021-03-16 11:20 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-03-15 7:27 zhaoxiao
2021-03-15 7:27 ` zhaoxiao
2021-03-15 7:56 ` Greg KH
2021-03-15 7:56 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.