From: Rob Herring <robh@kernel.org> To: "Álvaro Fernández Rojas" <noltari@gmail.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Florian Fainelli <f.fainelli@gmail.com>, bcm-kernel-feedback-list@broadcom.com, Lee Jones <lee.jones@linaro.org>, Michael Walle <michael@walle.cc>, Jonas Gorski <jonas.gorski@gmail.com>, Necip Fazil Yildiran <fazilyildiran@gmail.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 05/22] dt-bindings: add BCM6328 pincontroller binding documentation Date: Tue, 16 Mar 2021 14:59:05 -0600 [thread overview] Message-ID: <20210316205905.GB3629500@robh.at.kernel.org> (raw) In-Reply-To: <20210315114214.3096-6-noltari@gmail.com> On Mon, Mar 15, 2021 at 12:41:57PM +0100, Álvaro Fernández Rojas wrote: > Add binding documentation for the pincontrol core found in BCM6328 SoCs. > > Co-developed-by: Jonas Gorski <jonas.gorski@gmail.com> > Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > v7: add changes suggested by Rob Herring > v6: add changes suggested by Rob Herring > v5: change Documentation to dt-bindings in commit title > v4: no changes > v3: add new gpio node > v2: remove interrupts > > .../pinctrl/brcm,bcm6328-pinctrl.yaml | 132 ++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml > new file mode 100644 > index 000000000000..e1ecdc578f32 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml > @@ -0,0 +1,132 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/brcm,bcm6328-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM6328 pin controller > + > +maintainers: > + - Álvaro Fernández Rojas <noltari@gmail.com> > + - Jonas Gorski <jonas.gorski@gmail.com> > + > +description: |+ > + The pin controller node should be the child of a syscon node. > + > + Refer to the the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > +properties: > + compatible: > + const: brcm,bcm6328-pinctrl > + > + reg: > + maxItems: 1 > + > +patternProperties: > + '^.*-pins$': '-pins$' is equivalent. > + if: > + type: object > + then: You don't need this if/then. This should be: '-pins$': type: object $ref: pinmux-node.yaml# additionalProperties: false properties: ... > + properties: > + function: > + $ref: "pinmux-node.yaml#/properties/function" Drop this as you need the $ref up a level. > + enum: [ serial_led_data, serial_led_clk, inet_act_led, pcie_clkreq, > + led, ephy0_act_led, ephy1_act_led, ephy2_act_led, > + ephy3_act_led, hsspi_cs1, usb_device_port, usb_host_port ] > + > + pins: > + $ref: "pinmux-node.yaml#/properties/pins" > + enum: [ gpio6, gpio7, gpio11, gpio16, gpio17, gpio18, gpio19, > + gpio20, gpio25, gpio26, gpio27, gpio28, hsspi_cs1, > + usb_port1 ] > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pinctrl@18 { > + compatible = "brcm,bcm6328-pinctrl"; > + reg = <0x18 0x10>; > + > + pinctrl_serial_led: serial_led-pins { > + pinctrl_serial_led_data: serial_led_data-pins { > + function = "serial_led_data"; > + pins = "gpio6"; > + }; > + > + pinctrl_serial_led_clk: serial_led_clk-pins { > + function = "serial_led_clk"; > + pins = "gpio7"; > + }; > + }; > + > + pinctrl_inet_act_led: inet_act_led-pins { > + function = "inet_act_led"; > + pins = "gpio11"; > + }; > + > + pinctrl_pcie_clkreq: pcie_clkreq-pins { > + function = "pcie_clkreq"; > + pins = "gpio16"; > + }; > + > + pinctrl_ephy0_spd_led: ephy0_spd_led-pins { > + function = "led"; > + pins = "gpio17"; > + }; > + > + pinctrl_ephy1_spd_led: ephy1_spd_led-pins { > + function = "led"; > + pins = "gpio18"; > + }; > + > + pinctrl_ephy2_spd_led: ephy2_spd_led-pins { > + function = "led"; > + pins = "gpio19"; > + }; > + > + pinctrl_ephy3_spd_led: ephy3_spd_led-pins { > + function = "led"; > + pins = "gpio20"; > + }; > + > + pinctrl_ephy0_act_led: ephy0_act_led-pins { > + function = "ephy0_act_led"; > + pins = "gpio25"; > + }; > + > + pinctrl_ephy1_act_led: ephy1_act_led-pins { > + function = "ephy1_act_led"; > + pins = "gpio26"; > + }; > + > + pinctrl_ephy2_act_led: ephy2_act_led-pins { > + function = "ephy2_act_led"; > + pins = "gpio27"; > + }; > + > + pinctrl_ephy3_act_led: ephy3_act_led-pins { > + function = "ephy3_act_led"; > + pins = "gpio28"; > + }; > + > + pinctrl_hsspi_cs1: hsspi_cs1-pins { > + function = "hsspi_cs1"; > + pins = "hsspi_cs1"; > + }; > + > + pinctrl_usb_port1_device: usb_port1_device-pins { > + function = "usb_device_port"; > + pins = "usb_port1"; > + }; > + > + pinctrl_usb_port1_host: usb_port1_host-pins { > + function = "usb_host_port"; > + pins = "usb_port1"; > + }; > + }; > -- > 2.20.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: "Álvaro Fernández Rojas" <noltari@gmail.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Florian Fainelli <f.fainelli@gmail.com>, bcm-kernel-feedback-list@broadcom.com, Lee Jones <lee.jones@linaro.org>, Michael Walle <michael@walle.cc>, Jonas Gorski <jonas.gorski@gmail.com>, Necip Fazil Yildiran <fazilyildiran@gmail.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 05/22] dt-bindings: add BCM6328 pincontroller binding documentation Date: Tue, 16 Mar 2021 14:59:05 -0600 [thread overview] Message-ID: <20210316205905.GB3629500@robh.at.kernel.org> (raw) In-Reply-To: <20210315114214.3096-6-noltari@gmail.com> On Mon, Mar 15, 2021 at 12:41:57PM +0100, Álvaro Fernández Rojas wrote: > Add binding documentation for the pincontrol core found in BCM6328 SoCs. > > Co-developed-by: Jonas Gorski <jonas.gorski@gmail.com> > Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > v7: add changes suggested by Rob Herring > v6: add changes suggested by Rob Herring > v5: change Documentation to dt-bindings in commit title > v4: no changes > v3: add new gpio node > v2: remove interrupts > > .../pinctrl/brcm,bcm6328-pinctrl.yaml | 132 ++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml > new file mode 100644 > index 000000000000..e1ecdc578f32 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml > @@ -0,0 +1,132 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/brcm,bcm6328-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM6328 pin controller > + > +maintainers: > + - Álvaro Fernández Rojas <noltari@gmail.com> > + - Jonas Gorski <jonas.gorski@gmail.com> > + > +description: |+ > + The pin controller node should be the child of a syscon node. > + > + Refer to the the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > +properties: > + compatible: > + const: brcm,bcm6328-pinctrl > + > + reg: > + maxItems: 1 > + > +patternProperties: > + '^.*-pins$': '-pins$' is equivalent. > + if: > + type: object > + then: You don't need this if/then. This should be: '-pins$': type: object $ref: pinmux-node.yaml# additionalProperties: false properties: ... > + properties: > + function: > + $ref: "pinmux-node.yaml#/properties/function" Drop this as you need the $ref up a level. > + enum: [ serial_led_data, serial_led_clk, inet_act_led, pcie_clkreq, > + led, ephy0_act_led, ephy1_act_led, ephy2_act_led, > + ephy3_act_led, hsspi_cs1, usb_device_port, usb_host_port ] > + > + pins: > + $ref: "pinmux-node.yaml#/properties/pins" > + enum: [ gpio6, gpio7, gpio11, gpio16, gpio17, gpio18, gpio19, > + gpio20, gpio25, gpio26, gpio27, gpio28, hsspi_cs1, > + usb_port1 ] > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pinctrl@18 { > + compatible = "brcm,bcm6328-pinctrl"; > + reg = <0x18 0x10>; > + > + pinctrl_serial_led: serial_led-pins { > + pinctrl_serial_led_data: serial_led_data-pins { > + function = "serial_led_data"; > + pins = "gpio6"; > + }; > + > + pinctrl_serial_led_clk: serial_led_clk-pins { > + function = "serial_led_clk"; > + pins = "gpio7"; > + }; > + }; > + > + pinctrl_inet_act_led: inet_act_led-pins { > + function = "inet_act_led"; > + pins = "gpio11"; > + }; > + > + pinctrl_pcie_clkreq: pcie_clkreq-pins { > + function = "pcie_clkreq"; > + pins = "gpio16"; > + }; > + > + pinctrl_ephy0_spd_led: ephy0_spd_led-pins { > + function = "led"; > + pins = "gpio17"; > + }; > + > + pinctrl_ephy1_spd_led: ephy1_spd_led-pins { > + function = "led"; > + pins = "gpio18"; > + }; > + > + pinctrl_ephy2_spd_led: ephy2_spd_led-pins { > + function = "led"; > + pins = "gpio19"; > + }; > + > + pinctrl_ephy3_spd_led: ephy3_spd_led-pins { > + function = "led"; > + pins = "gpio20"; > + }; > + > + pinctrl_ephy0_act_led: ephy0_act_led-pins { > + function = "ephy0_act_led"; > + pins = "gpio25"; > + }; > + > + pinctrl_ephy1_act_led: ephy1_act_led-pins { > + function = "ephy1_act_led"; > + pins = "gpio26"; > + }; > + > + pinctrl_ephy2_act_led: ephy2_act_led-pins { > + function = "ephy2_act_led"; > + pins = "gpio27"; > + }; > + > + pinctrl_ephy3_act_led: ephy3_act_led-pins { > + function = "ephy3_act_led"; > + pins = "gpio28"; > + }; > + > + pinctrl_hsspi_cs1: hsspi_cs1-pins { > + function = "hsspi_cs1"; > + pins = "hsspi_cs1"; > + }; > + > + pinctrl_usb_port1_device: usb_port1_device-pins { > + function = "usb_device_port"; > + pins = "usb_port1"; > + }; > + > + pinctrl_usb_port1_host: usb_port1_host-pins { > + function = "usb_host_port"; > + pins = "usb_port1"; > + }; > + }; > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-16 21:00 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-15 11:41 [PATCH v7 00/22] pinctrl: add BCM63XX pincontrol support Álvaro Fernández Rojas 2021-03-15 11:41 ` Álvaro Fernández Rojas 2021-03-15 11:41 ` [PATCH v7 01/22] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP Álvaro Fernández Rojas 2021-03-15 11:41 ` Álvaro Fernández Rojas 2021-03-15 11:41 ` [PATCH v7 02/22] gpio: regmap: set gpio_chip of_node Álvaro Fernández Rojas 2021-03-15 11:41 ` Álvaro Fernández Rojas 2021-03-15 11:41 ` [PATCH v7 03/22] dt-bindings: add BCM63XX GPIO binding documentation Álvaro Fernández Rojas 2021-03-15 11:41 ` Álvaro Fernández Rojas 2021-03-16 20:54 ` Rob Herring 2021-03-16 20:54 ` Rob Herring 2021-03-17 10:46 ` Álvaro Fernández Rojas 2021-03-17 10:46 ` Álvaro Fernández Rojas 2021-03-15 11:41 ` [PATCH v7 04/22] pinctrl: bcm: add bcm63xx base code Álvaro Fernández Rojas 2021-03-15 11:41 ` Álvaro Fernández Rojas 2021-03-15 11:41 ` [PATCH v7 05/22] dt-bindings: add BCM6328 pincontroller binding documentation Álvaro Fernández Rojas 2021-03-15 11:41 ` Álvaro Fernández Rojas 2021-03-16 20:59 ` Rob Herring [this message] 2021-03-16 20:59 ` Rob Herring 2021-03-17 12:54 ` Álvaro Fernández Rojas 2021-03-17 12:54 ` Álvaro Fernández Rojas 2021-03-15 11:41 ` [PATCH v7 06/22] dt-bindings: add BCM6328 GPIO sysctl " Álvaro Fernández Rojas 2021-03-15 11:41 ` Álvaro Fernández Rojas 2021-03-15 11:41 ` [PATCH v7 07/22] pinctrl: add a pincontrol driver for BCM6328 Álvaro Fernández Rojas 2021-03-15 11:41 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 08/22] dt-bindings: add BCM6358 pincontroller binding documentation Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 09/22] dt-bindings: add BCM6358 GPIO sysctl " Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 10/22] pinctrl: add a pincontrol driver for BCM6358 Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 11/22] dt-bindings: add BCM6362 pincontroller binding documentation Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 12/22] dt-bindings: add BCM6362 GPIO sysctl " Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 13/22] pinctrl: add a pincontrol driver for BCM6362 Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 14/22] dt-bindings: add BCM6368 pincontroller binding documentation Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 15/22] dt-bindings: add BCM6368 GPIO sysctl " Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 16/22] pinctrl: add a pincontrol driver for BCM6368 Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 17/22] dt-bindings: add BCM63268 pincontroller binding documentation Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 18/22] dt-bindings: add BCM63268 GPIO sysctl " Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 19/22] pinctrl: add a pincontrol driver for BCM63268 Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 20/22] dt-bindings: add BCM6318 pincontroller binding documentation Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 21/22] dt-bindings: add BCM6318 GPIO sysctl " Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-16 21:20 ` Rob Herring 2021-03-16 21:20 ` Rob Herring 2021-03-17 10:48 ` Álvaro Fernández Rojas 2021-03-17 10:48 ` Álvaro Fernández Rojas 2021-03-15 11:42 ` [PATCH v7 22/22] pinctrl: add a pincontrol driver for BCM6318 Álvaro Fernández Rojas 2021-03-15 11:42 ` Álvaro Fernández Rojas 2021-03-16 10:13 ` [PATCH v7 00/22] pinctrl: add BCM63XX pincontrol support Linus Walleij 2021-03-16 10:13 ` Linus Walleij 2021-03-17 11:20 ` Álvaro Fernández Rojas 2021-03-17 11:20 ` Álvaro Fernández Rojas 2021-03-20 11:38 ` Linus Walleij 2021-03-20 11:38 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210316205905.GB3629500@robh.at.kernel.org \ --to=robh@kernel.org \ --cc=andy.shevchenko@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=bgolaszewski@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=fazilyildiran@gmail.com \ --cc=jonas.gorski@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michael@walle.cc \ --cc=noltari@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.