All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Alex Elder <elder@ieee.org>,
	users@linux.kernel.org, tools@linux.kernel.org
Subject: Re: RFC: Superseded-by: follow-up trailer
Date: Wed, 14 Apr 2021 13:40:06 -0400	[thread overview]
Message-ID: <20210414174006.jiqjanaelhqvpspe@nitro.local> (raw)
In-Reply-To: <20210414172449.GP227011@ziepe.ca>

On Wed, Apr 14, 2021 at 02:24:49PM -0300, Jason Gunthorpe wrote:
> > 1. "b4 am" learns a --newrev flag that populates "Obsoletes:" trailers 
> >    for your own patches it grabs from the list
> > 2. when you're ready to start working on the new version, you run "b4 am
> >    "git am" it to a new branch (similar to what I described above)
> > 3. b4 additionally learns a command to grab new trailers from the list by
> >    matching the Obsoletes: message-ids and auto-amending commits with any new
> >    trailers
> > 
> > This would allow you to start working on a new revision whenever you're ready
> > for it and give b4 a precise match it can rely on when tracking new trailers.
> 
> While I understand the interest in exact matching patches, I'm not
> super keen on adding more headers to every patch - this feels alot
> like the gerrit change-id header that everone hates, just in another
> format.

I know what you mean, but we can also take steps to make sure that it doesn't
leak into final commits:

1. a sendmail-validate hook can move Obsoletes: trailers below the ---
2. regular "b4 am" runs can drop any Obsoletes: trailers they find
3. even if it does leak into the final commits, it's not as bad as Change-Id
   because it's not just an obtuse string, but a link leading to a mailing
   list discussion

I think just setting up a sendmail-validate hook will be sufficient to prevent
any negative problems with this strategy.

-K

  reply	other threads:[~2021-04-14 17:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 20:49 RFC: Superseded-by: follow-up trailer Konstantin Ryabitsev
2021-04-13 20:53 ` Alex Elder
2021-04-13 21:02   ` Jason A. Donenfeld
2021-04-13 21:29     ` Steven Rostedt
2021-04-13 21:40       ` Konstantin Ryabitsev
2021-04-14  0:02         ` Steven Rostedt
2021-04-14  7:30         ` Peter Zijlstra
2021-04-14 11:49           ` Jason Gunthorpe
2021-04-14 13:57             ` James Bottomley
2021-04-14 14:36               ` Jason Gunthorpe
2021-04-14 14:56                 ` Konstantin Ryabitsev
2021-04-14 15:57                   ` Jason Gunthorpe
2021-04-14 17:07                     ` Konstantin Ryabitsev
2021-04-14 17:24                       ` Jason Gunthorpe
2021-04-14 17:40                         ` Konstantin Ryabitsev [this message]
2021-04-14 18:46                         ` Mark Brown
2021-04-14 18:58                           ` Jason Gunthorpe
2021-04-14 15:01                 ` Steven Rostedt
2021-04-14 15:36                   ` Peter Zijlstra
2021-04-14 17:44                     ` Willy Tarreau
2021-04-14 14:44             ` Theodore Ts'o
2021-04-14 18:51               ` Geert Uytterhoeven
2021-04-14 14:35           ` Konstantin Ryabitsev
2021-04-14 15:10             ` Peter Zijlstra
2021-04-14 12:52         ` Alex Elder
2021-04-13 21:04   ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210414174006.jiqjanaelhqvpspe@nitro.local \
    --to=konstantin@linuxfoundation.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=Jason@zx2c4.com \
    --cc=elder@ieee.org \
    --cc=jgg@ziepe.ca \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tools@linux.kernel.org \
    --cc=users@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.