* [PATCH 1/1] pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe()
@ 2021-05-11 8:51 ` Zhen Lei
0 siblings, 0 replies; 6+ messages in thread
From: Zhen Lei @ 2021-05-11 8:51 UTC (permalink / raw)
To: Linus Walleij, Ray Jui, Scott Branden, bcm-kernel-feedback-list,
linux-gpio, linux-arm-kernel
Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index e2bd2dce6bb4154..dc511b9a6b43f1b 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -813,10 +813,8 @@ static int iproc_gpio_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
if (res) {
chip->io_ctrl = devm_ioremap_resource(dev, res);
- if (IS_ERR(chip->io_ctrl)) {
- dev_err(dev, "unable to map I/O memory\n");
+ if (IS_ERR(chip->io_ctrl))
return PTR_ERR(chip->io_ctrl);
- }
if (of_device_is_compatible(dev->of_node,
"brcm,cygnus-ccm-gpio"))
io_ctrl_type = IOCTRL_TYPE_CDRU;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/1] pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe()
@ 2021-05-11 8:51 ` Zhen Lei
0 siblings, 0 replies; 6+ messages in thread
From: Zhen Lei @ 2021-05-11 8:51 UTC (permalink / raw)
To: Linus Walleij, Ray Jui, Scott Branden, bcm-kernel-feedback-list,
linux-gpio, linux-arm-kernel
Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index e2bd2dce6bb4154..dc511b9a6b43f1b 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -813,10 +813,8 @@ static int iproc_gpio_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
if (res) {
chip->io_ctrl = devm_ioremap_resource(dev, res);
- if (IS_ERR(chip->io_ctrl)) {
- dev_err(dev, "unable to map I/O memory\n");
+ if (IS_ERR(chip->io_ctrl))
return PTR_ERR(chip->io_ctrl);
- }
if (of_device_is_compatible(dev->of_node,
"brcm,cygnus-ccm-gpio"))
io_ctrl_type = IOCTRL_TYPE_CDRU;
--
2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe()
2021-05-11 8:51 ` Zhen Lei
@ 2021-05-11 16:27 ` Ray Jui
-1 siblings, 0 replies; 6+ messages in thread
From: Ray Jui @ 2021-05-11 16:27 UTC (permalink / raw)
To: Zhen Lei, Linus Walleij, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, linux-gpio, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]
On 5/11/2021 1:51 AM, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> index e2bd2dce6bb4154..dc511b9a6b43f1b 100644
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -813,10 +813,8 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> if (res) {
> chip->io_ctrl = devm_ioremap_resource(dev, res);
> - if (IS_ERR(chip->io_ctrl)) {
> - dev_err(dev, "unable to map I/O memory\n");
> + if (IS_ERR(chip->io_ctrl))
> return PTR_ERR(chip->io_ctrl);
> - }
> if (of_device_is_compatible(dev->of_node,
> "brcm,cygnus-ccm-gpio"))
> io_ctrl_type = IOCTRL_TYPE_CDRU;
>
Looks good to me. Thanks!
Acked-by: Ray Jui <ray.jui@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4194 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe()
@ 2021-05-11 16:27 ` Ray Jui
0 siblings, 0 replies; 6+ messages in thread
From: Ray Jui @ 2021-05-11 16:27 UTC (permalink / raw)
To: Zhen Lei, Linus Walleij, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, linux-gpio, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1391 bytes --]
On 5/11/2021 1:51 AM, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> index e2bd2dce6bb4154..dc511b9a6b43f1b 100644
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -813,10 +813,8 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> if (res) {
> chip->io_ctrl = devm_ioremap_resource(dev, res);
> - if (IS_ERR(chip->io_ctrl)) {
> - dev_err(dev, "unable to map I/O memory\n");
> + if (IS_ERR(chip->io_ctrl))
> return PTR_ERR(chip->io_ctrl);
> - }
> if (of_device_is_compatible(dev->of_node,
> "brcm,cygnus-ccm-gpio"))
> io_ctrl_type = IOCTRL_TYPE_CDRU;
>
Looks good to me. Thanks!
Acked-by: Ray Jui <ray.jui@broadcom.com>
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4194 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe()
2021-05-11 8:51 ` Zhen Lei
@ 2021-05-19 23:38 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2021-05-19 23:38 UTC (permalink / raw)
To: Zhen Lei
Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel
On Tue, May 11, 2021 at 10:51 AM Zhen Lei <thunder.leizhen@huawei.com> wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe()
@ 2021-05-19 23:38 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2021-05-19 23:38 UTC (permalink / raw)
To: Zhen Lei
Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel
On Tue, May 11, 2021 at 10:51 AM Zhen Lei <thunder.leizhen@huawei.com> wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Patch applied!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-19 23:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 8:51 [PATCH 1/1] pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe() Zhen Lei
2021-05-11 8:51 ` Zhen Lei
2021-05-11 16:27 ` Ray Jui
2021-05-11 16:27 ` Ray Jui
2021-05-19 23:38 ` Linus Walleij
2021-05-19 23:38 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.