From: Ralf Schlatterbeck <rsc@runtux.com> To: Andre Przywara <andre.przywara@arm.com> Cc: Mark Brown <broonie@kernel.org>, Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Mirko Vogt <mirko-dev|linux@nanl.de> Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Date: Mon, 24 May 2021 18:24:33 +0200 [thread overview] Message-ID: <20210524162433.6nebp2k7u66zbkx3@runtux.com> (raw) In-Reply-To: <20210524133301.32c74794@slackpad.fritz.box> On Mon, May 24, 2021 at 01:33:01PM +0100, Andre Przywara wrote: > - Single patch set series don't bother to have a "1/1" after the > "PATCH". > - You are expected to increase the version number when you send a new > version, to show that *this* is better than the previous post and > this version should be merged. Otherwise the maintainer might pick > the wrong version. "git format-patch -v2" and "git send-email" will > automatically take care of this. OK I'll keep that in mind. > Please keep in mind that text after the dashes doesn't make it in it > repo, so this information would be lost there. Also, in general links in > commit messages are somewhat frowned upon, since they tend to 404 > sooner or later. So ideally you can put a condensed version of your > findings into the commit message? Don't worry if it grows long, it is > not uncommon to have a 2 page commit message for a one-liner patch. This was intentional, the commit message is only the upper part. The Links were meant to give a lot of details why the patch fixes something. I think the commit message already explains the condensed findings. I've put this additional explanation text after the '---' to not need an additional Patch 0/1 email ;-) Thanks! Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting www: www.runtux.com Reichergasse 131, A-3411 Weidling email: office@runtux.com
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Schlatterbeck <rsc@runtux.com> To: Andre Przywara <andre.przywara@arm.com> Cc: Mark Brown <broonie@kernel.org>, Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Mirko Vogt <mirko-dev|linux@nanl.de> Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Date: Mon, 24 May 2021 18:24:33 +0200 [thread overview] Message-ID: <20210524162433.6nebp2k7u66zbkx3@runtux.com> (raw) In-Reply-To: <20210524133301.32c74794@slackpad.fritz.box> On Mon, May 24, 2021 at 01:33:01PM +0100, Andre Przywara wrote: > - Single patch set series don't bother to have a "1/1" after the > "PATCH". > - You are expected to increase the version number when you send a new > version, to show that *this* is better than the previous post and > this version should be merged. Otherwise the maintainer might pick > the wrong version. "git format-patch -v2" and "git send-email" will > automatically take care of this. OK I'll keep that in mind. > Please keep in mind that text after the dashes doesn't make it in it > repo, so this information would be lost there. Also, in general links in > commit messages are somewhat frowned upon, since they tend to 404 > sooner or later. So ideally you can put a condensed version of your > findings into the commit message? Don't worry if it grows long, it is > not uncommon to have a 2 page commit message for a one-liner patch. This was intentional, the commit message is only the upper part. The Links were meant to give a lot of details why the patch fixes something. I think the commit message already explains the condensed findings. I've put this additional explanation text after the '---' to not need an additional Patch 0/1 email ;-) Thanks! Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting www: www.runtux.com Reichergasse 131, A-3411 Weidling email: office@runtux.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-24 16:24 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-20 10:06 [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Ralf Schlatterbeck 2021-05-20 10:06 ` Ralf Schlatterbeck 2021-05-21 16:30 ` Andre Przywara 2021-05-21 16:30 ` Andre Przywara 2021-05-21 20:16 ` Ralf Schlatterbeck 2021-05-21 20:16 ` Ralf Schlatterbeck 2021-05-21 20:19 ` Ralf Schlatterbeck 2021-05-21 20:19 ` Ralf Schlatterbeck 2021-05-24 12:33 ` Andre Przywara 2021-05-24 12:33 ` Andre Przywara 2021-05-24 16:24 ` Ralf Schlatterbeck [this message] 2021-05-24 16:24 ` Ralf Schlatterbeck 2021-05-25 14:35 ` Mark Brown 2021-05-25 14:35 ` Mark Brown 2021-05-27 11:39 ` Ralf Schlatterbeck 2021-05-27 11:39 ` Ralf Schlatterbeck 2021-06-05 14:06 ` Mirko Vogt 2021-06-05 14:06 ` Mirko Vogt 2021-06-14 14:47 ` Ralf Schlatterbeck 2021-06-14 14:47 ` Ralf Schlatterbeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210524162433.6nebp2k7u66zbkx3@runtux.com \ --to=rsc@runtux.com \ --cc=andre.przywara@arm.com \ --cc=broonie@kernel.org \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=mirko-dev|linux@nanl.de \ --cc=mripard@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.