Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug

From: Ralf Schlatterbeck <rsc@runtux.com>
To: Mark Brown <broonie@kernel.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	Mirko Vogt <mirko-dev|linux@nanl.de>
Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug
Date: Thu, 27 May 2021 13:39:20 +0200	[thread overview]
Message-ID: <20210527113920.ncpzrpst2d6rij3t@runtux.com> (raw)
In-Reply-To: <YK0LR3077RUsSYti@sirena.org.uk>

On Tue, May 25, 2021 at 03:35:51PM +0100, Mark Brown wrote:
> On Fri, May 21, 2021 at 10:19:13PM +0200, Ralf Schlatterbeck wrote:
> > From: Mirko Vogt <mirko-dev|linux@nanl.de>
> > 
> > The current sun6i SPI implementation initializes the transfer too early,
> > resulting in SCK going high before the transfer. When using an additional
> > (gpio) chipselect with sun6i, the chipselect is asserted at a time when
> > clock is high, making the SPI transfer fail.
> 
> Please don't send new patches in reply to old threads, this makes
> it hard to follow what is going on and creates confusion as to
> what the current version of things is and means things can easily
> get missed if the earlier thread gets discarded - this goes along
> with the thing Andre mentioned about flagging the version of the
> patch in the subject line.

OK, let me know if I should repost in new thread with increased version
number in the subject.

Thanks,
Ralf
-- 
Dr. Ralf Schlatterbeck                  Tel:   +43/2243/26465-16
Open Source Consulting                  www:   www.runtux.com
Reichergasse 131, A-3411 Weidling       email: office@runtux.com