From: trix@redhat.com
To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
davem@davemloft.net, kuba@kernel.org
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Tom Rix <trix@redhat.com>
Subject: [PATCH] ice: change return type of ice_ptp_request_ts() to s8
Date: Thu, 17 Jun 2021 14:54:19 -0700 [thread overview]
Message-ID: <20210617215419.3502075-1-trix@redhat.com> (raw)
From: Tom Rix <trix@redhat.com>
A gcc 10.3.1 compile error
ice_ptp.h:149:1: error: return type defaults to
'int' [-Werror=return-type]
149 | ice_ptp_request_ts(struct ice_ptp_tx *tx, ...
| ^~~~~~~~~~~~~~~~~~
This stub's return needs to match the decl for
CONFIG_PTP_I588_CLOCK, which matches its use in
ice_txrt.c
Change the implicit int return to s8.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/ethernet/intel/ice/ice_ptp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.h b/drivers/net/ethernet/intel/ice/ice_ptp.h
index 41e14f98f0e66..d01507eba0364 100644
--- a/drivers/net/ethernet/intel/ice/ice_ptp.h
+++ b/drivers/net/ethernet/intel/ice/ice_ptp.h
@@ -145,7 +145,7 @@ static inline int ice_get_ptp_clock_index(struct ice_pf *pf)
return -1;
}
-static inline
+static inline s8
ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)
{
return -1;
--
2.26.3
WARNING: multiple messages have this Message-ID (diff)
From: trix@redhat.com <trix@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] ice: change return type of ice_ptp_request_ts() to s8
Date: Thu, 17 Jun 2021 14:54:19 -0700 [thread overview]
Message-ID: <20210617215419.3502075-1-trix@redhat.com> (raw)
From: Tom Rix <trix@redhat.com>
A gcc 10.3.1 compile error
ice_ptp.h:149:1: error: return type defaults to
'int' [-Werror=return-type]
149 | ice_ptp_request_ts(struct ice_ptp_tx *tx, ...
| ^~~~~~~~~~~~~~~~~~
This stub's return needs to match the decl for
CONFIG_PTP_I588_CLOCK, which matches its use in
ice_txrt.c
Change the implicit int return to s8.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/ethernet/intel/ice/ice_ptp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.h b/drivers/net/ethernet/intel/ice/ice_ptp.h
index 41e14f98f0e66..d01507eba0364 100644
--- a/drivers/net/ethernet/intel/ice/ice_ptp.h
+++ b/drivers/net/ethernet/intel/ice/ice_ptp.h
@@ -145,7 +145,7 @@ static inline int ice_get_ptp_clock_index(struct ice_pf *pf)
return -1;
}
-static inline
+static inline s8
ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)
{
return -1;
--
2.26.3
next reply other threads:[~2021-06-17 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 21:54 trix [this message]
2021-06-17 21:54 ` [Intel-wired-lan] [PATCH] ice: change return type of ice_ptp_request_ts() to s8 trix
2021-06-17 23:25 ` Nguyen, Anthony L
2021-06-17 23:25 ` [Intel-wired-lan] " Nguyen, Anthony L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617215419.3502075-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.