From: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
"trix@redhat.com" <trix@redhat.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ice: change return type of ice_ptp_request_ts() to s8
Date: Thu, 17 Jun 2021 23:25:47 +0000 [thread overview]
Message-ID: <c968aedc8f5adf398068293f6f75fcb1a701c597.camel@intel.com> (raw)
In-Reply-To: <20210617215419.3502075-1-trix@redhat.com>
On Thu, 2021-06-17 at 14:54 -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A gcc 10.3.1 compile error
> ice_ptp.h:149:1: error: return type defaults to
> 'int' [-Werror=return-type]
> 149 | ice_ptp_request_ts(struct ice_ptp_tx *tx, ...
> | ^~~~~~~~~~~~~~~~~~
>
> This stub's return needs to match the decl for
> CONFIG_PTP_I588_CLOCK, which matches its use in
> ice_txrt.c
>
> Change the implicit int return to s8.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
Thanks for the patch Tom, but Lorenzo recently had the fix accepted for
this[1].
- Tony
[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-
next.git/commit/?id=4d7f75fe8006a1345e6a52b3e3a4c82633f20564
WARNING: multiple messages have this Message-ID (diff)
From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] ice: change return type of ice_ptp_request_ts() to s8
Date: Thu, 17 Jun 2021 23:25:47 +0000 [thread overview]
Message-ID: <c968aedc8f5adf398068293f6f75fcb1a701c597.camel@intel.com> (raw)
In-Reply-To: <20210617215419.3502075-1-trix@redhat.com>
On Thu, 2021-06-17 at 14:54 -0700, trix at redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A gcc 10.3.1 compile error
> ice_ptp.h:149:1: error: return type defaults to
> 'int' [-Werror=return-type]
> 149 | ice_ptp_request_ts(struct ice_ptp_tx *tx, ...
> | ^~~~~~~~~~~~~~~~~~
>
> This stub's return needs to match the decl for
> CONFIG_PTP_I588_CLOCK, which matches its use in
> ice_txrt.c
>
> Change the implicit int return to s8.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
Thanks for the patch Tom, but Lorenzo recently had the fix accepted for
this[1].
- Tony
[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-
next.git/commit/?id=4d7f75fe8006a1345e6a52b3e3a4c82633f20564
next prev parent reply other threads:[~2021-06-17 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 21:54 [PATCH] ice: change return type of ice_ptp_request_ts() to s8 trix
2021-06-17 21:54 ` [Intel-wired-lan] " trix
2021-06-17 23:25 ` Nguyen, Anthony L [this message]
2021-06-17 23:25 ` Nguyen, Anthony L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c968aedc8f5adf398068293f6f75fcb1a701c597.camel@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.