From: Dave Chinner <david@fromorbit.com>
To: Alex Sierra <alex.sierra@amd.com>
Cc: akpm@linux-foundation.org, Felix.Kuehling@amd.com,
linux-mm@kvack.org, rcampbell@nvidia.com,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
hch@lst.de, jgg@nvidia.com, jglisse@redhat.com
Subject: Re: [PATCH v3 1/8] ext4/xfs: add page refcount helper
Date: Fri, 18 Jun 2021 09:52:26 +1000 [thread overview]
Message-ID: <20210617235226.GI664593@dread.disaster.area> (raw)
In-Reply-To: <20210617151705.15367-2-alex.sierra@amd.com>
On Thu, Jun 17, 2021 at 10:16:58AM -0500, Alex Sierra wrote:
> From: Ralph Campbell <rcampbell@nvidia.com>
>
> There are several places where ZONE_DEVICE struct pages assume a reference
> count == 1 means the page is idle and free. Instead of open coding this,
> add a helper function to hide this detail.
>
> v2:
> [AS]: rename dax_layout_is_idle_page func to dax_page_unused
Did you even compile test this?
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
> ---
> fs/dax.c | 4 ++--
> fs/ext4/inode.c | 5 +----
> fs/xfs/xfs_file.c | 4 +---
> include/linux/dax.h | 10 ++++++++++
> 4 files changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 26d5dcd2d69e..321f4ddc6643 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -358,7 +358,7 @@ static void dax_disassociate_entry(void *entry, struct address_space *mapping,
> for_each_mapped_pfn(entry, pfn) {
> struct page *page = pfn_to_page(pfn);
>
> - WARN_ON_ONCE(trunc && page_ref_count(page) > 1);
> + WARN_ON_ONCE(trunc && !dax_layout_is_idle_page(page));
Because you still use dax_layout_is_idle_page() here, not
dax_page_unused()...
> WARN_ON_ONCE(page->mapping && page->mapping != mapping);
> page->mapping = NULL;
> page->index = 0;
> @@ -372,7 +372,7 @@ static struct page *dax_busy_page(void *entry)
> for_each_mapped_pfn(entry, pfn) {
> struct page *page = pfn_to_page(pfn);
>
> - if (page_ref_count(page) > 1)
> + if (!dax_layout_is_idle_page(page))
Here too.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Alex Sierra <alex.sierra@amd.com>
Cc: rcampbell@nvidia.com, Felix.Kuehling@amd.com,
amd-gfx@lists.freedesktop.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, jglisse@redhat.com,
dri-devel@lists.freedesktop.org, jgg@nvidia.com,
akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
hch@lst.de
Subject: Re: [PATCH v3 1/8] ext4/xfs: add page refcount helper
Date: Fri, 18 Jun 2021 09:52:26 +1000 [thread overview]
Message-ID: <20210617235226.GI664593@dread.disaster.area> (raw)
In-Reply-To: <20210617151705.15367-2-alex.sierra@amd.com>
On Thu, Jun 17, 2021 at 10:16:58AM -0500, Alex Sierra wrote:
> From: Ralph Campbell <rcampbell@nvidia.com>
>
> There are several places where ZONE_DEVICE struct pages assume a reference
> count == 1 means the page is idle and free. Instead of open coding this,
> add a helper function to hide this detail.
>
> v2:
> [AS]: rename dax_layout_is_idle_page func to dax_page_unused
Did you even compile test this?
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
> ---
> fs/dax.c | 4 ++--
> fs/ext4/inode.c | 5 +----
> fs/xfs/xfs_file.c | 4 +---
> include/linux/dax.h | 10 ++++++++++
> 4 files changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 26d5dcd2d69e..321f4ddc6643 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -358,7 +358,7 @@ static void dax_disassociate_entry(void *entry, struct address_space *mapping,
> for_each_mapped_pfn(entry, pfn) {
> struct page *page = pfn_to_page(pfn);
>
> - WARN_ON_ONCE(trunc && page_ref_count(page) > 1);
> + WARN_ON_ONCE(trunc && !dax_layout_is_idle_page(page));
Because you still use dax_layout_is_idle_page() here, not
dax_page_unused()...
> WARN_ON_ONCE(page->mapping && page->mapping != mapping);
> page->mapping = NULL;
> page->index = 0;
> @@ -372,7 +372,7 @@ static struct page *dax_busy_page(void *entry)
> for_each_mapped_pfn(entry, pfn) {
> struct page *page = pfn_to_page(pfn);
>
> - if (page_ref_count(page) > 1)
> + if (!dax_layout_is_idle_page(page))
Here too.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Alex Sierra <alex.sierra@amd.com>
Cc: rcampbell@nvidia.com, Felix.Kuehling@amd.com,
amd-gfx@lists.freedesktop.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, jglisse@redhat.com,
dri-devel@lists.freedesktop.org, jgg@nvidia.com,
akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
hch@lst.de
Subject: Re: [PATCH v3 1/8] ext4/xfs: add page refcount helper
Date: Fri, 18 Jun 2021 09:52:26 +1000 [thread overview]
Message-ID: <20210617235226.GI664593@dread.disaster.area> (raw)
In-Reply-To: <20210617151705.15367-2-alex.sierra@amd.com>
On Thu, Jun 17, 2021 at 10:16:58AM -0500, Alex Sierra wrote:
> From: Ralph Campbell <rcampbell@nvidia.com>
>
> There are several places where ZONE_DEVICE struct pages assume a reference
> count == 1 means the page is idle and free. Instead of open coding this,
> add a helper function to hide this detail.
>
> v2:
> [AS]: rename dax_layout_is_idle_page func to dax_page_unused
Did you even compile test this?
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
> ---
> fs/dax.c | 4 ++--
> fs/ext4/inode.c | 5 +----
> fs/xfs/xfs_file.c | 4 +---
> include/linux/dax.h | 10 ++++++++++
> 4 files changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 26d5dcd2d69e..321f4ddc6643 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -358,7 +358,7 @@ static void dax_disassociate_entry(void *entry, struct address_space *mapping,
> for_each_mapped_pfn(entry, pfn) {
> struct page *page = pfn_to_page(pfn);
>
> - WARN_ON_ONCE(trunc && page_ref_count(page) > 1);
> + WARN_ON_ONCE(trunc && !dax_layout_is_idle_page(page));
Because you still use dax_layout_is_idle_page() here, not
dax_page_unused()...
> WARN_ON_ONCE(page->mapping && page->mapping != mapping);
> page->mapping = NULL;
> page->index = 0;
> @@ -372,7 +372,7 @@ static struct page *dax_busy_page(void *entry)
> for_each_mapped_pfn(entry, pfn) {
> struct page *page = pfn_to_page(pfn);
>
> - if (page_ref_count(page) > 1)
> + if (!dax_layout_is_idle_page(page))
Here too.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2021-06-17 23:52 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 15:16 [PATCH v3 0/8] Support DEVICE_GENERIC memory in migrate_vma_* Alex Sierra
2021-06-17 15:16 ` Alex Sierra
2021-06-17 15:16 ` Alex Sierra
2021-06-17 15:16 ` [PATCH v3 1/8] ext4/xfs: add page refcount helper Alex Sierra
2021-06-17 15:16 ` Alex Sierra
2021-06-17 15:16 ` Alex Sierra
2021-06-17 16:11 ` Darrick J. Wong
2021-06-17 16:11 ` Darrick J. Wong
2021-06-17 16:11 ` Darrick J. Wong
2021-06-17 23:52 ` Dave Chinner [this message]
2021-06-17 23:52 ` Dave Chinner
2021-06-17 23:52 ` Dave Chinner
2021-06-19 16:14 ` Sierra Guiza, Alejandro (Alex)
2021-06-19 16:14 ` Sierra Guiza, Alejandro (Alex)
2021-06-19 16:14 ` Sierra Guiza, Alejandro (Alex)
2021-06-19 18:31 ` Alex Sierra
2021-06-19 18:31 ` Alex Sierra
2021-06-19 18:31 ` Alex Sierra
2021-06-17 15:16 ` [PATCH v3 2/8] mm: remove extra ZONE_DEVICE struct page refcount Alex Sierra
2021-06-17 15:16 ` Alex Sierra
2021-06-17 15:16 ` Alex Sierra
2021-06-17 19:16 ` Ralph Campbell
2021-06-17 19:16 ` Ralph Campbell
2021-06-17 19:16 ` Ralph Campbell
2021-06-28 16:46 ` Felix Kuehling
2021-06-28 16:46 ` Felix Kuehling
2021-06-28 16:46 ` Felix Kuehling
2021-06-30 0:23 ` Ralph Campbell
2021-06-30 0:23 ` Ralph Campbell
2021-06-30 0:23 ` Ralph Campbell
2021-06-17 15:17 ` [PATCH v3 3/8] kernel: resource: lookup_resource as exported symbol Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` [PATCH v3 4/8] drm/amdkfd: add SPM support for SVM Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` [PATCH v3 5/8] drm/amdkfd: generic type as sys mem on migration to ram Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` [PATCH v3 6/8] include/linux/mm.h: helpers to check zone device generic type Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` [PATCH v3 7/8] mm: add generic type support to migrate_vma helpers Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` [PATCH v3 8/8] mm: call pgmap->ops->page_free for DEVICE_GENERIC pages Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:17 ` Alex Sierra
2021-06-17 15:56 ` [PATCH v3 0/8] Support DEVICE_GENERIC memory in migrate_vma_* Sierra Guiza, Alejandro (Alex)
2021-06-17 15:56 ` Sierra Guiza, Alejandro (Alex)
2021-06-17 15:56 ` Sierra Guiza, Alejandro (Alex)
2021-06-20 14:14 ` Theodore Ts'o
2021-06-20 14:14 ` Theodore Ts'o
2021-06-20 14:14 ` Theodore Ts'o
2021-06-23 21:49 ` Felix Kuehling
2021-06-23 21:49 ` Felix Kuehling
2021-06-23 21:49 ` Felix Kuehling
2021-06-24 5:30 ` Christoph Hellwig
2021-06-24 5:30 ` Christoph Hellwig
2021-06-24 15:08 ` Felix Kuehling
2021-06-24 15:08 ` Felix Kuehling
2021-06-24 15:08 ` Felix Kuehling
2021-07-16 15:07 ` Theodore Y. Ts'o
2021-07-16 15:07 ` Theodore Y. Ts'o
2021-07-16 15:07 ` Theodore Y. Ts'o
2021-07-16 22:14 ` Felix Kuehling
2021-07-16 22:14 ` Felix Kuehling
2021-07-16 22:14 ` Felix Kuehling
2021-07-17 19:54 ` Sierra Guiza, Alejandro (Alex)
2021-07-17 19:54 ` Sierra Guiza, Alejandro (Alex)
2021-07-17 19:54 ` Sierra Guiza, Alejandro (Alex)
2021-07-23 22:46 ` Sierra Guiza, Alejandro (Alex)
2021-07-23 22:46 ` Sierra Guiza, Alejandro (Alex)
2021-07-23 22:46 ` Sierra Guiza, Alejandro (Alex)
2021-07-30 19:02 ` Felix Kuehling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617235226.GI664593@dread.disaster.area \
--to=david@fromorbit.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.