* [Intel-gfx] [PATCH] Fixes KW issues for NULL pointer dereference
@ 2022-08-11 11:28 Tapas Rana
2022-08-11 12:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tapas Rana @ 2022-08-11 11:28 UTC (permalink / raw)
To: intel-gfx; +Cc: Tapas Rana
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
index 9a7e50534b84..0bbf44c34cff 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
@@ -435,6 +435,9 @@ i915_ttm_memcpy_work_arm(struct i915_ttm_memcpy_work *work,
static bool i915_ttm_memcpy_allowed(struct ttm_buffer_object *bo,
struct ttm_resource *dst_mem)
{
+ if(!bo)
+ return NULL;
+
if (i915_gem_object_needs_ccs_pages(i915_ttm_to_gem(bo)))
return false;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes KW issues for NULL pointer dereference
2022-08-11 11:28 [Intel-gfx] [PATCH] Fixes KW issues for NULL pointer dereference Tapas Rana
@ 2022-08-11 12:00 ` Patchwork
2022-08-11 12:23 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-08-11 16:40 ` [Intel-gfx] [PATCH] " Andrzej Hajda
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2022-08-11 12:00 UTC (permalink / raw)
To: Tapas Rana; +Cc: intel-gfx
== Series Details ==
Series: Fixes KW issues for NULL pointer dereference
URL : https://patchwork.freedesktop.org/series/107160/
State : warning
== Summary ==
Error: dim checkpatch failed
639d6f6caf82 Fixes KW issues for NULL pointer dereference
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
-:15: ERROR:SPACING: space required before the open parenthesis '('
#15: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:438:
+ if(!bo)
-:20: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 2 errors, 1 warnings, 0 checks, 9 lines checked
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for Fixes KW issues for NULL pointer dereference
2022-08-11 11:28 [Intel-gfx] [PATCH] Fixes KW issues for NULL pointer dereference Tapas Rana
2022-08-11 12:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2022-08-11 12:23 ` Patchwork
2022-08-11 16:40 ` [Intel-gfx] [PATCH] " Andrzej Hajda
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2022-08-11 12:23 UTC (permalink / raw)
To: Tapas Rana; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 19327 bytes --]
== Series Details ==
Series: Fixes KW issues for NULL pointer dereference
URL : https://patchwork.freedesktop.org/series/107160/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11983 -> Patchwork_107160v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_107160v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_107160v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/index.html
Participating hosts (29 -> 38)
------------------------------
Additional (12): bat-dg1-6 bat-dg1-5 bat-dg2-8 bat-adlm-1 bat-dg2-9 bat-adlp-6 bat-adlp-4 fi-cfl-8109u bat-rplp-1 bat-rpls-1 bat-rpls-2 bat-jsl-1
Missing (3): fi-ctg-p8600 fi-hsw-4200u fi-snb-2600
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107160v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_lrc:
- bat-adlp-4: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@i915_selftest@live@gt_lrc.html
Known issues
------------
Here are the changes found in Patchwork_107160v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@nullptr:
- bat-dg1-5: NOTRUN -> [SKIP][2] ([i915#2582]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@fbdev@nullptr.html
* igt@fbdev@read:
- bat-adlp-4: NOTRUN -> [SKIP][3] ([i915#2582]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@fbdev@read.html
* igt@gem_huc_copy@huc-copy:
- fi-cfl-8109u: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/fi-cfl-8109u/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/fi-apl-guc/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-adlp-4: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@verify-random:
- fi-cfl-8109u: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/fi-cfl-8109u/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][8] ([i915#4083])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@gem_mmap@basic.html
- bat-dg1-6: NOTRUN -> [SKIP][9] ([i915#4083])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][10] ([i915#4079]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][11] ([i915#4077]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@gem_tiled_blits@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][12] ([i915#4077]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][13] ([i915#4079]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][14] ([i915#3282])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-6: NOTRUN -> [SKIP][15] ([i915#1155])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html
- bat-adlp-4: NOTRUN -> [SKIP][16] ([i915#1155])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@i915_pm_backlight@basic-brightness.html
- bat-dg1-5: NOTRUN -> [SKIP][17] ([i915#1155])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: NOTRUN -> [DMESG-FAIL][18] ([i915#4494] / [i915#4957])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-dg1-6: NOTRUN -> [INCOMPLETE][19] ([i915#6011])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@i915_suspend@basic-s2idle-without-i915.html
- bat-dg1-5: NOTRUN -> [INCOMPLETE][20] ([i915#6011])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [PASS][21] -> [INCOMPLETE][22] ([i915#5982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][23] ([i915#4212]) +7 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@kms_addfb_basic@basic-x-tiled-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][24] ([i915#4215])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
- bat-dg1-6: NOTRUN -> [SKIP][25] ([i915#4215])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-6: NOTRUN -> [SKIP][26] ([i915#4212]) +7 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_busy@basic:
- bat-dg1-5: NOTRUN -> [SKIP][27] ([i915#1845] / [i915#4303])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@kms_busy@basic.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-pnv-d510: NOTRUN -> [SKIP][28] ([fdo#109271])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/fi-pnv-d510/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-apl-guc: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/fi-apl-guc/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][30] ([fdo#111827]) +7 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@kms_chamelium@dp-crc-fast.html
- bat-dg1-5: NOTRUN -> [SKIP][31] ([fdo#111827]) +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- bat-dg1-6: NOTRUN -> [SKIP][32] ([fdo#111827]) +7 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-cfl-8109u: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +8 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/fi-cfl-8109u/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-dg1-6: NOTRUN -> [SKIP][34] ([i915#4103] / [i915#4213])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- bat-adlp-4: NOTRUN -> [SKIP][35] ([i915#3637]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-adlp-4: NOTRUN -> [SKIP][36] ([i915#4093]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@kms_force_connector_basic@force-load-detect.html
- bat-dg1-5: NOTRUN -> [SKIP][37] ([fdo#109285])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
- bat-dg1-6: NOTRUN -> [SKIP][38] ([fdo#109285])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-4: NOTRUN -> [SKIP][39] ([i915#4342])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@nonblocking-crc:
- bat-dg1-5: NOTRUN -> [SKIP][40] ([i915#4078]) +13 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@kms_pipe_crc_basic@nonblocking-crc.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
- bat-adlp-4: NOTRUN -> [SKIP][41] ([i915#3546]) +9 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html
* igt@kms_psr@primary_page_flip:
- bat-dg1-5: NOTRUN -> [SKIP][42] ([i915#1072] / [i915#4078]) +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-6: NOTRUN -> [SKIP][43] ([i915#1072] / [i915#4078]) +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html
- bat-adlp-4: NOTRUN -> [SKIP][44] ([i915#1072]) +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-5: NOTRUN -> [SKIP][45] ([i915#3555])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@kms_setmode@basic-clone-single-crtc.html
- bat-dg1-6: NOTRUN -> [SKIP][46] ([i915#3555])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@kms_setmode@basic-clone-single-crtc.html
- bat-adlp-4: NOTRUN -> [SKIP][47] ([i915#3555] / [i915#4579])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-adlp-4: NOTRUN -> [SKIP][48] ([fdo#109295] / [i915#3546] / [i915#3708])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@prime_vgem@basic-fence-flip.html
- bat-dg1-5: NOTRUN -> [SKIP][49] ([i915#1845] / [i915#3708])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][50] ([i915#3708]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-6: NOTRUN -> [SKIP][51] ([i915#3708] / [i915#4077]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@prime_vgem@basic-gtt.html
- bat-dg1-5: NOTRUN -> [SKIP][52] ([i915#3708] / [i915#4077]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-userptr:
- fi-cfl-8109u: NOTRUN -> [SKIP][53] ([fdo#109271]) +10 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/fi-cfl-8109u/igt@prime_vgem@basic-userptr.html
- bat-dg1-6: NOTRUN -> [SKIP][54] ([i915#3708] / [i915#4873])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@prime_vgem@basic-userptr.html
- bat-adlp-4: NOTRUN -> [SKIP][55] ([fdo#109295] / [i915#3301] / [i915#3708])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@prime_vgem@basic-userptr.html
- bat-dg1-5: NOTRUN -> [SKIP][56] ([i915#3708] / [i915#4873])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- bat-dg1-6: NOTRUN -> [SKIP][57] ([i915#3708]) +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@prime_vgem@basic-write.html
- bat-adlp-4: NOTRUN -> [SKIP][58] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-adlp-4/igt@prime_vgem@basic-write.html
* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][59] ([i915#4312] / [i915#5257])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-5/igt@runner@aborted.html
- bat-dg1-6: NOTRUN -> [FAIL][60] ([i915#4312] / [i915#5257])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/bat-dg1-6/igt@runner@aborted.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-apl-guc: [INCOMPLETE][61] ([i915#6533]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/fi-apl-guc/igt@core_hotunplug@unbind-rebind.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/fi-apl-guc/igt@core_hotunplug@unbind-rebind.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][63] ([i915#4528]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/fi-pnv-d510/igt@i915_selftest@live@requests.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5087]: https://gitlab.freedesktop.org/drm/intel/issues/5087
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5950]: https://gitlab.freedesktop.org/drm/intel/issues/5950
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6531]: https://gitlab.freedesktop.org/drm/intel/issues/6531
[i915#6533]: https://gitlab.freedesktop.org/drm/intel/issues/6533
Build changes
-------------
* Linux: CI_DRM_11983 -> Patchwork_107160v1
CI-20190529: 20190529
CI_DRM_11983: be61f160096902ab2f402179c81f6de59b016d82 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6621: 62685978a0c00bb4b874935129b9761ae10d5ca1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107160v1: be61f160096902ab2f402179c81f6de59b016d82 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
c397e723100e Fixes KW issues for NULL pointer dereference
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107160v1/index.html
[-- Attachment #2: Type: text/html, Size: 23527 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] Fixes KW issues for NULL pointer dereference
2022-08-11 11:28 [Intel-gfx] [PATCH] Fixes KW issues for NULL pointer dereference Tapas Rana
2022-08-11 12:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-08-11 12:23 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2022-08-11 16:40 ` Andrzej Hajda
2 siblings, 0 replies; 4+ messages in thread
From: Andrzej Hajda @ 2022-08-11 16:40 UTC (permalink / raw)
To: Tapas Rana, intel-gfx
On 11.08.2022 13:28, Tapas Rana wrote:
I guess even for trivial patches rules should be followed - subject
should describe what has changed, commit message should describe why.
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> index 9a7e50534b84..0bbf44c34cff 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> @@ -435,6 +435,9 @@ i915_ttm_memcpy_work_arm(struct i915_ttm_memcpy_work *work,
> static bool i915_ttm_memcpy_allowed(struct ttm_buffer_object *bo,
> struct ttm_resource *dst_mem)
> {
> + if(!bo)
> + return NULL;
I guess it should be "return false"
Regards
Andrzej
> +
> if (i915_gem_object_needs_ccs_pages(i915_ttm_to_gem(bo)))
> return false;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-11 16:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11 11:28 [Intel-gfx] [PATCH] Fixes KW issues for NULL pointer dereference Tapas Rana
2022-08-11 12:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-08-11 12:23 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-08-11 16:40 ` [Intel-gfx] [PATCH] " Andrzej Hajda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.