From: Marco Felsch <m.felsch@pengutronix.de> To: Joy Zou <joy.zou@nxp.com> Cc: ping.bai@nxp.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support Date: Wed, 10 Apr 2024 09:40:26 +0200 [thread overview] Message-ID: <20240410074026.qjpk3sjhtbb6sw7j@pengutronix.de> (raw) In-Reply-To: <20240410070128.1506555-2-joy.zou@nxp.com> On 24-04-10, Joy Zou wrote: > Support rtc PCF2131 on imx93-11x11-evk. > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > --- > Changes in v3: > 1.adjust the indentation. > > Changes in v2: > 1. remove unnecessary status property. > --- > .../boot/dts/freescale/imx93-11x11-evk.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > index 07e85a30a25f..73e0bca36b81 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > @@ -281,6 +281,23 @@ ldo5: LDO5 { > }; > }; > > +&lpi2c3 { > + #address-cells = <1>; > + #size-cells = <0>; > + clock-frequency = <400000>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_lpi2c3>; > + pinctrl-1 = <&pinctrl_lpi2c3>; Are both "default" and "sleep" pinctrl's required? It doesn't make any sense to provde a sleep state which uses the same pinctrl state. Regards, Marco > + status = "okay"; > + > + pcf2131: rtc@53 { > + compatible = "nxp,pcf2131"; > + reg = <0x53>; > + interrupt-parent = <&pcal6524>; > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > + }; > +}; > + > &iomuxc { > pinctrl_eqos: eqosgrp { > fsl,pins = < > @@ -343,6 +360,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA 0x40000b9e > >; > }; > > + pinctrl_lpi2c3: lpi2c3grp { > + fsl,pins = < > + MX93_PAD_GPIO_IO28__LPI2C3_SDA 0x40000b9e > + MX93_PAD_GPIO_IO29__LPI2C3_SCL 0x40000b9e > + >; > + }; > + > pinctrl_pcal6524: pcal6524grp { > fsl,pins = < > MX93_PAD_CCM_CLKO2__GPIO3_IO27 0x31e > -- > 2.37.1 > > >
WARNING: multiple messages have this Message-ID (diff)
From: Marco Felsch <m.felsch@pengutronix.de> To: Joy Zou <joy.zou@nxp.com> Cc: ping.bai@nxp.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support Date: Wed, 10 Apr 2024 09:40:26 +0200 [thread overview] Message-ID: <20240410074026.qjpk3sjhtbb6sw7j@pengutronix.de> (raw) In-Reply-To: <20240410070128.1506555-2-joy.zou@nxp.com> On 24-04-10, Joy Zou wrote: > Support rtc PCF2131 on imx93-11x11-evk. > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > --- > Changes in v3: > 1.adjust the indentation. > > Changes in v2: > 1. remove unnecessary status property. > --- > .../boot/dts/freescale/imx93-11x11-evk.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > index 07e85a30a25f..73e0bca36b81 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > @@ -281,6 +281,23 @@ ldo5: LDO5 { > }; > }; > > +&lpi2c3 { > + #address-cells = <1>; > + #size-cells = <0>; > + clock-frequency = <400000>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_lpi2c3>; > + pinctrl-1 = <&pinctrl_lpi2c3>; Are both "default" and "sleep" pinctrl's required? It doesn't make any sense to provde a sleep state which uses the same pinctrl state. Regards, Marco > + status = "okay"; > + > + pcf2131: rtc@53 { > + compatible = "nxp,pcf2131"; > + reg = <0x53>; > + interrupt-parent = <&pcal6524>; > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > + }; > +}; > + > &iomuxc { > pinctrl_eqos: eqosgrp { > fsl,pins = < > @@ -343,6 +360,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA 0x40000b9e > >; > }; > > + pinctrl_lpi2c3: lpi2c3grp { > + fsl,pins = < > + MX93_PAD_GPIO_IO28__LPI2C3_SDA 0x40000b9e > + MX93_PAD_GPIO_IO29__LPI2C3_SCL 0x40000b9e > + >; > + }; > + > pinctrl_pcal6524: pcal6524grp { > fsl,pins = < > MX93_PAD_CCM_CLKO2__GPIO3_IO27 0x31e > -- > 2.37.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-10 7:40 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-10 7:01 [PATCH v3 0/1] Add rtc PCF2131 support Joy Zou 2024-04-10 7:01 ` Joy Zou 2024-04-10 7:01 ` [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add " Joy Zou 2024-04-10 7:01 ` Joy Zou 2024-04-10 7:40 ` Marco Felsch [this message] 2024-04-10 7:40 ` Marco Felsch 2024-04-11 6:37 ` [EXT] " Joy Zou 2024-04-11 6:37 ` Joy Zou
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240410074026.qjpk3sjhtbb6sw7j@pengutronix.de \ --to=m.felsch@pengutronix.de \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=imx@lists.linux.dev \ --cc=joy.zou@nxp.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=ping.bai@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.