RE: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support

From: Joy Zou <joy.zou@nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Jacky Bai <ping.bai@nxp.com>, Frank Li <frank.li@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support
Date: Thu, 11 Apr 2024 06:37:58 +0000	[thread overview]
Message-ID: <AS4PR04MB9386603E175BED248574AE53E1052@AS4PR04MB9386.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20240410074026.qjpk3sjhtbb6sw7j@pengutronix.de>


> -----Original Message-----
> From: Marco Felsch <m.felsch@pengutronix.de>
> Sent: 2024年4月10日 15:40
> To: Joy Zou <joy.zou@nxp.com>
> Cc: Jacky Bai <ping.bai@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; devicetree@vger.kernel.org;
> imx@lists.linux.dev; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; kernel@pengutronix.de; festevam@gmail.com;
> linux-arm-kernel@lists.infradead.org
> Subject: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc
> PCF2131 support
> On 24-04-10, Joy Zou wrote:
> > Support rtc PCF2131 on imx93-11x11-evk.
> >
> > Signed-off-by: Joy Zou <joy.zou@nxp.com>
> > ---
> > Changes in v3:
> > 1.adjust the indentation.
> >
> > Changes in v2:
> > 1. remove unnecessary status property.
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 24
> +++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index 07e85a30a25f..73e0bca36b81 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -281,6 +281,23 @@ ldo5: LDO5 {
> >       };
> >  };
> >
> > +&lpi2c3 {
> > +     #address-cells = <1>;
> > +     #size-cells = <0>;
> > +     clock-frequency = <400000>;
> > +     pinctrl-names = "default", "sleep";
> > +     pinctrl-0 = <&pinctrl_lpi2c3>;
> > +     pinctrl-1 = <&pinctrl_lpi2c3>;
> 
> Are both "default" and "sleep" pinctrl's required? It doesn't make any sense
> to provde a sleep state which uses the same pinctrl state.
Thanks for your comments!
Currently, We only use default. Yeah, It's confused that a sleep state which uses the same pinctrl state.
So will remove the sleep.
BR
Joy Zou
> 
> Regards,
>   Marco
>