From: gareth.yu@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: gareth.yu@intel.com,
"Tejas Upadhyay" <tejaskumarx.surendrakumar.upadhyay@intel.com>,
"Matt Roper" <matthew.d.roper@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH] drm/i915/display: Fixed the main link lost in MST
Date: Fri, 26 Apr 2024 11:11:41 +0800 [thread overview]
Message-ID: <20240426031141.2506987-1-gareth.yu@intel.com> (raw)
In-Reply-To: <20240422063300.1459712-1-gareth.yu@intel.com>
From: Gareth Yu <gareth.yu@intel.com>
Re-train the main link for the main link lost in MST. The previous
version doesn't cover MST mode.
v5: Move link status check to the location which covers MST mode
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10902
Cc: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Gareth Yu <gareth.yu@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index e05e25cd4a94..8043740b4233 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5891,16 +5891,6 @@ intel_dp_detect(struct drm_connector *connector,
intel_dp_print_rates(intel_dp);
- if (intel_dp->is_mst) {
- /*
- * If we are in MST mode then this connector
- * won't appear connected or have anything
- * with EDID on it
- */
- status = connector_status_disconnected;
- goto out;
- }
-
/*
* Some external monitors do not signal loss of link synchronization
* with an IRQ_HPD, so force a link status check.
@@ -5911,6 +5901,16 @@ intel_dp_detect(struct drm_connector *connector,
return ret;
}
+ if (intel_dp->is_mst) {
+ /*
+ * If we are in MST mode then this connector
+ * won't appear connected or have anything
+ * with EDID on it
+ */
+ status = connector_status_disconnected;
+ goto out;
+ }
+
/*
* Clearing NACK and defer counts to get their exact values
* while reading EDID which are required by Compliance tests
--
2.25.1
next prev parent reply other threads:[~2024-04-26 3:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 6:33 [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-22 7:01 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-04-22 7:09 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-22 7:55 ` [PATCH] " gareth.yu
2024-04-22 8:27 ` Jani Nikula
2024-04-22 9:44 ` [PATCH] drm/i915/display: Fixed HDMI can't show up behind a USB-C dock station gareth.yu
2024-04-22 11:26 ` Jani Nikula
2024-04-22 11:33 ` Jani Nikula
2024-04-22 10:35 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed the main link lost in MST (rev3) Patchwork
2024-04-25 3:34 ` [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-25 11:30 ` Jani Nikula
2024-04-26 7:56 ` Yu, Gareth
2024-04-25 4:14 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed the main link lost in MST (rev4) Patchwork
2024-04-25 14:23 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-26 3:11 ` gareth.yu [this message]
2024-04-26 4:10 ` ✗ Fi.CI.SPARSE: warning for drm/i915/display: Fixed the main link lost in MST (rev5) Patchwork
2024-04-26 4:17 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-30 7:31 ` [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-30 8:11 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed the main link lost in MST (rev6) Patchwork
2024-04-30 8:13 ` ✗ Fi.CI.SPARSE: warning " Patchwork
2024-04-30 10:31 ` ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426031141.2506987-1-gareth.yu@intel.com \
--to=gareth.yu@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=tejaskumarx.surendrakumar.upadhyay@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.