From: Jani Nikula <jani.nikula@linux.intel.com>
To: gareth.yu@intel.com, intel-gfx@lists.freedesktop.org
Cc: Gareth Yu <gareth.yu@intel.com>
Subject: Re: [PATCH] drm/i915/display: Fixed the main link lost in MST
Date: Mon, 22 Apr 2024 11:27:15 +0300 [thread overview]
Message-ID: <87r0exvm3g.fsf@intel.com> (raw)
In-Reply-To: <20240422075514.1529260-1-gareth.yu@intel.com>
On Mon, 22 Apr 2024, gareth.yu@intel.com wrote:
> From: Gareth Yu <gareth.yu@intel.com>
>
> Re-train the main link when the sink asserts a HPD for the main lnk
> lost.
This is a completely inadequate commit message for such a fundamental
change.
Preferrably we'd additionally like a bug filed at fdo gitlab, with debug
logs that show the situation, etc.
> Cc : Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Cc : Matt Roper <matthew.d.roper@intel.com>
> Cc : Ville Syrjälä <ville.syrjala@linux.intel.com>
Superfluous space before ":".
> Signed-off-by: Gareth Yu <gareth.yu@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index e05e25cd4a94..db5d4fa8340b 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5849,8 +5849,13 @@ intel_dp_detect(struct drm_connector *connector,
> /* Can't disconnect eDP */
> if (intel_dp_is_edp(intel_dp))
> status = edp_detect(intel_dp);
> - else if (intel_digital_port_connected(encoder))
> + else if (intel_digital_port_connected(encoder)) {
> status = intel_dp_detect_dpcd(intel_dp);
> + if (status == connector_status_connected && intel_dp->is_mst &&
> + !intel_dp_mst_link_status(intel_dp))
> + if (intel_dp_retrain_link(encoder, ctx))
> + status = connector_status_disconnected;
> + }
If we were to add this, this is definitely not the place. You can't look
at ->is_mst for clues here because it's between mst detect and
configure. We might be unconfiguring mst. This also adds unnecessary
checks for status == connected, when it's all handled below with an
early exist for disconnected, etc. And there's a path for retrain too.
All of this has to fit the existing paths nicely instead of just shoving
it here at random.
BR,
Jani.
> else
> status = connector_status_disconnected;
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-04-22 8:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 6:33 [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-22 7:01 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-04-22 7:09 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-22 7:55 ` [PATCH] " gareth.yu
2024-04-22 8:27 ` Jani Nikula [this message]
2024-04-22 9:44 ` [PATCH] drm/i915/display: Fixed HDMI can't show up behind a USB-C dock station gareth.yu
2024-04-22 11:26 ` Jani Nikula
2024-04-22 11:33 ` Jani Nikula
2024-04-22 10:35 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed the main link lost in MST (rev3) Patchwork
2024-04-25 3:34 ` [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-25 11:30 ` Jani Nikula
2024-04-26 7:56 ` Yu, Gareth
2024-04-25 4:14 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed the main link lost in MST (rev4) Patchwork
2024-04-25 14:23 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-26 3:11 ` [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-26 4:10 ` ✗ Fi.CI.SPARSE: warning for drm/i915/display: Fixed the main link lost in MST (rev5) Patchwork
2024-04-26 4:17 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-30 7:31 ` [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-30 8:11 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed the main link lost in MST (rev6) Patchwork
2024-04-30 8:13 ` ✗ Fi.CI.SPARSE: warning " Patchwork
2024-04-30 10:31 ` ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0exvm3g.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=gareth.yu@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.