From: "Yu, Gareth" <gareth.yu@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/i915/display: Fixed the main link lost in MST
Date: Fri, 26 Apr 2024 07:56:15 +0000 [thread overview]
Message-ID: <PH0PR11MB5128C1B95142AB2AAFBB9AAAE0162@PH0PR11MB5128.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87il05ptlo.fsf@intel.com>
Posted V5 that change the order of the existing flow.
Found Tejas' email address is incorrect. Will correct in V6.
Gareth
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Thursday, April 25, 2024 7:31 PM
> To: Yu, Gareth <gareth.yu@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: Yu, Gareth <gareth.yu@intel.com>
> Subject: Re: [PATCH] drm/i915/display: Fixed the main link lost in MST
>
> On Thu, 25 Apr 2024, gareth.yu@intel.com wrote:
> > From: Gareth Yu <gareth.yu@intel.com>
> >
> > Re-train the main link when the sink asserts a HPD for the main lnk
> > lost.
>
> NAK.
>
> Please read the review comments.
>
> BR,
> Jani.
>
> >
> > v4: detect the main link state by intel_dp_needs_link_retrain
> > instead of intel_dp_mst_link_status because the main link
> > state can't detect correctly sometimes by
> > intel_dp_mst_link_status
> >
> > Cc : Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> > Cc : Matt Roper <matthew.d.roper@intel.com> Cc : Ville Syrjälä
> > <ville.syrjala@linux.intel.com>
> > Signed-off-by: Gareth Yu <gareth.yu@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> > b/drivers/gpu/drm/i915/display/intel_dp.c
> > index e05e25cd4a94..e1b60303b256 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -5849,8 +5849,14 @@ intel_dp_detect(struct drm_connector
> *connector,
> > /* Can't disconnect eDP */
> > if (intel_dp_is_edp(intel_dp))
> > status = edp_detect(intel_dp);
> > - else if (intel_digital_port_connected(encoder))
> > + else if (intel_digital_port_connected(encoder)) {
> > status = intel_dp_detect_dpcd(intel_dp);
> > + if (status == connector_status_connected && intel_dp->is_mst
> &&
> > + intel_dp_needs_link_retrain(intel_dp)) {
> > + if (intel_dp_retrain_link(encoder, ctx))
> > + status = connector_status_disconnected;
> > + }
> > + }
> > else
> > status = connector_status_disconnected;
>
> --
> Jani Nikula, Intel
next prev parent reply other threads:[~2024-04-26 7:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 6:33 [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-22 7:01 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-04-22 7:09 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-22 7:55 ` [PATCH] " gareth.yu
2024-04-22 8:27 ` Jani Nikula
2024-04-22 9:44 ` [PATCH] drm/i915/display: Fixed HDMI can't show up behind a USB-C dock station gareth.yu
2024-04-22 11:26 ` Jani Nikula
2024-04-22 11:33 ` Jani Nikula
2024-04-22 10:35 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed the main link lost in MST (rev3) Patchwork
2024-04-25 3:34 ` [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-25 11:30 ` Jani Nikula
2024-04-26 7:56 ` Yu, Gareth [this message]
2024-04-25 4:14 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed the main link lost in MST (rev4) Patchwork
2024-04-25 14:23 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-26 3:11 ` [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-26 4:10 ` ✗ Fi.CI.SPARSE: warning for drm/i915/display: Fixed the main link lost in MST (rev5) Patchwork
2024-04-26 4:17 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-30 7:31 ` [PATCH] drm/i915/display: Fixed the main link lost in MST gareth.yu
2024-04-30 8:11 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed the main link lost in MST (rev6) Patchwork
2024-04-30 8:13 ` ✗ Fi.CI.SPARSE: warning " Patchwork
2024-04-30 10:31 ` ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5128C1B95142AB2AAFBB9AAAE0162@PH0PR11MB5128.namprd11.prod.outlook.com \
--to=gareth.yu@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.