From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Andreas Ruprecht <andreas.ruprecht@fau.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Valentin Rothberg <valentinrothberg@gmail.com>,
Paul Bolle <pebolle@tiscali.nl>,
Stefan Hengelein <stefan.hengelein@fau.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: crypto: rsa - select on undefined AKCIPHER
Date: Thu, 18 Jun 2015 07:55:05 -0700 [thread overview]
Message-ID: <5582DBC9.6070606@intel.com> (raw)
In-Reply-To: <5582809E.4060002@fau.de>
On 06/18/2015 01:26 AM, Andreas Ruprecht wrote:
> Hi Tadeusz,
>
> your commit cfc2bb32b313 ("crypto: rsa - add a new rsa generic
> implementation") was merged into linux-next today (i.e., next-20150618).
> It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option:
>
> +config CRYPTO_RSA
> + tristate "RSA algorithm"
> + select AKCIPHER
> [...]
>
> The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe
> mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 ("crypto:
> akcipher - add PKE API")?
>
> I detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (https://undertaker.cs.fau.de) as part of an
> automated, daily analysis of the most recent linux-next tree.
> There is also a tool in the Linux tree itself that can detect such
> issues (scripts/checkkconfigsymbols.py).
Hi Andreas,
Yes it should have been CRYPTO_AKCIPHER.
Thanks for reporting this.
--- >8 ---
This patch fixes invalid config selection for AKCIPHER
Reported-by: Andreas Ruprecht <andreas.ruprecht@fau.de>
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
---
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 6c79ef0..b4cfc57 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -102,7 +102,7 @@ config CRYPTO_AKCIPHER
config CRYPTO_RSA
tristate "RSA algorithm"
- select AKCIPHER
+ select CRYPTO_AKCIPHER
select MPILIB
select ASN1
help
next prev parent reply other threads:[~2015-06-18 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 8:26 crypto: rsa - select on undefined AKCIPHER Andreas Ruprecht
2015-06-18 14:55 ` Tadeusz Struk [this message]
2015-06-19 6:30 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5582DBC9.6070606@intel.com \
--to=tadeusz.struk@intel.com \
--cc=andreas.ruprecht@fau.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=stefan.hengelein@fau.de \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.