* crypto: rsa - select on undefined AKCIPHER
@ 2015-06-18 8:26 Andreas Ruprecht
2015-06-18 14:55 ` Tadeusz Struk
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Ruprecht @ 2015-06-18 8:26 UTC (permalink / raw)
To: Tadeusz Struk
Cc: Herbert Xu, Valentin Rothberg, Paul Bolle, Stefan Hengelein,
linux-kernel
Hi Tadeusz,
your commit cfc2bb32b313 ("crypto: rsa - add a new rsa generic
implementation") was merged into linux-next today (i.e., next-20150618).
It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option:
+config CRYPTO_RSA
+ tristate "RSA algorithm"
+ select AKCIPHER
[...]
The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe
mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 ("crypto:
akcipher - add PKE API")?
I detected the issue by running undertaker-checkpatch from the
Undertaker tool suite (https://undertaker.cs.fau.de) as part of an
automated, daily analysis of the most recent linux-next tree.
There is also a tool in the Linux tree itself that can detect such
issues (scripts/checkkconfigsymbols.py).
Regards,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: crypto: rsa - select on undefined AKCIPHER
2015-06-18 8:26 crypto: rsa - select on undefined AKCIPHER Andreas Ruprecht
@ 2015-06-18 14:55 ` Tadeusz Struk
2015-06-19 6:30 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Tadeusz Struk @ 2015-06-18 14:55 UTC (permalink / raw)
To: Andreas Ruprecht
Cc: Herbert Xu, Valentin Rothberg, Paul Bolle, Stefan Hengelein,
linux-kernel
On 06/18/2015 01:26 AM, Andreas Ruprecht wrote:
> Hi Tadeusz,
>
> your commit cfc2bb32b313 ("crypto: rsa - add a new rsa generic
> implementation") was merged into linux-next today (i.e., next-20150618).
> It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option:
>
> +config CRYPTO_RSA
> + tristate "RSA algorithm"
> + select AKCIPHER
> [...]
>
> The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe
> mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 ("crypto:
> akcipher - add PKE API")?
>
> I detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (https://undertaker.cs.fau.de) as part of an
> automated, daily analysis of the most recent linux-next tree.
> There is also a tool in the Linux tree itself that can detect such
> issues (scripts/checkkconfigsymbols.py).
Hi Andreas,
Yes it should have been CRYPTO_AKCIPHER.
Thanks for reporting this.
--- >8 ---
This patch fixes invalid config selection for AKCIPHER
Reported-by: Andreas Ruprecht <andreas.ruprecht@fau.de>
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
---
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 6c79ef0..b4cfc57 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -102,7 +102,7 @@ config CRYPTO_AKCIPHER
config CRYPTO_RSA
tristate "RSA algorithm"
- select AKCIPHER
+ select CRYPTO_AKCIPHER
select MPILIB
select ASN1
help
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: crypto: rsa - select on undefined AKCIPHER
2015-06-18 14:55 ` Tadeusz Struk
@ 2015-06-19 6:30 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2015-06-19 6:30 UTC (permalink / raw)
To: Tadeusz Struk
Cc: Andreas Ruprecht, Valentin Rothberg, Paul Bolle, Stefan Hengelein,
linux-kernel
On Thu, Jun 18, 2015 at 07:55:05AM -0700, Tadeusz Struk wrote:
>
> Yes it should have been CRYPTO_AKCIPHER.
> Thanks for reporting this.
Please resend your patch with a cc to linux-crypto.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-19 6:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-18 8:26 crypto: rsa - select on undefined AKCIPHER Andreas Ruprecht
2015-06-18 14:55 ` Tadeusz Struk
2015-06-19 6:30 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.