From: Paolo Bonzini <pbonzini@redhat.com>
To: asmetanin@virtuozzo.com
Cc: Gleb Natapov <gleb@kernel.org>, "Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling
Date: Fri, 19 Jun 2015 12:32:52 +0200 [thread overview]
Message-ID: <5583EFD4.1000206@redhat.com> (raw)
In-Reply-To: <1434709729.31471.3.camel@virtuozzo.com>
On 19/06/2015 12:28, Andrey Smetanin wrote:
> On Wed, 2015-06-17 at 14:44 +0200, Paolo Bonzini wrote:
>>
>> On 11/06/2015 15:18, Denis V. Lunev wrote:
>>> From: Andrey Smetanin <asmetanin@virtuozzo.com>
>>>
>>> Windows 2012 guests can notify hypervisor about occurred guest crash
>>> (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does
>>> handling of this MSR's by KVM and sending notification to user space that
>>> allows to gather Windows guest crash dump by QEMU/LIBVIRT.
>>>
>>> The idea is to provide functionality equal to pvpanic device without
>>> QEMU guest agent for Windows.
>>>
>>> The idea is borrowed from Linux HyperV bus driver and validated against
>>> Windows 2k12.
>>>
>>> Signed-off-by: Andrey Smetanin <asmetanin@virtuozzo.com>
>>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>>> CC: Gleb Natapov <gleb@kernel.org>
>>> CC: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>> arch/x86/include/uapi/asm/hyperv.h | 10 +++++
>>> arch/x86/kvm/Makefile | 2 +-
>>> arch/x86/kvm/mshv.c | 84 ++++++++++++++++++++++++++++++++++++++
>>> arch/x86/kvm/mshv.h | 32 +++++++++++++++
>>
>> Please use hyperv.[ch] or hyper-v.[ch] and name the functions kvm_hv_*.
>> We can later move more functions from x86.c to the new file, so it's
>> better to keep the names consistent.
>>
> Should we prepare a 1st patch in this series where
> we move all hyper-v related code from x86.c into hyperv.c new file with
> copyright extension ?
If you want to do that, I certainly wouldn't complain.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: asmetanin@virtuozzo.com
Cc: Gleb Natapov <gleb@kernel.org>, "Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling
Date: Fri, 19 Jun 2015 12:32:52 +0200 [thread overview]
Message-ID: <5583EFD4.1000206@redhat.com> (raw)
In-Reply-To: <1434709729.31471.3.camel@virtuozzo.com>
On 19/06/2015 12:28, Andrey Smetanin wrote:
> On Wed, 2015-06-17 at 14:44 +0200, Paolo Bonzini wrote:
>>
>> On 11/06/2015 15:18, Denis V. Lunev wrote:
>>> From: Andrey Smetanin <asmetanin@virtuozzo.com>
>>>
>>> Windows 2012 guests can notify hypervisor about occurred guest crash
>>> (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does
>>> handling of this MSR's by KVM and sending notification to user space that
>>> allows to gather Windows guest crash dump by QEMU/LIBVIRT.
>>>
>>> The idea is to provide functionality equal to pvpanic device without
>>> QEMU guest agent for Windows.
>>>
>>> The idea is borrowed from Linux HyperV bus driver and validated against
>>> Windows 2k12.
>>>
>>> Signed-off-by: Andrey Smetanin <asmetanin@virtuozzo.com>
>>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>>> CC: Gleb Natapov <gleb@kernel.org>
>>> CC: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>> arch/x86/include/uapi/asm/hyperv.h | 10 +++++
>>> arch/x86/kvm/Makefile | 2 +-
>>> arch/x86/kvm/mshv.c | 84 ++++++++++++++++++++++++++++++++++++++
>>> arch/x86/kvm/mshv.h | 32 +++++++++++++++
>>
>> Please use hyperv.[ch] or hyper-v.[ch] and name the functions kvm_hv_*.
>> We can later move more functions from x86.c to the new file, so it's
>> better to keep the names consistent.
>>
> Should we prepare a 1st patch in this series where
> we move all hyper-v related code from x86.c into hyperv.c new file with
> copyright extension ?
If you want to do that, I certainly wouldn't complain.
Paolo
next prev parent reply other threads:[~2015-06-19 10:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 13:18 [Qemu-devel] [PATCH 0/2] HyperV equivalent of pvpanic driver Denis V. Lunev
2015-06-11 13:18 ` Denis V. Lunev
2015-06-11 13:18 ` [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling Denis V. Lunev
2015-06-11 13:18 ` Denis V. Lunev
2015-06-12 22:55 ` [Qemu-devel] " Peter Hornyack
2015-06-12 22:55 ` Peter Hornyack
2015-06-12 23:03 ` [Qemu-devel] " Peter Hornyack
2015-06-12 23:03 ` Peter Hornyack
2015-06-15 10:21 ` [Qemu-devel] " Andrey Smetanin
2015-06-15 10:21 ` Andrey Smetanin
2015-06-17 12:44 ` [Qemu-devel] " Paolo Bonzini
2015-06-17 12:44 ` Paolo Bonzini
2015-06-19 10:28 ` [Qemu-devel] " Andrey Smetanin
2015-06-19 10:28 ` Andrey Smetanin
2015-06-19 10:32 ` Paolo Bonzini [this message]
2015-06-19 10:32 ` Paolo Bonzini
2015-06-11 13:18 ` [Qemu-devel] [PATCH 2/2] qemu/kvm: kvm guest crash event handling Denis V. Lunev
2015-06-11 13:18 ` Denis V. Lunev
2015-06-17 12:47 ` [Qemu-devel] " Paolo Bonzini
2015-06-17 12:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5583EFD4.1000206@redhat.com \
--to=pbonzini@redhat.com \
--cc=asmetanin@virtuozzo.com \
--cc=den@openvz.org \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.