From: "Christian König" <christian.koenig@amd.com>
To: Alexander Kuleshov <kuleshovmail@gmail.com>,
Alex Deucher <alexdeucher@gmail.com>
Cc: "David Airlie" <airlied@linux.ie>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Jammy Zhou" <Jammy.Zhou@amd.com>, yanyang1 <young.yang@amd.com>,
"Marek Olšák" <marek.olsak@amd.com>,
"Maninder Singh" <maninder1.s@samsung.com>,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set
Date: Tue, 14 Jul 2015 10:23:30 +0200 [thread overview]
Message-ID: <55A4C702.9070005@amd.com> (raw)
In-Reply-To: <CANCZXo4LaxQiuMKJJ+c=7Wai+W3hA5aeWsbbJ5B1ewLex-Wynw@mail.gmail.com>
On 14.07.2015 10:18, Alexander Kuleshov wrote:
> Hello Alex,
>
> 2015-07-14 11:11 GMT+06:00 Alex Deucher <alexdeucher@gmail.com>:
>> This patch breaks the build with debugfs enabled.
>>
> I've tried to built with CONFIG_DEBUG_FS={y/n} and it builds
> successfully. Did I miss something?
> Maybe I need to enable/disable anything else CONFIG_*?
Price question is why do you want to conditionally include this header
in the first place?
If the kernel isn't build with CONFIG_DEBUG_FS we shouldn't use the
defines, but otherwise they don't seem to hurt.
Regards,
Christian.
>
> Thank you.
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com>
To: Alexander Kuleshov <kuleshovmail@gmail.com>,
Alex Deucher <alexdeucher@gmail.com>
Cc: "Marek Olšák" <marek.olsak@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Maninder Singh" <maninder1.s@samsung.com>,
yanyang1 <young.yang@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>
Subject: Re: [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set
Date: Tue, 14 Jul 2015 10:23:30 +0200 [thread overview]
Message-ID: <55A4C702.9070005@amd.com> (raw)
In-Reply-To: <CANCZXo4LaxQiuMKJJ+c=7Wai+W3hA5aeWsbbJ5B1ewLex-Wynw@mail.gmail.com>
On 14.07.2015 10:18, Alexander Kuleshov wrote:
> Hello Alex,
>
> 2015-07-14 11:11 GMT+06:00 Alex Deucher <alexdeucher@gmail.com>:
>> This patch breaks the build with debugfs enabled.
>>
> I've tried to built with CONFIG_DEBUG_FS={y/n} and it builds
> successfully. Did I miss something?
> Maybe I need to enable/disable anything else CONFIG_*?
Price question is why do you want to conditionally include this header
in the first place?
If the kernel isn't build with CONFIG_DEBUG_FS we shouldn't use the
defines, but otherwise they don't seem to hurt.
Regards,
Christian.
>
> Thank you.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-14 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 11:03 [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set Alexander Kuleshov
2015-07-14 5:11 ` Alex Deucher
2015-07-14 5:11 ` Alex Deucher
2015-07-14 8:18 ` Alexander Kuleshov
2015-07-14 8:23 ` Christian König [this message]
2015-07-14 8:23 ` Christian König
2015-07-14 14:29 ` Alex Deucher
2015-07-14 14:29 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A4C702.9070005@amd.com \
--to=christian.koenig@amd.com \
--cc=Jammy.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=marek.olsak@amd.com \
--cc=young.yang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.