From: Alex Deucher <alexdeucher@gmail.com>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: "David Airlie" <airlied@linux.ie>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Jammy Zhou" <Jammy.Zhou@amd.com>, yanyang1 <young.yang@amd.com>,
"Marek Olšák" <marek.olsak@amd.com>,
"Maninder Singh" <maninder1.s@samsung.com>,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set
Date: Tue, 14 Jul 2015 01:11:59 -0400 [thread overview]
Message-ID: <CADnq5_PoBWwCqoozNsxf1X5wDx9oq0gJAhy8AS0ymVKnFsv5cA@mail.gmail.com> (raw)
In-Reply-To: <1436785437-3457-1-git-send-email-kuleshovmail@gmail.com>
On Mon, Jul 13, 2015 at 7:03 AM, Alexander Kuleshov
<kuleshovmail@gmail.com> wrote:
> We have no need to include <linux/debugfs.h> if the CONFIG_DEBUG_FS option
> is not set.
>
This patch breaks the build with debugfs enabled.
Alex
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index ba46be3..23dbfa4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -27,7 +27,6 @@
> */
> #include <linux/console.h>
> #include <linux/slab.h>
> -#include <linux/debugfs.h>
> #include <drm/drmP.h>
> #include <drm/drm_crtc_helper.h>
> #include <drm/amdgpu_drm.h>
> @@ -44,2 +43,2 @@
> #include "vi.h"
> #include "bif/bif_4_1_d.h"
>
> +#ifdef CONFIG_DEBUG_FS
> +#include <linux/debugfs.h>
> +#endif
> +
> static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev);
> static void amdgpu_debugfs_regs_cleanup(struct amdgpu_device *adev);
>
> --
> 2.5.0-rc1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: "Marek Olšák" <marek.olsak@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Maninder Singh" <maninder1.s@samsung.com>,
yanyang1 <young.yang@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set
Date: Tue, 14 Jul 2015 01:11:59 -0400 [thread overview]
Message-ID: <CADnq5_PoBWwCqoozNsxf1X5wDx9oq0gJAhy8AS0ymVKnFsv5cA@mail.gmail.com> (raw)
In-Reply-To: <1436785437-3457-1-git-send-email-kuleshovmail@gmail.com>
On Mon, Jul 13, 2015 at 7:03 AM, Alexander Kuleshov
<kuleshovmail@gmail.com> wrote:
> We have no need to include <linux/debugfs.h> if the CONFIG_DEBUG_FS option
> is not set.
>
This patch breaks the build with debugfs enabled.
Alex
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index ba46be3..23dbfa4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -27,7 +27,6 @@
> */
> #include <linux/console.h>
> #include <linux/slab.h>
> -#include <linux/debugfs.h>
> #include <drm/drmP.h>
> #include <drm/drm_crtc_helper.h>
> #include <drm/amdgpu_drm.h>
> @@ -44,2 +43,2 @@
> #include "vi.h"
> #include "bif/bif_4_1_d.h"
>
> +#ifdef CONFIG_DEBUG_FS
> +#include <linux/debugfs.h>
> +#endif
> +
> static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev);
> static void amdgpu_debugfs_regs_cleanup(struct amdgpu_device *adev);
>
> --
> 2.5.0-rc1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-14 5:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 11:03 [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set Alexander Kuleshov
2015-07-14 5:11 ` Alex Deucher [this message]
2015-07-14 5:11 ` Alex Deucher
2015-07-14 8:18 ` Alexander Kuleshov
2015-07-14 8:23 ` Christian König
2015-07-14 8:23 ` Christian König
2015-07-14 14:29 ` Alex Deucher
2015-07-14 14:29 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_PoBWwCqoozNsxf1X5wDx9oq0gJAhy8AS0ymVKnFsv5cA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=Jammy.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=marek.olsak@amd.com \
--cc=young.yang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.