From: Sudeep Holla <sudeep.holla@arm.com> To: "Sajjan, Vikas C" <vikas.cha.sajjan@hpe.com> Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Sudeep Holla <sudeep.holla@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Lakshminarasimha, Sunil Vishwanathpur" <sunil.vl@hpe.com>, Prashanth Prakash <pprakash@codeaurora.org>, Ashwin Chaugule <ashwin.chaugule@linaro.org>, Al Stone <al.stone@linaro.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Mark Rutland <mark.rutland@arm.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v5 4/5] arm64: add support for ACPI Low Power Idle(LPI) Date: Mon, 13 Jun 2016 10:40:20 +0100 [thread overview] Message-ID: <575E7F84.2000106@arm.com> (raw) In-Reply-To: <DF4PR84MB0041D17321244DFB84979A84D9530@DF4PR84MB0041.NAMPRD84.PROD.OUTLOOK.COM> On 13/06/16 05:47, Sajjan, Vikas C wrote: > Hi Sudeep, > [...] > --- a/drivers/firmware/psci.c > +++ b/drivers/firmware/psci.c > @@ -13,6 +13,7 @@ > > #define pr_fmt(fmt) "psci: " fmt > > +#include <linux/acpi.h> > #include <linux/arm-smccc.h> > #include <linux/cpuidle.h> > #include <linux/errno.h> > @@ -310,11 +311,66 @@ static int psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu) > return ret; > } > > +#ifdef CONFIG_ACPI > +#include <acpi/processor.h> > + > +static int __maybe_unused psci_acpi_cpu_init_idle(unsigned int cpu) { > + int i, count; > + u32 *psci_states; > + struct acpi_processor *pr; > + struct acpi_lpi_state *lpi; > + > + pr = per_cpu(processors, cpu); > + if (unlikely(!pr || !pr->flags.has_lpi)) > > Any particular reason for _not_ considering CST flag here. > Or you are planning to add CST support in some other patch set. > Are you referring the old C-state objects ? We don't support them on ARM64. Only LPIs are support. The ARM FFH is not defined for CST, only for LPIs. -- Regards, Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: sudeep.holla@arm.com (Sudeep Holla) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 4/5] arm64: add support for ACPI Low Power Idle(LPI) Date: Mon, 13 Jun 2016 10:40:20 +0100 [thread overview] Message-ID: <575E7F84.2000106@arm.com> (raw) In-Reply-To: <DF4PR84MB0041D17321244DFB84979A84D9530@DF4PR84MB0041.NAMPRD84.PROD.OUTLOOK.COM> On 13/06/16 05:47, Sajjan, Vikas C wrote: > Hi Sudeep, > [...] > --- a/drivers/firmware/psci.c > +++ b/drivers/firmware/psci.c > @@ -13,6 +13,7 @@ > > #define pr_fmt(fmt) "psci: " fmt > > +#include <linux/acpi.h> > #include <linux/arm-smccc.h> > #include <linux/cpuidle.h> > #include <linux/errno.h> > @@ -310,11 +311,66 @@ static int psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu) > return ret; > } > > +#ifdef CONFIG_ACPI > +#include <acpi/processor.h> > + > +static int __maybe_unused psci_acpi_cpu_init_idle(unsigned int cpu) { > + int i, count; > + u32 *psci_states; > + struct acpi_processor *pr; > + struct acpi_lpi_state *lpi; > + > + pr = per_cpu(processors, cpu); > + if (unlikely(!pr || !pr->flags.has_lpi)) > > Any particular reason for _not_ considering CST flag here. > Or you are planning to add CST support in some other patch set. > Are you referring the old C-state objects ? We don't support them on ARM64. Only LPIs are support. The ARM FFH is not defined for CST, only for LPIs. -- Regards, Sudeep
next prev parent reply other threads:[~2016-06-13 9:40 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-11 15:37 [PATCH v5 0/5] ACPI / processor_idle: Add ACPI v6.0 LPI support Sudeep Holla 2016-05-11 15:37 ` [PATCH v5 1/5] ACPI / processor_idle: introduce ACPI_PROCESSOR_CSTATE Sudeep Holla 2016-05-11 15:37 ` Sudeep Holla 2016-05-11 16:23 ` Rafael J. Wysocki 2016-05-11 16:23 ` Rafael J. Wysocki 2016-05-11 16:57 ` Sudeep Holla 2016-05-11 16:57 ` Sudeep Holla [not found] ` <CAJvTdKnJPZ9Nfib=CqBczMP4BERqfqAzeSR-+jjFOGZR51oVmg@mail.gmail.com> 2016-05-11 18:28 ` Len Brown 2016-05-11 18:28 ` Len Brown 2016-05-12 9:10 ` Sudeep Holla 2016-05-12 9:10 ` Sudeep Holla 2016-05-12 13:21 ` [UPDATE][PATCH v5] " Sudeep Holla 2016-05-11 15:37 ` [PATCH v5 2/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states Sudeep Holla 2016-05-17 17:46 ` Prakash, Prashanth 2016-05-18 17:37 ` Sudeep Holla 2016-05-18 19:13 ` Prakash, Prashanth 2016-05-19 13:26 ` Sudeep Holla 2016-06-10 17:38 ` Sudeep Holla 2016-06-13 21:05 ` Rafael J. Wysocki 2016-06-14 14:24 ` Sudeep Holla 2016-05-11 15:37 ` [PATCH v5 3/5] arm64: cpuidle: drop __init section marker to arm_cpuidle_init Sudeep Holla 2016-05-11 15:37 ` Sudeep Holla 2016-05-11 15:37 ` [PATCH v5 4/5] arm64: add support for ACPI Low Power Idle(LPI) Sudeep Holla 2016-05-11 15:37 ` Sudeep Holla 2016-06-10 12:50 ` Lorenzo Pieralisi 2016-06-10 12:50 ` Lorenzo Pieralisi 2016-06-13 16:27 ` Daniel Lezcano 2016-06-13 16:27 ` Daniel Lezcano 2016-06-13 4:47 ` Sajjan, Vikas C 2016-06-13 4:47 ` Sajjan, Vikas C 2016-06-13 9:40 ` Sudeep Holla [this message] 2016-06-13 9:40 ` Sudeep Holla 2016-05-11 15:37 ` [PATCH v5 5/5] ACPI : enable ACPI_PROCESSOR_IDLE on ARM64 Sudeep Holla 2016-05-11 15:37 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=575E7F84.2000106@arm.com \ --to=sudeep.holla@arm.com \ --cc=al.stone@linaro.org \ --cc=ashwin.chaugule@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=pprakash@codeaurora.org \ --cc=rjw@rjwysocki.net \ --cc=sunil.vl@hpe.com \ --cc=vikas.cha.sajjan@hpe.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.