From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: mediatek: mt7622: set PHY address of MT7531 switch to 0x1f
Date: Sat, 16 Mar 2024 10:43:40 +0300 [thread overview]
Message-ID: <62d128f1-11ac-4669-90ff-e9cdd0ec5bd9@arinc9.com> (raw)
In-Reply-To: <94e3d09a-e6a4-4808-bc29-3f494b65e170@gmail.com>
On 15.03.2024 20:26, Florian Fainelli wrote:
> On 3/14/24 05:20, Arınç ÜNAL via B4 Relay wrote:
>> From: Arınç ÜNAL <arinc.unal@arinc9.com>
>>
>> The MT7531 switch listens on PHY address 0x1f on an MDIO bus. I've got two
>> findings that support this. There's no bootstrapping option to change the
>> PHY address of the switch. The Linux driver hardcodes 0x1f as the PHY
>> address of the switch. So the reg property on the device tree is currently
>> ignored by the Linux driver.
>>
>> Therefore, describe the correct PHY address on boards that have this
>> switch.
>
> Can we call it a pseudo PHY to use a similar terminology as what is done through drivers/net/dsa/{bcm_sf2,b53}*?
>
> This is not a real PHY as in it has no actual transceiver/digital signal processing logic, this is a piece of logic that snoops for MDIO transactions at that specific address and lets you access the switch's internal register as if it was a MDIO device.
I can get behind calling the switch a psuedo-PHY in the context of MDIO.
However, as described on "22.2.4.5.5 PHYAD (PHY Address)" of "22.2.4.5
Management frame structure" of the active standard IEEE Std 802.3™‐2022,
the field is called "PHY Address". The patch log doesn't give an identifier
as to what a switch is in the context of MDIO. Only that it listens on a
certain PHY address which the term complies with IEEE Std 802.3™‐2022.
So I don't see an improvement to be made on the patch log. Feel free to
elaborate further.
Arınç
next prev parent reply other threads:[~2024-03-16 7:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 12:20 [PATCH 0/2] Set PHY address of MT7531 switch to 0x1f on MediaTek arm64 boards Arınç ÜNAL via B4 Relay
2024-03-14 12:20 ` Arınç ÜNAL
2024-03-14 12:20 ` Arınç ÜNAL via B4 Relay
2024-03-14 12:20 ` [PATCH 1/2] arm64: dts: mediatek: mt7622: set PHY address of MT7531 switch to 0x1f Arınç ÜNAL via B4 Relay
2024-03-14 12:20 ` Arınç ÜNAL
2024-03-14 12:20 ` Arınç ÜNAL via B4 Relay
2024-03-15 17:26 ` Florian Fainelli
2024-03-15 17:26 ` Florian Fainelli
2024-03-16 7:43 ` Arınç ÜNAL [this message]
2024-03-18 13:02 ` Florian Fainelli
2024-03-18 13:02 ` Florian Fainelli
2024-03-18 15:26 ` Arınç ÜNAL
2024-03-18 15:38 ` Florian Fainelli
2024-03-18 15:38 ` Florian Fainelli
2024-03-18 15:50 ` Arınç ÜNAL
2024-03-14 12:20 ` [PATCH 2/2] arm64: dts: mediatek: mt7986: " Arınç ÜNAL via B4 Relay
2024-03-14 12:20 ` Arınç ÜNAL
2024-03-14 12:20 ` Arınç ÜNAL via B4 Relay
2024-04-27 1:28 ` Daniel Golle
2024-04-27 1:28 ` Daniel Golle
2024-03-15 15:50 ` [PATCH 0/2] Set PHY address of MT7531 switch to 0x1f on MediaTek arm64 boards Rob Herring
2024-03-15 15:50 ` Rob Herring
2024-03-31 9:28 ` arinc.unal
2024-03-31 9:28 ` arinc.unal
2024-04-08 7:22 ` Arınç ÜNAL
2024-04-08 7:22 ` Arınç ÜNAL
2024-04-23 9:16 ` Arınç ÜNAL
2024-04-23 9:16 ` Arınç ÜNAL
2024-04-26 12:15 ` Arınç ÜNAL
2024-04-26 12:15 ` Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62d128f1-11ac-4669-90ff-e9cdd0ec5bd9@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mithat.guner@xeront.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.