From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Lukas Jünger" <lukas.juenger@greensocs.com>, qemu-devel@nongnu.org
Cc: alistair.francis@wdc.com, qemu-riscv@nongnu.org,
bin.meng@windriver.com, mark.burton@greensocs.com,
palmer@dabbelt.com, marcandre.lureau@redhat.com,
pbonzini@redhat.com, luc.michel@greensocs.com
Subject: Re: [PATCH 2/2] QOMify sifive_uart model
Date: Tue, 11 May 2021 14:26:54 +0200 [thread overview]
Message-ID: <8471d630-72c1-aef0-a0cf-9f0417334c08@amsat.org> (raw)
In-Reply-To: <20210504153456.927083-3-lukas.juenger@greensocs.com>
Hi Lukas,
On 5/4/21 5:34 PM, Lukas Jünger wrote:
> Signed-off-by: Lukas Jünger <lukas.juenger@greensocs.com>
> ---
> include/hw/char/sifive_uart.h | 6 +--
> hw/char/sifive_uart.c | 72 ++++++++++++++++++++++++++++++-----
> 2 files changed, 65 insertions(+), 13 deletions(-)
> +static void sifive_uart_realize(DeviceState *dev, Error **errp)
> +{
> + SiFiveUARTState *s = SIFIVE_UART(dev);
> +
> + qemu_chr_fe_set_handlers(&s->chr, uart_can_rx, uart_rx, uart_event,
> + uart_be_change, s, NULL, true);
> +
> +}
> +
> +static void sifive_uart_class_init(ObjectClass *oc, void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(oc);
> +
> + dc->realize = sifive_uart_realize;
> + device_class_set_props(dc, sifive_uart_properties);
> +}
You forgot to add the migration fields (VMState) of the SiFiveUARTState
structure. You might want to convert to the Fifo8 API (like the
SiFiveSPIState does) previous to this patch.
Regards,
Phil.
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Lukas Jünger" <lukas.juenger@greensocs.com>, qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, bin.meng@windriver.com,
mark.burton@greensocs.com, marcandre.lureau@redhat.com,
palmer@dabbelt.com, pbonzini@redhat.com,
alistair.francis@wdc.com, luc.michel@greensocs.com
Subject: Re: [PATCH 2/2] QOMify sifive_uart model
Date: Tue, 11 May 2021 14:26:54 +0200 [thread overview]
Message-ID: <8471d630-72c1-aef0-a0cf-9f0417334c08@amsat.org> (raw)
In-Reply-To: <20210504153456.927083-3-lukas.juenger@greensocs.com>
Hi Lukas,
On 5/4/21 5:34 PM, Lukas Jünger wrote:
> Signed-off-by: Lukas Jünger <lukas.juenger@greensocs.com>
> ---
> include/hw/char/sifive_uart.h | 6 +--
> hw/char/sifive_uart.c | 72 ++++++++++++++++++++++++++++++-----
> 2 files changed, 65 insertions(+), 13 deletions(-)
> +static void sifive_uart_realize(DeviceState *dev, Error **errp)
> +{
> + SiFiveUARTState *s = SIFIVE_UART(dev);
> +
> + qemu_chr_fe_set_handlers(&s->chr, uart_can_rx, uart_rx, uart_event,
> + uart_be_change, s, NULL, true);
> +
> +}
> +
> +static void sifive_uart_class_init(ObjectClass *oc, void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(oc);
> +
> + dc->realize = sifive_uart_realize;
> + device_class_set_props(dc, sifive_uart_properties);
> +}
You forgot to add the migration fields (VMState) of the SiFiveUARTState
structure. You might want to convert to the Fifo8 API (like the
SiFiveSPIState does) previous to this patch.
Regards,
Phil.
next prev parent reply other threads:[~2021-05-11 12:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 15:34 [PATCH 0/2] QOMify Sifive UART model Lukas Jünger
2021-05-04 15:34 ` Lukas Jünger
2021-05-04 15:34 ` [PATCH 1/2] Consistent function names for sifive uart read and write function Lukas Jünger
2021-05-04 15:34 ` Lukas Jünger
2021-05-06 2:12 ` Alistair Francis
2021-05-06 2:12 ` Alistair Francis
2021-05-11 11:38 ` Luc Michel
2021-05-11 11:38 ` Luc Michel
2021-05-11 13:06 ` Bin Meng
2021-05-11 13:06 ` Bin Meng
2021-05-04 15:34 ` [PATCH 2/2] QOMify sifive_uart model Lukas Jünger
2021-05-04 15:34 ` Lukas Jünger
2021-05-11 11:39 ` Luc Michel
2021-05-11 11:39 ` Luc Michel
2021-05-11 12:26 ` Philippe Mathieu-Daudé [this message]
2021-05-11 12:26 ` Philippe Mathieu-Daudé
2021-05-16 11:13 ` Lukas Jünger
2021-05-16 11:13 ` Lukas Jünger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8471d630-72c1-aef0-a0cf-9f0417334c08@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=luc.michel@greensocs.com \
--cc=lukas.juenger@greensocs.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.