From: Bin Meng <bmeng.cn@gmail.com>
To: "Lukas Jünger" <lukas.juenger@greensocs.com>
Cc: "Alistair Francis" <alistair.francis@wdc.com>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
"Bin Meng" <bin.meng@windriver.com>,
mark.burton@greensocs.com,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
luc.michel@greensocs.com
Subject: Re: [PATCH 1/2] Consistent function names for sifive uart read and write function
Date: Tue, 11 May 2021 21:06:06 +0800 [thread overview]
Message-ID: <CAEUhbmWCwyyj1jAnqeadoLCcJcrzP5agr_r7tzR5qBBm052VcQ@mail.gmail.com> (raw)
In-Reply-To: <20210504153456.927083-2-lukas.juenger@greensocs.com>
Hi Lukas,
On Wed, May 5, 2021 at 12:49 AM Lukas Jünger
<lukas.juenger@greensocs.com> wrote:
>
While we are here, could we make other functions sifive_ prefixed?
Also the commit title should include a tag of "hw/char: sifive_uart"
> Signed-off-by: Lukas Jünger <lukas.juenger@greensocs.com>
> ---
> hw/char/sifive_uart.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
Regards,
Bin
WARNING: multiple messages have this Message-ID (diff)
From: Bin Meng <bmeng.cn@gmail.com>
To: "Lukas Jünger" <lukas.juenger@greensocs.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
"Bin Meng" <bin.meng@windriver.com>,
mark.burton@greensocs.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
luc.michel@greensocs.com
Subject: Re: [PATCH 1/2] Consistent function names for sifive uart read and write function
Date: Tue, 11 May 2021 21:06:06 +0800 [thread overview]
Message-ID: <CAEUhbmWCwyyj1jAnqeadoLCcJcrzP5agr_r7tzR5qBBm052VcQ@mail.gmail.com> (raw)
In-Reply-To: <20210504153456.927083-2-lukas.juenger@greensocs.com>
Hi Lukas,
On Wed, May 5, 2021 at 12:49 AM Lukas Jünger
<lukas.juenger@greensocs.com> wrote:
>
While we are here, could we make other functions sifive_ prefixed?
Also the commit title should include a tag of "hw/char: sifive_uart"
> Signed-off-by: Lukas Jünger <lukas.juenger@greensocs.com>
> ---
> hw/char/sifive_uart.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
Regards,
Bin
next prev parent reply other threads:[~2021-05-11 13:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 15:34 [PATCH 0/2] QOMify Sifive UART model Lukas Jünger
2021-05-04 15:34 ` Lukas Jünger
2021-05-04 15:34 ` [PATCH 1/2] Consistent function names for sifive uart read and write function Lukas Jünger
2021-05-04 15:34 ` Lukas Jünger
2021-05-06 2:12 ` Alistair Francis
2021-05-06 2:12 ` Alistair Francis
2021-05-11 11:38 ` Luc Michel
2021-05-11 11:38 ` Luc Michel
2021-05-11 13:06 ` Bin Meng [this message]
2021-05-11 13:06 ` Bin Meng
2021-05-04 15:34 ` [PATCH 2/2] QOMify sifive_uart model Lukas Jünger
2021-05-04 15:34 ` Lukas Jünger
2021-05-11 11:39 ` Luc Michel
2021-05-11 11:39 ` Luc Michel
2021-05-11 12:26 ` Philippe Mathieu-Daudé
2021-05-11 12:26 ` Philippe Mathieu-Daudé
2021-05-16 11:13 ` Lukas Jünger
2021-05-16 11:13 ` Lukas Jünger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEUhbmWCwyyj1jAnqeadoLCcJcrzP5agr_r7tzR5qBBm052VcQ@mail.gmail.com \
--to=bmeng.cn@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=luc.michel@greensocs.com \
--cc=lukas.juenger@greensocs.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.