From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2 2/2] tests: migration-test: Add dirty ring test
Date: Wed, 16 Jun 2021 14:55:55 +0200 [thread overview]
Message-ID: <87pmwm0y04.fsf@secure.mitica> (raw)
In-Reply-To: <20210615175523.439830-3-peterx@redhat.com> (Peter Xu's message of "Tue, 15 Jun 2021 13:55:23 -0400")
Peter Xu <peterx@redhat.com> wrote:
> Add dirty ring test if kernel supports it. Add the dirty ring parameter on
> source should be mostly enough, but let's change the dest too to make them
> match always.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Why we check with 4096 and not whatever the kernel returs?
So ....
> @@ -467,6 +471,8 @@ typedef struct {
> bool use_shmem;
> /* only launch the target process */
> bool only_target;
> + /* Use dirty ring if true; dirty logging otherwise */
> + bool use_dirty_ring;
make this an int
> char *opts_source;
> char *opts_target;
> } MigrateStart;
> @@ -573,11 +579,13 @@ static int test_migrate_start(QTestState **from, QTestState **to,
> shmem_opts = g_strdup("");
> }
>
> - cmd_source = g_strdup_printf("-accel kvm -accel tcg%s%s "
> + cmd_source = g_strdup_printf("-accel kvm%s -accel tcg%s%s "
> "-name source,debug-threads=on "
> "-m %s "
> "-serial file:%s/src_serial "
> "%s %s %s %s",
> + args->use_dirty_ring ?
> + ",dirty-ring-size=4096" : "",
check if it is > 0 here and otherwise pass it
> machine_opts ? " -machine " : "",
> machine_opts ? machine_opts : "",
> memory_size, tmpfs,
> @@ -587,12 +595,14 @@ static int test_migrate_start(QTestState **from, QTestState **to,
> *from = qtest_init(cmd_source);
> +static bool kvm_dirty_ring_supported(void)
> +{
> +#if defined(__linux__)
> + int ret, kvm_fd = open("/dev/kvm", O_RDONLY);
> +
> + if (kvm_fd < 0) {
> + return false;
> + }
> +
> + ret = ioctl(kvm_fd, KVM_CHECK_EXTENSION, KVM_CAP_DIRTY_LOG_RING);
> + close(kvm_fd);
> +
> + /* We test with 4096 slots */
> + if (ret < 4096) {
And we return this value.
> + return false;
> + }
> +
> + return true;
> +#else
> + return false;
> +#endif
> +}
Mental note, don't we have a function inside tests/ that check if
a kvm feauture is there?
Quick check seems to imply no.
On the other hand, KVM_CHECK_EXTENSION is basically only used on
kvm-all.c
Later, Juan.
next prev parent reply other threads:[~2021-06-16 12:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 17:55 [PATCH v2 0/2] tests: migration-test: Fix agressive test skip, add dirty ring test Peter Xu
2021-06-15 17:55 ` [PATCH v2 1/2] tests: migration-test: Still run the rest even if uffd missing Peter Xu
2021-06-16 12:49 ` Juan Quintela
2021-06-15 17:55 ` [PATCH v2 2/2] tests: migration-test: Add dirty ring test Peter Xu
2021-06-16 12:55 ` Juan Quintela [this message]
2021-06-16 13:29 ` Peter Xu
2021-07-28 19:37 ` Richard Henderson
2021-07-28 20:37 ` Peter Xu
2021-07-28 21:11 ` Richard Henderson
2021-07-28 21:39 ` Peter Xu
2021-06-30 17:01 ` [PATCH v2 0/2] tests: migration-test: Fix agressive test skip, add " Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmwm0y04.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.