From: Peter Xu <peterx@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v2 2/2] tests: migration-test: Add dirty ring test
Date: Wed, 28 Jul 2021 17:39:11 -0400 [thread overview]
Message-ID: <YQHOfzpA4JF69Y8V@t490s> (raw)
In-Reply-To: <c0dbbbbe-e1c8-02e0-0455-bb954dd5f79b@linaro.org>
On Wed, Jul 28, 2021 at 11:11:30AM -1000, Richard Henderson wrote:
> On 7/28/21 10:37 AM, Peter Xu wrote:
> > A quick fix attached; would that work for us?
>
> Looks plausible, though perhaps just as easy to list the 5 platforms as just the one:
>
> #if defined(__linux__) && \
> (defined(HOST_X86_64) || \
> defined(HOST_S390X) || \
> ...)
> # define HAVE_KVM
> #endif
That looks good to me, especially for the long term to identify whether kvm is
with us, but for the short-term I hope I can still use the (literally :)
simpler patch as attached so hopefully that'll be more welcomed as rc2+
material..
Note again that the kvm.h inclusion is only for kvm dirty ring test in
migration-test so far, meanwhile that's only supported on x86_64, so we won't
lose anything on the rest 4 archs.
Thanks!
--
Peter Xu
next prev parent reply other threads:[~2021-07-28 21:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 17:55 [PATCH v2 0/2] tests: migration-test: Fix agressive test skip, add dirty ring test Peter Xu
2021-06-15 17:55 ` [PATCH v2 1/2] tests: migration-test: Still run the rest even if uffd missing Peter Xu
2021-06-16 12:49 ` Juan Quintela
2021-06-15 17:55 ` [PATCH v2 2/2] tests: migration-test: Add dirty ring test Peter Xu
2021-06-16 12:55 ` Juan Quintela
2021-06-16 13:29 ` Peter Xu
2021-07-28 19:37 ` Richard Henderson
2021-07-28 20:37 ` Peter Xu
2021-07-28 21:11 ` Richard Henderson
2021-07-28 21:39 ` Peter Xu [this message]
2021-06-30 17:01 ` [PATCH v2 0/2] tests: migration-test: Fix agressive test skip, add " Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQHOfzpA4JF69Y8V@t490s \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.