From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH v2 0/2] tests: migration-test: Fix agressive test skip, add dirty ring test
Date: Wed, 30 Jun 2021 18:01:32 +0100 [thread overview]
Message-ID: <YNyjbEwsopQKeoF5@work-vm> (raw)
In-Reply-To: <20210615175523.439830-1-peterx@redhat.com>
* Peter Xu (peterx@redhat.com) wrote:
> Based-on: <20210609014355.217110-1-peterx@redhat.com>
>
> v2:
> - patch 2: detect dirty ring only for __linux__ [Dave]
> - Add r-b for Dave on both patches
Queued
>
> Patch 1 is a fix for migration test not really running on new kernels. The
> problem is uffd check now will constantly fail after upstream commit
> 37cd0575b8510159 - that means any host kernel newer than 5.11.
>
> Patch 1 makes it slightly better by only skipping the two postcopy tests that
> needs uffd on these kernels. When we want to run the full test, we can do:
>
> $ sudo QTEST_QEMU_BINARY=./qemu-system-x86_64 ./tests/qtest/migration-test
>
> Then the uffd check will pass, and postcopy tests will be run.
>
> Patch 2 of this series adds the dirty ring test that just got merged into qemu.
> It needs the other patch "[PATCH] KVM: Fix dirty ring mmap incorrect size due
> to renaming accident", and that's majorly why we need the "Based-on" tag.
>
> Not sure what's the easiest way for the series as it'll depend on the other kvm
> patch. Perhaps if I can try to get ack from Dave so Paolo could queue it too
> along with the kvm fix (for either the whole series or patch 2 only)? I'll
> leave that to maintainers to decide..
>
> Please review, thanks.
>
> Peter Xu (2):
> tests: migration-test: Still run the rest even if uffd missing
> tests: migration-test: Add dirty ring test
>
> tests/qtest/migration-test.c | 69 +++++++++++++++++++++++++++++++-----
> 1 file changed, 60 insertions(+), 9 deletions(-)
>
> --
> 2.31.1
>
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2021-06-30 17:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 17:55 [PATCH v2 0/2] tests: migration-test: Fix agressive test skip, add dirty ring test Peter Xu
2021-06-15 17:55 ` [PATCH v2 1/2] tests: migration-test: Still run the rest even if uffd missing Peter Xu
2021-06-16 12:49 ` Juan Quintela
2021-06-15 17:55 ` [PATCH v2 2/2] tests: migration-test: Add dirty ring test Peter Xu
2021-06-16 12:55 ` Juan Quintela
2021-06-16 13:29 ` Peter Xu
2021-07-28 19:37 ` Richard Henderson
2021-07-28 20:37 ` Peter Xu
2021-07-28 21:11 ` Richard Henderson
2021-07-28 21:39 ` Peter Xu
2021-06-30 17:01 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNyjbEwsopQKeoF5@work-vm \
--to=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.