* [5.14 regression] "ALSA: core: Add continuous and vmalloc mmap ops" breaks Intel SST audio
@ 2021-07-30 20:04 Hans de Goede
2021-07-31 8:10 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2021-07-30 20:04 UTC (permalink / raw)
To: Takashi Iwai, Pierre-Louis Bossart, Mark Brown
Cc: alsa-devel@alsa-project.org
Hi All;,
As discussed in the "5.14 regression, Intel SST (BYT) audio no longer works" thread,
audio on X86 devices using the Intel SST driver no longer works with 5.14.
After poking at this for a while I've found the culprit:
30b7ba6972d5 ("ALSA: core: Add continuous and vmalloc mmap ops")
If I revert that single commit then everything works fine again with 5.14.
This is with a Fedora 34 userspace using pipewire as audiodaemon
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [5.14 regression] "ALSA: core: Add continuous and vmalloc mmap ops" breaks Intel SST audio
2021-07-30 20:04 [5.14 regression] "ALSA: core: Add continuous and vmalloc mmap ops" breaks Intel SST audio Hans de Goede
@ 2021-07-31 8:10 ` Takashi Iwai
2021-08-01 10:27 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2021-07-31 8:10 UTC (permalink / raw)
To: Hans de Goede
Cc: alsa-devel@alsa-project.org, Mark Brown, Pierre-Louis Bossart
On Fri, 30 Jul 2021 22:04:00 +0200,
Hans de Goede wrote:
>
> Hi All;,
>
> As discussed in the "5.14 regression, Intel SST (BYT) audio no longer works" thread,
> audio on X86 devices using the Intel SST driver no longer works with 5.14.
>
> After poking at this for a while I've found the culprit:
> 30b7ba6972d5 ("ALSA: core: Add continuous and vmalloc mmap ops")
>
> If I revert that single commit then everything works fine again with 5.14.
Does the patch below fix the problem?
thanks,
Takashi
---
--- a/sound/core/memalloc.c
+++ b/sound/core/memalloc.c
@@ -215,7 +215,7 @@ static int snd_dma_continuous_mmap(struct snd_dma_buffer *dmab,
struct vm_area_struct *area)
{
return remap_pfn_range(area, area->vm_start,
- dmab->addr >> PAGE_SHIFT,
+ page_to_pfn(virt_to_page(dmab->area)),
area->vm_end - area->vm_start,
area->vm_page_prot);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [5.14 regression] "ALSA: core: Add continuous and vmalloc mmap ops" breaks Intel SST audio
2021-07-31 8:10 ` Takashi Iwai
@ 2021-08-01 10:27 ` Hans de Goede
2021-08-01 11:35 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2021-08-01 10:27 UTC (permalink / raw)
To: Takashi Iwai
Cc: alsa-devel@alsa-project.org, Mark Brown, Pierre-Louis Bossart
Hi,
On 7/31/21 10:10 AM, Takashi Iwai wrote:
> On Fri, 30 Jul 2021 22:04:00 +0200,
> Hans de Goede wrote:
>>
>> Hi All;,
>>
>> As discussed in the "5.14 regression, Intel SST (BYT) audio no longer works" thread,
>> audio on X86 devices using the Intel SST driver no longer works with 5.14.
>>
>> After poking at this for a while I've found the culprit:
>> 30b7ba6972d5 ("ALSA: core: Add continuous and vmalloc mmap ops")
>>
>> If I revert that single commit then everything works fine again with 5.14.
>
> Does the patch below fix the problem?
Yes that seems to fix things, thank you.
Regards,
Hans
> ---
> --- a/sound/core/memalloc.c
> +++ b/sound/core/memalloc.c
> @@ -215,7 +215,7 @@ static int snd_dma_continuous_mmap(struct snd_dma_buffer *dmab,
> struct vm_area_struct *area)
> {
> return remap_pfn_range(area, area->vm_start,
> - dmab->addr >> PAGE_SHIFT,
> + page_to_pfn(virt_to_page(dmab->area)),
> area->vm_end - area->vm_start,
> area->vm_page_prot);
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [5.14 regression] "ALSA: core: Add continuous and vmalloc mmap ops" breaks Intel SST audio
2021-08-01 10:27 ` Hans de Goede
@ 2021-08-01 11:35 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-08-01 11:35 UTC (permalink / raw)
To: Hans de Goede
Cc: alsa-devel@alsa-project.org, Mark Brown, Pierre-Louis Bossart
On Sun, 01 Aug 2021 12:27:28 +0200,
Hans de Goede wrote:
>
> Hi,
>
> On 7/31/21 10:10 AM, Takashi Iwai wrote:
> > On Fri, 30 Jul 2021 22:04:00 +0200,
> > Hans de Goede wrote:
> >>
> >> Hi All;,
> >>
> >> As discussed in the "5.14 regression, Intel SST (BYT) audio no longer works" thread,
> >> audio on X86 devices using the Intel SST driver no longer works with 5.14.
> >>
> >> After poking at this for a while I've found the culprit:
> >> 30b7ba6972d5 ("ALSA: core: Add continuous and vmalloc mmap ops")
> >>
> >> If I revert that single commit then everything works fine again with 5.14.
> >
> > Does the patch below fix the problem?
>
> Yes that seems to fix things, thank you.
Great, I'll cook up and submit the proper patch.
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-01 11:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 20:04 [5.14 regression] "ALSA: core: Add continuous and vmalloc mmap ops" breaks Intel SST audio Hans de Goede
2021-07-31 8:10 ` Takashi Iwai
2021-08-01 10:27 ` Hans de Goede
2021-08-01 11:35 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.