From: Michal Kazior <michal.kazior@tieto.com>
To: Ben Greear <greearb@candelatech.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath10k <ath10k@lists.infradead.org>
Subject: Re: Don't enable PROMISC when adding AP to a bridge?
Date: Tue, 14 Jul 2015 07:13:17 +0200 [thread overview]
Message-ID: <CA+BoTQmR-7ShZr3FUh-C+LXmZmgFkz_vK9WTW7fLS6akHrZp9Q@mail.gmail.com> (raw)
In-Reply-To: <55A4446C.4090803@candelatech.com>
On 14 July 2015 at 01:06, Ben Greear <greearb@candelatech.com> wrote:
> I notice some of my WLE900VX cards will lock up and not receive any packets
> after a few seconds of being in PROMISC mode. This happens on my own
> CT firmware as well as stock firmware-2.bin. This breaks monitor mode, of
> course, but it also breaks bridged AP mode.
>
> So, I found this patch from way back when:
> http://lists.celinuxforum.org/pipermail/bridge/2008-June/005906.html
>
> I hacked a similar thing into my 4.0.4 kernel, and now bridged mode
> AP seems much more stable (and the radio does not go into PROMISC mode,
> so it should be more efficient in a busy RF environment).
>
> Maybe this feature could be revisited?
This has already been done and mac80211 in 4.2-rc no longer propagates
promisc to drivers[1].
[1]: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/net/mac80211?id=df1404650ccbfeb76a84f301f22316be0d00a864
Michał
WARNING: multiple messages have this Message-ID (diff)
From: Michal Kazior <michal.kazior@tieto.com>
To: Ben Greear <greearb@candelatech.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath10k <ath10k@lists.infradead.org>
Subject: Re: Don't enable PROMISC when adding AP to a bridge?
Date: Tue, 14 Jul 2015 07:13:17 +0200 [thread overview]
Message-ID: <CA+BoTQmR-7ShZr3FUh-C+LXmZmgFkz_vK9WTW7fLS6akHrZp9Q@mail.gmail.com> (raw)
In-Reply-To: <55A4446C.4090803@candelatech.com>
On 14 July 2015 at 01:06, Ben Greear <greearb@candelatech.com> wrote:
> I notice some of my WLE900VX cards will lock up and not receive any packets
> after a few seconds of being in PROMISC mode. This happens on my own
> CT firmware as well as stock firmware-2.bin. This breaks monitor mode, of
> course, but it also breaks bridged AP mode.
>
> So, I found this patch from way back when:
> http://lists.celinuxforum.org/pipermail/bridge/2008-June/005906.html
>
> I hacked a similar thing into my 4.0.4 kernel, and now bridged mode
> AP seems much more stable (and the radio does not go into PROMISC mode,
> so it should be more efficient in a busy RF environment).
>
> Maybe this feature could be revisited?
This has already been done and mac80211 in 4.2-rc no longer propagates
promisc to drivers[1].
[1]: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/net/mac80211?id=df1404650ccbfeb76a84f301f22316be0d00a864
Michał
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-07-14 5:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 23:06 Don't enable PROMISC when adding AP to a bridge? Ben Greear
2015-07-13 23:06 ` Ben Greear
2015-07-14 5:13 ` Michal Kazior [this message]
2015-07-14 5:13 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+BoTQmR-7ShZr3FUh-C+LXmZmgFkz_vK9WTW7fLS6akHrZp9Q@mail.gmail.com \
--to=michal.kazior@tieto.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.