All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* Don't enable PROMISC when adding AP to a bridge?
@ 2015-07-13 23:06 ` Ben Greear
  0 siblings, 0 replies; 4+ messages in thread
From: Ben Greear @ 2015-07-13 23:06 UTC (permalink / raw)
  To: linux-wireless@vger.kernel.org, ath10k

I notice some of my WLE900VX cards will lock up and not receive any packets
after a few seconds of being in PROMISC mode.  This happens on my own
CT firmware as well as stock firmware-2.bin.  This breaks monitor mode, of
course, but it also breaks bridged AP mode.

So, I found this patch from way back when:
http://lists.celinuxforum.org/pipermail/bridge/2008-June/005906.html

I hacked a similar thing into my 4.0.4 kernel, and now bridged mode
AP seems much more stable (and the radio does not go into PROMISC mode,
so it should be more efficient in a busy RF environment).

Maybe this feature could be revisited?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Don't enable PROMISC when adding AP to a bridge?
@ 2015-07-13 23:06 ` Ben Greear
  0 siblings, 0 replies; 4+ messages in thread
From: Ben Greear @ 2015-07-13 23:06 UTC (permalink / raw)
  To: linux-wireless@vger.kernel.org, ath10k

I notice some of my WLE900VX cards will lock up and not receive any packets
after a few seconds of being in PROMISC mode.  This happens on my own
CT firmware as well as stock firmware-2.bin.  This breaks monitor mode, of
course, but it also breaks bridged AP mode.

So, I found this patch from way back when:
http://lists.celinuxforum.org/pipermail/bridge/2008-June/005906.html

I hacked a similar thing into my 4.0.4 kernel, and now bridged mode
AP seems much more stable (and the radio does not go into PROMISC mode,
so it should be more efficient in a busy RF environment).

Maybe this feature could be revisited?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Don't enable PROMISC when adding AP to a bridge?
  2015-07-13 23:06 ` Ben Greear
@ 2015-07-14  5:13   ` Michal Kazior
  -1 siblings, 0 replies; 4+ messages in thread
From: Michal Kazior @ 2015-07-14  5:13 UTC (permalink / raw)
  To: Ben Greear; +Cc: linux-wireless@vger.kernel.org, ath10k

On 14 July 2015 at 01:06, Ben Greear <greearb@candelatech.com> wrote:
> I notice some of my WLE900VX cards will lock up and not receive any packets
> after a few seconds of being in PROMISC mode.  This happens on my own
> CT firmware as well as stock firmware-2.bin.  This breaks monitor mode, of
> course, but it also breaks bridged AP mode.
>
> So, I found this patch from way back when:
> http://lists.celinuxforum.org/pipermail/bridge/2008-June/005906.html
>
> I hacked a similar thing into my 4.0.4 kernel, and now bridged mode
> AP seems much more stable (and the radio does not go into PROMISC mode,
> so it should be more efficient in a busy RF environment).
>
> Maybe this feature could be revisited?

This has already been done and mac80211 in 4.2-rc no longer propagates
promisc to drivers[1].

[1]: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/net/mac80211?id=df1404650ccbfeb76a84f301f22316be0d00a864


Michał

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Don't enable PROMISC when adding AP to a bridge?
@ 2015-07-14  5:13   ` Michal Kazior
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Kazior @ 2015-07-14  5:13 UTC (permalink / raw)
  To: Ben Greear; +Cc: linux-wireless@vger.kernel.org, ath10k

On 14 July 2015 at 01:06, Ben Greear <greearb@candelatech.com> wrote:
> I notice some of my WLE900VX cards will lock up and not receive any packets
> after a few seconds of being in PROMISC mode.  This happens on my own
> CT firmware as well as stock firmware-2.bin.  This breaks monitor mode, of
> course, but it also breaks bridged AP mode.
>
> So, I found this patch from way back when:
> http://lists.celinuxforum.org/pipermail/bridge/2008-June/005906.html
>
> I hacked a similar thing into my 4.0.4 kernel, and now bridged mode
> AP seems much more stable (and the radio does not go into PROMISC mode,
> so it should be more efficient in a busy RF environment).
>
> Maybe this feature could be revisited?

This has already been done and mac80211 in 4.2-rc no longer propagates
promisc to drivers[1].

[1]: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/net/mac80211?id=df1404650ccbfeb76a84f301f22316be0d00a864


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-07-14  5:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-13 23:06 Don't enable PROMISC when adding AP to a bridge? Ben Greear
2015-07-13 23:06 ` Ben Greear
2015-07-14  5:13 ` Michal Kazior
2015-07-14  5:13   ` Michal Kazior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.