From: Daniel Kurtz <djkurtz@chromium.org>
To: James Liao <jamesjj.liao@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Heiko Stubner <heiko@sntech.de>,
srv_heupstream <srv_heupstream@mediatek.com>,
Ricky Liang <jcliang@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3 4/5] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS
Date: Tue, 14 Jul 2015 11:23:41 +0800 [thread overview]
Message-ID: <CAGS+omAb8t0sLP1DHoa6z1-XweWUwOJQhqydofWZ+YiyPXzxhA@mail.gmail.com> (raw)
In-Reply-To: <1436841935.9416.10.camel@mtksdaap41>
On Tue, Jul 14, 2015 at 10:45 AM, James Liao <jamesjj.liao@mediatek.com> wrote:
> Hi Daniel,
>
> On Mon, 2015-07-13 at 22:46 +0800, Daniel Kurtz wrote:
>
>> > +static const struct clk_ops mtk_ref2usb_tx_ops = {
>> > + .is_prepared = mtk_ref2usb_tx_is_prepared,
>> > + .prepare = mtk_ref2usb_tx_prepare,
>> > + .unprepare = mtk_ref2usb_tx_unprepare,
>> > +};
>>
>> Burying the implementation of this special "mtk_ref2usb" clock in
>> clk-mt8173,c seems a bit awkward.
>> Can you please move it to its own file, like mediatek/clk-usb.c?
>
> Do you mean clk/mediatek/clk-usb.c?
>
> This clock is a MT8173 specific clock, which may not be reused by other
> SoCs. So I think it's not necessary to move it to a separated file.
Yes, this is a wrapper for a type of clock. I think it would be
better in its own file, rather than embedded in clk-mt8173.c, which is
more about enumerating and initializing the clock tree.
Perhaps today it is only used for mt8173, but that may not be the case
in the future.
-Dan
>
>> > +
>> > +static struct clk *mtk_clk_register_ref2usb_tx(const char *name,
>> > + const char *parent_name, void __iomem *reg)
>> > +{
>> > + struct mtk_ref2usb_tx *tx;
>> > + struct clk_init_data init = {};
>> > + struct clk *clk;
>> > +
>> > + tx = kzalloc(sizeof(*tx), GFP_KERNEL);
>> > + if (!tx)
>> > + return ERR_PTR(-ENOMEM);
>> > +
>> > + tx->base_addr = reg;
>> > + tx->hw.init = &init;
>> > +
>> > + init.name = name;
>> > + init.ops = &mtk_ref2usb_tx_ops;
>> > + init.parent_names = &parent_name;
>> > + init.num_parents = 1;
>> > +
>> > + clk = clk_register(NULL, &tx->hw);
>> > +
>> > + if (IS_ERR(clk)) {
>> > + pr_err("Failed to register clk %s: %ld\n", name, PTR_ERR(clk));
>> > + kfree(tx);
>> > + }
>> > +
>> > + return clk;
>> > +}
>> > +
>> > +struct mtk_apmixed_ex {
>> > + int id;
>> > + const char *name;
>> > + const char *parent;
>> > + u32 reg_ofs;
>> > +};
>> > +
>> > +#define APMIXED_EX(_id, _name, _parent, _reg_ofs) { \
>> > + .id = _id, \
>> > + .name = _name, \
>> > + .parent = _parent, \
>> > + .reg_ofs = _reg_ofs, \
>> > + }
>> > +
>> > +static const struct mtk_apmixed_ex apmixed_ex[] = {
>>
>> __initconst
>
> OK. I'll fix it in next patch.
>
>> > + APMIXED_EX(CLK_APMIXED_REF2USB_TX, "ref2usb_tx", "clk26m", 0x8),
>> > +};
>> > +
>> > +static void __init mtk_clk_register_apmixedsys_special(struct device_node *node,
>> > + struct clk_onecell_data *clk_data)
>> > +{
>> > + void __iomem *base;
>> > + struct clk *clk;
>> > + int i;
>> > +
>> > + base = of_iomap(node, 0);
>> > + if (!base) {
>> > + pr_err("%s(): ioremap failed\n", __func__);
>> > + return;
>> > + }
>> > +
>> > + for (i = 0; i < ARRAY_SIZE(apmixed_ex); i++) {
>> > + const struct mtk_apmixed_ex *ape = &apmixed_ex[i];
>> > +
>> > + clk = mtk_clk_register_ref2usb_tx(ape->name, ape->parent,
>> > + base + ape->reg_ofs);
>> > +
>> > + if (IS_ERR(clk)) {
>> > + pr_err("Failed to register clk %s: %ld\n", ape->name,
>> > + PTR_ERR(clk));
>> > + continue;
>> > + }
>> > +
>> > + clk_data->clks[CLK_APMIXED_REF2USB_TX] = clk;
>>
>> This works assuming ARRAY_SIZE(apmixed_ex) == 1.
>> Either remove the loop since it is unnecessary, or do:
>> clk_data->clks[ape->id] = clk;
>
> It should be "clk_data->clks[ape->id] = clk". I'll fix it in next patch.
>
>
> Best regards,
>
> James
>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: James Liao <jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mike Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Heiko Stubner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
srv_heupstream
<srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Ricky Liang <jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"open list:OPEN FIRMWARE AND..."
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 4/5] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS
Date: Tue, 14 Jul 2015 11:23:41 +0800 [thread overview]
Message-ID: <CAGS+omAb8t0sLP1DHoa6z1-XweWUwOJQhqydofWZ+YiyPXzxhA@mail.gmail.com> (raw)
In-Reply-To: <1436841935.9416.10.camel@mtksdaap41>
On Tue, Jul 14, 2015 at 10:45 AM, James Liao <jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
> Hi Daniel,
>
> On Mon, 2015-07-13 at 22:46 +0800, Daniel Kurtz wrote:
>
>> > +static const struct clk_ops mtk_ref2usb_tx_ops = {
>> > + .is_prepared = mtk_ref2usb_tx_is_prepared,
>> > + .prepare = mtk_ref2usb_tx_prepare,
>> > + .unprepare = mtk_ref2usb_tx_unprepare,
>> > +};
>>
>> Burying the implementation of this special "mtk_ref2usb" clock in
>> clk-mt8173,c seems a bit awkward.
>> Can you please move it to its own file, like mediatek/clk-usb.c?
>
> Do you mean clk/mediatek/clk-usb.c?
>
> This clock is a MT8173 specific clock, which may not be reused by other
> SoCs. So I think it's not necessary to move it to a separated file.
Yes, this is a wrapper for a type of clock. I think it would be
better in its own file, rather than embedded in clk-mt8173.c, which is
more about enumerating and initializing the clock tree.
Perhaps today it is only used for mt8173, but that may not be the case
in the future.
-Dan
>
>> > +
>> > +static struct clk *mtk_clk_register_ref2usb_tx(const char *name,
>> > + const char *parent_name, void __iomem *reg)
>> > +{
>> > + struct mtk_ref2usb_tx *tx;
>> > + struct clk_init_data init = {};
>> > + struct clk *clk;
>> > +
>> > + tx = kzalloc(sizeof(*tx), GFP_KERNEL);
>> > + if (!tx)
>> > + return ERR_PTR(-ENOMEM);
>> > +
>> > + tx->base_addr = reg;
>> > + tx->hw.init = &init;
>> > +
>> > + init.name = name;
>> > + init.ops = &mtk_ref2usb_tx_ops;
>> > + init.parent_names = &parent_name;
>> > + init.num_parents = 1;
>> > +
>> > + clk = clk_register(NULL, &tx->hw);
>> > +
>> > + if (IS_ERR(clk)) {
>> > + pr_err("Failed to register clk %s: %ld\n", name, PTR_ERR(clk));
>> > + kfree(tx);
>> > + }
>> > +
>> > + return clk;
>> > +}
>> > +
>> > +struct mtk_apmixed_ex {
>> > + int id;
>> > + const char *name;
>> > + const char *parent;
>> > + u32 reg_ofs;
>> > +};
>> > +
>> > +#define APMIXED_EX(_id, _name, _parent, _reg_ofs) { \
>> > + .id = _id, \
>> > + .name = _name, \
>> > + .parent = _parent, \
>> > + .reg_ofs = _reg_ofs, \
>> > + }
>> > +
>> > +static const struct mtk_apmixed_ex apmixed_ex[] = {
>>
>> __initconst
>
> OK. I'll fix it in next patch.
>
>> > + APMIXED_EX(CLK_APMIXED_REF2USB_TX, "ref2usb_tx", "clk26m", 0x8),
>> > +};
>> > +
>> > +static void __init mtk_clk_register_apmixedsys_special(struct device_node *node,
>> > + struct clk_onecell_data *clk_data)
>> > +{
>> > + void __iomem *base;
>> > + struct clk *clk;
>> > + int i;
>> > +
>> > + base = of_iomap(node, 0);
>> > + if (!base) {
>> > + pr_err("%s(): ioremap failed\n", __func__);
>> > + return;
>> > + }
>> > +
>> > + for (i = 0; i < ARRAY_SIZE(apmixed_ex); i++) {
>> > + const struct mtk_apmixed_ex *ape = &apmixed_ex[i];
>> > +
>> > + clk = mtk_clk_register_ref2usb_tx(ape->name, ape->parent,
>> > + base + ape->reg_ofs);
>> > +
>> > + if (IS_ERR(clk)) {
>> > + pr_err("Failed to register clk %s: %ld\n", ape->name,
>> > + PTR_ERR(clk));
>> > + continue;
>> > + }
>> > +
>> > + clk_data->clks[CLK_APMIXED_REF2USB_TX] = clk;
>>
>> This works assuming ARRAY_SIZE(apmixed_ex) == 1.
>> Either remove the loop since it is unnecessary, or do:
>> clk_data->clks[ape->id] = clk;
>
> It should be "clk_data->clks[ape->id] = clk". I'll fix it in next patch.
>
>
> Best regards,
>
> James
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: djkurtz@chromium.org (Daniel Kurtz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/5] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS
Date: Tue, 14 Jul 2015 11:23:41 +0800 [thread overview]
Message-ID: <CAGS+omAb8t0sLP1DHoa6z1-XweWUwOJQhqydofWZ+YiyPXzxhA@mail.gmail.com> (raw)
In-Reply-To: <1436841935.9416.10.camel@mtksdaap41>
On Tue, Jul 14, 2015 at 10:45 AM, James Liao <jamesjj.liao@mediatek.com> wrote:
> Hi Daniel,
>
> On Mon, 2015-07-13 at 22:46 +0800, Daniel Kurtz wrote:
>
>> > +static const struct clk_ops mtk_ref2usb_tx_ops = {
>> > + .is_prepared = mtk_ref2usb_tx_is_prepared,
>> > + .prepare = mtk_ref2usb_tx_prepare,
>> > + .unprepare = mtk_ref2usb_tx_unprepare,
>> > +};
>>
>> Burying the implementation of this special "mtk_ref2usb" clock in
>> clk-mt8173,c seems a bit awkward.
>> Can you please move it to its own file, like mediatek/clk-usb.c?
>
> Do you mean clk/mediatek/clk-usb.c?
>
> This clock is a MT8173 specific clock, which may not be reused by other
> SoCs. So I think it's not necessary to move it to a separated file.
Yes, this is a wrapper for a type of clock. I think it would be
better in its own file, rather than embedded in clk-mt8173.c, which is
more about enumerating and initializing the clock tree.
Perhaps today it is only used for mt8173, but that may not be the case
in the future.
-Dan
>
>> > +
>> > +static struct clk *mtk_clk_register_ref2usb_tx(const char *name,
>> > + const char *parent_name, void __iomem *reg)
>> > +{
>> > + struct mtk_ref2usb_tx *tx;
>> > + struct clk_init_data init = {};
>> > + struct clk *clk;
>> > +
>> > + tx = kzalloc(sizeof(*tx), GFP_KERNEL);
>> > + if (!tx)
>> > + return ERR_PTR(-ENOMEM);
>> > +
>> > + tx->base_addr = reg;
>> > + tx->hw.init = &init;
>> > +
>> > + init.name = name;
>> > + init.ops = &mtk_ref2usb_tx_ops;
>> > + init.parent_names = &parent_name;
>> > + init.num_parents = 1;
>> > +
>> > + clk = clk_register(NULL, &tx->hw);
>> > +
>> > + if (IS_ERR(clk)) {
>> > + pr_err("Failed to register clk %s: %ld\n", name, PTR_ERR(clk));
>> > + kfree(tx);
>> > + }
>> > +
>> > + return clk;
>> > +}
>> > +
>> > +struct mtk_apmixed_ex {
>> > + int id;
>> > + const char *name;
>> > + const char *parent;
>> > + u32 reg_ofs;
>> > +};
>> > +
>> > +#define APMIXED_EX(_id, _name, _parent, _reg_ofs) { \
>> > + .id = _id, \
>> > + .name = _name, \
>> > + .parent = _parent, \
>> > + .reg_ofs = _reg_ofs, \
>> > + }
>> > +
>> > +static const struct mtk_apmixed_ex apmixed_ex[] = {
>>
>> __initconst
>
> OK. I'll fix it in next patch.
>
>> > + APMIXED_EX(CLK_APMIXED_REF2USB_TX, "ref2usb_tx", "clk26m", 0x8),
>> > +};
>> > +
>> > +static void __init mtk_clk_register_apmixedsys_special(struct device_node *node,
>> > + struct clk_onecell_data *clk_data)
>> > +{
>> > + void __iomem *base;
>> > + struct clk *clk;
>> > + int i;
>> > +
>> > + base = of_iomap(node, 0);
>> > + if (!base) {
>> > + pr_err("%s(): ioremap failed\n", __func__);
>> > + return;
>> > + }
>> > +
>> > + for (i = 0; i < ARRAY_SIZE(apmixed_ex); i++) {
>> > + const struct mtk_apmixed_ex *ape = &apmixed_ex[i];
>> > +
>> > + clk = mtk_clk_register_ref2usb_tx(ape->name, ape->parent,
>> > + base + ape->reg_ofs);
>> > +
>> > + if (IS_ERR(clk)) {
>> > + pr_err("Failed to register clk %s: %ld\n", ape->name,
>> > + PTR_ERR(clk));
>> > + continue;
>> > + }
>> > +
>> > + clk_data->clks[CLK_APMIXED_REF2USB_TX] = clk;
>>
>> This works assuming ARRAY_SIZE(apmixed_ex) == 1.
>> Either remove the loop since it is unnecessary, or do:
>> clk_data->clks[ape->id] = clk;
>
> It should be "clk_data->clks[ape->id] = clk". I'll fix it in next patch.
>
>
> Best regards,
>
> James
>
next prev parent reply other threads:[~2015-07-14 3:24 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 10:00 [PATCH v3 0/5] Add Mediatek MT8173 subsystem clocks support James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 10:00 ` [PATCH v3 1/5] clk: mediatek: mt8173: Fix enabling of critical clocks James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 10:00 ` [PATCH v3 2/5] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 10:00 ` [PATCH v3 3/5] clk: mediatek: Add subsystem clocks of MT8173 James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 10:00 ` [PATCH v3 4/5] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 10:00 ` James Liao
2015-07-13 14:46 ` Daniel Kurtz
2015-07-13 14:46 ` Daniel Kurtz
2015-07-13 14:46 ` Daniel Kurtz
2015-07-14 2:45 ` James Liao
2015-07-14 2:45 ` James Liao
2015-07-14 2:45 ` James Liao
2015-07-14 3:23 ` Daniel Kurtz [this message]
2015-07-14 3:23 ` Daniel Kurtz
2015-07-14 3:23 ` Daniel Kurtz
2015-07-14 9:46 ` James Liao
2015-07-14 9:46 ` James Liao
2015-07-14 9:46 ` James Liao
2015-07-14 10:15 ` Daniel Kurtz
2015-07-14 10:15 ` Daniel Kurtz
2015-07-14 10:15 ` Daniel Kurtz
2015-07-10 10:00 ` [PATCH v3 5/5] arm64: dts: mt8173: Add subsystem clock controller device nodes James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 10:00 ` James Liao
2015-07-10 15:02 ` Daniel Kurtz
2015-07-10 15:58 ` Matthias Brugger
2015-07-10 15:58 ` Matthias Brugger
2015-07-13 3:34 ` James Liao
2015-07-13 3:34 ` James Liao
2015-07-13 3:34 ` James Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGS+omAb8t0sLP1DHoa6z1-XweWUwOJQhqydofWZ+YiyPXzxhA@mail.gmail.com \
--to=djkurtz@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jamesjj.liao@mediatek.com \
--cc=jcliang@chromium.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.