From: Chanwoo Choi <cwchoi00@gmail.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state
Date: Fri, 19 Jun 2015 21:29:34 +0900 [thread overview]
Message-ID: <CAGTfZH2azMuseUMHT2cvkqHpCYhrdpyXJgFOQ4z+rebA=UWUUg@mail.gmail.com> (raw)
In-Reply-To: <1434709467-28147-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
Hi Charles,
I'm sorry about lack of my commet on previous patch.
I just want to know the what is meaning of zero(0) index of
"info->micd_modes[0] array"
instead of separate variable (gpio_initial_level).
So, I'd like you to drop this patch on next your patch-set.
Thanks,
Chanwoo Choi
On Fri, Jun 19, 2015 at 7:24 PM, Charles Keepax
<ckeepax@opensource.wolfsonmicro.com> wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/extcon/extcon-arizona.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 9262b45..e31613a 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1135,6 +1135,7 @@ static int arizona_extcon_probe(struct platform_device *pdev)
> struct arizona *arizona = dev_get_drvdata(pdev->dev.parent);
> struct arizona_pdata *pdata = &arizona->pdata;
> struct arizona_extcon_info *info;
> + int gpio_initial_level;
> unsigned int val;
> unsigned int clamp_mode;
> int jack_irq_fall, jack_irq_rise;
> @@ -1226,8 +1227,9 @@ static int arizona_extcon_probe(struct platform_device *pdev)
> info->micd_num_modes = ARRAY_SIZE(micd_default_modes);
> }
>
> + gpio_initial_level = info->micd_modes[0].gpio;
> if (arizona->pdata.micd_pol_gpio > 0) {
> - if (info->micd_modes[0].gpio)
> + if (gpio_initial_level)
> mode = GPIOF_OUT_INIT_HIGH;
> else
> mode = GPIOF_OUT_INIT_LOW;
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-19 12:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 10:24 [PATCH v3 0/7] Add basic microphone detection bindings Charles Keepax
2015-06-19 10:24 ` [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state Charles Keepax
2015-06-19 12:29 ` Chanwoo Choi [this message]
2015-06-19 12:54 ` Charles Keepax
2015-06-19 10:24 ` [PATCH v3 2/7] extcon: arizona: Update to use the new device properties API Charles Keepax
2015-06-19 10:24 ` [PATCH v3 3/7] extcon: arizona: Add basic microphone detection DT/ACPI bindings Charles Keepax
2015-06-19 10:24 ` [PATCH v3 4/7] extcon: arizona: Convert to gpiod Charles Keepax
2015-06-19 10:24 ` [PATCH v3 5/7] extcon: arizona: Ensure variables are set for headphone detection Charles Keepax
2015-06-19 10:24 ` [PATCH v3 6/7] mfd: arizona: Update DT doc for new mic detection bindings Charles Keepax
2015-06-24 14:15 ` Lee Jones
2015-06-24 15:41 ` Charles Keepax
2015-06-25 8:53 ` Lee Jones
2015-06-25 8:53 ` Lee Jones
2015-06-19 10:24 ` [PATCH v3 7/7] mfd: arizona: Update several pdata members to unsigned Charles Keepax
2015-06-24 14:16 ` Lee Jones
2015-06-19 10:46 ` [PATCH v3 0/7] Add basic microphone detection bindings Charles Keepax
-- strict thread matches above, loose matches on Subject: below --
2015-06-19 10:33 Charles Keepax
2015-06-19 10:33 ` [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state Charles Keepax
2015-06-19 10:33 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGTfZH2azMuseUMHT2cvkqHpCYhrdpyXJgFOQ4z+rebA=UWUUg@mail.gmail.com' \
--to=cwchoi00@gmail.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.