From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: cw00.choi@samsung.com, myungjoo.ham@samsung.com,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v3 7/7] mfd: arizona: Update several pdata members to unsigned
Date: Wed, 24 Jun 2015 15:16:17 +0100 [thread overview]
Message-ID: <20150624141617.GO15013@x1> (raw)
In-Reply-To: <1434709467-28147-8-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Fri, 19 Jun 2015, Charles Keepax wrote:
> Device tree and ACPI primarily deal with unsigned ints, many of the
> pdata members in the Arizona driver are signed ints but are only ever
> assigned positive values. Changing these pdata fields to unsigned ints
> avoids us having to choose between overly verbose code and Sparse
> warnings.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> include/linux/mfd/arizona/pdata.h | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
Applied for v4.3, thanks.
> diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h
> index af44081..f2c8381 100644
> --- a/include/linux/mfd/arizona/pdata.h
> +++ b/include/linux/mfd/arizona/pdata.h
> @@ -104,7 +104,7 @@ struct arizona_pdata {
> * useful for systems where and I2S bus with multiple data
> * lines is mastered.
> */
> - int max_channels_clocked[ARIZONA_MAX_AIF];
> + unsigned int max_channels_clocked[ARIZONA_MAX_AIF];
>
> /** GPIO5 is used for jack detection */
> bool jd_gpio5;
> @@ -128,22 +128,22 @@ struct arizona_pdata {
> unsigned int hpdet_channel;
>
> /** Extra debounce timeout used during initial mic detection (ms) */
> - int micd_detect_debounce;
> + unsigned int micd_detect_debounce;
>
> /** GPIO for mic detection polarity */
> int micd_pol_gpio;
>
> /** Mic detect ramp rate */
> - int micd_bias_start_time;
> + unsigned int micd_bias_start_time;
>
> /** Mic detect sample rate */
> - int micd_rate;
> + unsigned int micd_rate;
>
> /** Mic detect debounce level */
> - int micd_dbtime;
> + unsigned int micd_dbtime;
>
> /** Mic detect timeout (ms) */
> - int micd_timeout;
> + unsigned int micd_timeout;
>
> /** Force MICBIAS on for mic detect */
> bool micd_force_micbias;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-06-24 14:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 10:24 [PATCH v3 0/7] Add basic microphone detection bindings Charles Keepax
2015-06-19 10:24 ` [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state Charles Keepax
2015-06-19 12:29 ` Chanwoo Choi
2015-06-19 12:54 ` Charles Keepax
2015-06-19 10:24 ` [PATCH v3 2/7] extcon: arizona: Update to use the new device properties API Charles Keepax
2015-06-19 10:24 ` [PATCH v3 3/7] extcon: arizona: Add basic microphone detection DT/ACPI bindings Charles Keepax
2015-06-19 10:24 ` [PATCH v3 4/7] extcon: arizona: Convert to gpiod Charles Keepax
2015-06-19 10:24 ` [PATCH v3 5/7] extcon: arizona: Ensure variables are set for headphone detection Charles Keepax
2015-06-19 10:24 ` [PATCH v3 6/7] mfd: arizona: Update DT doc for new mic detection bindings Charles Keepax
2015-06-24 14:15 ` Lee Jones
2015-06-24 15:41 ` Charles Keepax
2015-06-25 8:53 ` Lee Jones
2015-06-25 8:53 ` Lee Jones
2015-06-19 10:24 ` [PATCH v3 7/7] mfd: arizona: Update several pdata members to unsigned Charles Keepax
2015-06-24 14:16 ` Lee Jones [this message]
2015-06-19 10:46 ` [PATCH v3 0/7] Add basic microphone detection bindings Charles Keepax
-- strict thread matches above, loose matches on Subject: below --
2015-06-19 10:33 Charles Keepax
2015-06-19 10:33 ` [PATCH v3 7/7] mfd: arizona: Update several pdata members to unsigned Charles Keepax
2015-06-19 10:33 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624141617.GO15013@x1 \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.