From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Shannon Zhao <zhaoshenglong@huawei.com>,
"shannon.zhao@linaro.org" <shannon.zhao@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Daniel Kiper <daniel.kiper@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"julien.grall@citrix.com" <julien.grall@citrix.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters
Date: Mon, 14 Sep 2015 11:36:32 +0200 [thread overview]
Message-ID: <CAKv+Gu-2kyd3Gf3ceSa1jdgCjqJ8zBCesa4xehLiZ+VzergS3Q__49336.5115406506$1442223469$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <55F693F5.8030203@huawei.com>
(snip some cc's)
On 14 September 2015 at 11:31, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
>
>
> On 2015/9/14 17:09, Ard Biesheuvel wrote:
>> On 14 September 2015 at 10:42, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
>> [..]
>>
>>>
>>> It only needs to apply following patch to fix a bug in Linux kernel when
>>> mapping EFI_MEMORY_RUNTIME memory.
>>>
>>
>> Could you explain why you think efi_virtmap_init() should fail if
>> there are no EFI_MEMORY_RUNTIME regions?
>>
>
> My understanding is that if there are no EFI_MEMORY_RUNTIME regions, it
> means we can't use runtime services and should not set the bit
> EFI_RUNTIME_SERVICES of efi.flags. But if efi_virtmap_init() return
> true, the bit will be set.
>
As I said, if you don't want the EFI_RUNTIME_SERVICES bit to be set
for other reasons, don't rig efi_virtmap_init() to return false when
it shouldn't.
>> The absence of such regions is allowed by the spec, so
>> efi_virtmap_init() is correct imo to return success.
>>
> Sorry, not well know about the spec. Could you point out where the spec
> says this?
>
Well, I think it doesn't work that way. You are claiming that a memory
map without at least one EFI_MEMORY_RUNTIME constitutes an error
condition, so the burden is on you to provide a reference to the spec
that says you must have at least one such region.
--
Ard.
next prev parent reply other threads:[~2015-09-14 9:36 UTC|newest]
Thread overview: 182+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 8:41 [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters Shannon Zhao
2015-09-10 8:41 ` Shannon Zhao
2015-09-10 8:41 ` Shannon Zhao
2015-09-10 9:52 ` Mark Rutland
2015-09-10 9:52 ` Mark Rutland
2015-09-10 9:52 ` Mark Rutland
2015-09-10 9:52 ` Mark Rutland
2015-09-10 10:19 ` Stefano Stabellini
2015-09-10 10:19 ` Stefano Stabellini
2015-09-10 10:19 ` Stefano Stabellini
2015-09-10 10:19 ` Stefano Stabellini
2015-09-10 11:24 ` Mark Rutland
2015-09-10 11:24 ` Mark Rutland
2015-09-10 11:24 ` Mark Rutland
2015-09-10 11:24 ` Mark Rutland
2015-09-10 11:37 ` Stefano Stabellini
2015-09-10 11:37 ` Stefano Stabellini
2015-09-10 11:37 ` Stefano Stabellini
2015-09-10 11:37 ` Stefano Stabellini
2015-09-10 12:15 ` Mark Rutland
2015-09-10 12:15 ` Mark Rutland
2015-09-10 12:15 ` Mark Rutland
2015-09-10 12:15 ` Mark Rutland
2015-09-10 12:58 ` [Xen-devel] " Ian Campbell
2015-09-10 12:58 ` Ian Campbell
2015-09-10 12:58 ` Ian Campbell
2015-09-10 13:08 ` Jan Beulich
2015-09-10 13:08 ` Jan Beulich
2015-09-10 13:08 ` Jan Beulich
2015-09-10 13:30 ` Ian Campbell
2015-09-10 13:30 ` [Xen-devel] " Ian Campbell
2015-09-10 13:30 ` Ian Campbell
2015-09-10 13:30 ` Ian Campbell
2015-09-10 13:08 ` Jan Beulich
2015-09-10 12:58 ` Ian Campbell
2015-09-10 13:52 ` Stefano Stabellini
2015-09-10 13:52 ` Stefano Stabellini
2015-09-10 13:52 ` Stefano Stabellini
2015-09-10 14:13 ` Leif Lindholm
2015-09-10 14:13 ` Leif Lindholm
2015-09-10 14:13 ` Leif Lindholm
2015-09-10 14:13 ` Leif Lindholm
2015-09-10 14:49 ` Mark Rutland
2015-09-10 14:49 ` Mark Rutland
2015-09-10 14:49 ` Mark Rutland
2015-09-10 16:10 ` Stefano Stabellini
2015-09-10 16:10 ` Stefano Stabellini
2015-09-10 16:10 ` Stefano Stabellini
2015-09-10 16:10 ` Stefano Stabellini
2015-09-10 16:23 ` Mark Rutland
2015-09-10 16:23 ` Mark Rutland
2015-09-10 16:23 ` Mark Rutland
2015-09-10 16:23 ` Mark Rutland
2015-09-11 12:46 ` Daniel Kiper
2015-09-11 12:46 ` Daniel Kiper
2015-09-11 12:46 ` Daniel Kiper
2015-09-11 13:14 ` Stefano Stabellini
2015-09-11 13:14 ` Stefano Stabellini
2015-09-11 13:14 ` Stefano Stabellini
2015-09-11 13:30 ` Ard Biesheuvel
2015-09-11 13:30 ` Ard Biesheuvel
2015-09-11 13:30 ` Ard Biesheuvel
2015-09-11 13:30 ` Ard Biesheuvel
2015-09-11 15:45 ` Daniel Kiper
2015-09-11 15:45 ` Daniel Kiper
2015-09-11 15:45 ` Daniel Kiper
2015-09-14 8:42 ` Shannon Zhao
2015-09-14 8:42 ` Shannon Zhao
2015-09-14 8:42 ` Shannon Zhao
2015-09-14 9:09 ` Ard Biesheuvel
2015-09-14 9:09 ` Ard Biesheuvel
2015-09-14 9:09 ` Ard Biesheuvel
2015-09-14 9:09 ` Ard Biesheuvel
2015-09-14 9:31 ` Shannon Zhao
2015-09-14 9:31 ` Shannon Zhao
2015-09-14 9:31 ` Shannon Zhao
2015-09-14 9:36 ` Ard Biesheuvel [this message]
2015-09-14 9:36 ` Ard Biesheuvel
2015-09-14 9:36 ` Ard Biesheuvel
2015-09-14 9:36 ` Ard Biesheuvel
2015-09-14 10:39 ` [Xen-devel] " Jan Beulich
2015-09-14 10:39 ` Jan Beulich
2015-09-14 10:39 ` Jan Beulich
2015-09-14 11:16 ` Ard Biesheuvel
2015-09-14 11:16 ` [Xen-devel] " Ard Biesheuvel
2015-09-14 11:16 ` Ard Biesheuvel
2015-09-14 11:16 ` Ard Biesheuvel
2015-09-14 11:34 ` Jan Beulich
2015-09-14 11:34 ` Jan Beulich
2015-09-14 11:34 ` Jan Beulich
2015-09-14 11:34 ` Jan Beulich
2015-09-14 10:39 ` Jan Beulich
2015-09-11 15:45 ` Daniel Kiper
2015-09-11 16:33 ` Mark Rutland
2015-09-11 16:33 ` Mark Rutland
2015-09-11 16:33 ` Mark Rutland
2015-09-11 16:33 ` Mark Rutland
2015-09-11 13:14 ` Stefano Stabellini
2015-09-11 16:25 ` Mark Rutland
2015-09-11 16:25 ` Mark Rutland
2015-09-11 16:25 ` Mark Rutland
2015-09-11 16:25 ` Mark Rutland
2015-09-12 11:36 ` Daniel Kiper
2015-09-12 11:36 ` Daniel Kiper
2015-09-12 11:36 ` Daniel Kiper
2015-09-12 11:36 ` Daniel Kiper
2015-09-14 9:25 ` Mark Rutland
2015-09-14 9:25 ` Mark Rutland
2015-09-14 9:25 ` Mark Rutland
2015-09-14 9:43 ` Ard Biesheuvel
2015-09-14 9:43 ` Ard Biesheuvel
2015-09-14 9:43 ` Ard Biesheuvel
2015-09-14 9:57 ` Ian Campbell
[not found] ` <CAKv+Gu9ER1cKvPHobq-wo7ggPesJj4OQ7=aTr24GVpubHvVqjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-14 9:57 ` Ian Campbell
2015-09-14 9:57 ` Ian Campbell
2015-09-14 10:02 ` Ard Biesheuvel
[not found] ` <1442224673.3549.131.camel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2015-09-14 10:02 ` Ard Biesheuvel
2015-09-14 10:02 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_Gh649EwdtodLY9Q28JhqYg8o6RShXXH1ZbxsfYRfi2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-14 10:25 ` Ian Campbell
2015-09-14 10:25 ` Ian Campbell
2015-09-14 10:25 ` Ian Campbell
2015-09-14 12:28 ` Daniel Kiper
2015-09-14 12:28 ` Daniel Kiper
2015-09-14 13:09 ` Ard Biesheuvel
[not found] ` <20150914122858.GI4530-fJNZiO034lp9pOct4yEdx/3oZC3j2Omk@public.gmane.org>
2015-09-14 13:09 ` Ard Biesheuvel
2015-09-14 13:09 ` Ard Biesheuvel
2015-09-14 13:57 ` Daniel Kiper
[not found] ` <CAKv+Gu_z2X=9-qgoKTS7dKLqtSUvysyu9LzZryJqcSR4X8Ss6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-14 13:57 ` Daniel Kiper
2015-09-14 13:57 ` Daniel Kiper
2015-09-14 12:28 ` Daniel Kiper
2015-09-14 9:47 ` Stefano Stabellini
2015-09-14 9:47 ` Stefano Stabellini
2015-09-14 9:47 ` Stefano Stabellini
2015-09-14 9:47 ` Stefano Stabellini
2015-09-14 12:19 ` Daniel Kiper
2015-09-14 12:19 ` Daniel Kiper
2015-09-14 12:19 ` Daniel Kiper
2015-09-14 12:19 ` Daniel Kiper
2015-09-14 9:25 ` Mark Rutland
2015-09-11 12:46 ` Daniel Kiper
2015-09-11 11:00 ` Ian Campbell
2015-09-11 11:00 ` Ian Campbell
2015-09-11 11:00 ` Ian Campbell
2015-09-11 11:00 ` Ian Campbell
2015-09-10 14:49 ` Mark Rutland
2015-09-10 13:52 ` Stefano Stabellini
2015-09-10 12:55 ` Jan Beulich
2015-09-10 12:55 ` Jan Beulich
2015-09-10 12:55 ` Jan Beulich
2015-09-10 14:53 ` Mark Rutland
2015-09-10 14:53 ` Mark Rutland
2015-09-10 14:53 ` Mark Rutland
2015-09-10 15:06 ` Jan Beulich
2015-09-10 15:06 ` Jan Beulich
2015-09-10 15:06 ` Jan Beulich
2015-09-11 16:36 ` Mark Rutland
2015-09-11 16:36 ` Mark Rutland
2015-09-11 16:36 ` Mark Rutland
2015-09-11 16:36 ` Mark Rutland
2015-09-10 15:06 ` Jan Beulich
2015-09-10 12:55 ` Jan Beulich
2015-09-10 11:32 ` Andrew Turner
2015-09-10 11:32 ` Andrew Turner
2015-09-10 11:32 ` Andrew Turner
2015-09-10 11:32 ` Andrew Turner
2015-09-10 11:48 ` Julien Grall
2015-09-10 11:48 ` Julien Grall
2015-09-10 11:48 ` Julien Grall
2015-09-10 12:05 ` Roger Pau Monné
2015-09-10 12:05 ` Roger Pau Monné
2015-09-10 12:05 ` Roger Pau Monné
2015-09-10 12:05 ` Roger Pau Monné
2015-09-10 12:53 ` Julien Grall
2015-09-10 12:53 ` [Xen-devel] " Julien Grall
2015-09-10 12:53 ` Julien Grall
2015-09-10 12:53 ` Julien Grall
2015-09-10 11:48 ` Julien Grall
2015-09-17 11:43 ` Shannon Zhao
2015-09-17 11:43 ` Shannon Zhao
2015-09-17 11:43 ` Shannon Zhao
2015-09-17 11:43 ` Shannon Zhao
-- strict thread matches above, loose matches on Subject: below --
2015-09-10 8:41 Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-2kyd3Gf3ceSa1jdgCjqJ8zBCesa4xehLiZ+VzergS3Q__49336.5115406506$1442223469$gmane$org@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=julien.grall@citrix.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shannon.zhao@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.